Skip to content

Commit 58574a4

Browse files
authored
chore(queries): Enable safety check by default in RangeQuerySetWrapper (#69461)
This was causing failures in getsentry, so I temporarily disabled the check by default. Now that we've fixed issues in getsentry, re-enabling by default
1 parent 472fb6c commit 58574a4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/sentry/utils/query.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def __init__(
9090
order_by="pk",
9191
callbacks=(),
9292
result_value_getter=None,
93-
override_unique_safety_check=True,
93+
override_unique_safety_check=False,
9494
):
9595
# Support for slicing
9696
if queryset.query.low_mark == 0 and not (

tests/sentry/utils/test_query.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ def test_empty(self):
6060
def test_order_by_non_unique_fails(self):
6161
qs = User.objects.all()
6262
with pytest.raises(InvalidQuerySetError):
63-
self.range_wrapper(qs, order_by="name", override_unique_safety_check=False)
63+
self.range_wrapper(qs, order_by="name")
6464

6565
# Shouldn't error if the safety check is disabled
6666
self.range_wrapper(qs, order_by="name", override_unique_safety_check=True)
6767

6868
def test_order_by_unique(self):
6969
self.create_user()
7070
qs = User.objects.all()
71-
self.range_wrapper(qs, order_by="username", override_unique_safety_check=False)
71+
self.range_wrapper(qs, order_by="username")
7272
assert len(list(self.range_wrapper(qs, order_by="username", step=2))) == 1
7373

7474

0 commit comments

Comments
 (0)