cleanup

Author: ceorourke

src/sentry/incidents/endpoints/organization_alert_rule_index.py

@@ -159,7 +159,7 @@ def fetch_metric_alert(
 
         if features.has("organizations:workflow-engine-rule-serializers", organization):
             detectors = Detector.objects.filter(
-                alertruledetector__alert_rule_id__in=[alert_rule.id for alert_rule in alert_rules],
+                alertruledetector__alert_rule_id__in=[alert_rule.id for alert_rule in alert_rules]
             )
             if not len(detectors):
                 return Response(status=status.HTTP_404_NOT_FOUND)

src/sentry/incidents/endpoints/project_alert_rule_task_details.py

@@ -49,7 +49,7 @@ def get(self, request: Request, project, task_uuid) -> Response:
                 ):
                     try:
                         detector = Detector.objects.get(
-                            alertruledetector__alert_rule_id=alert_rule.id,
+                            alertruledetector__alert_rule_id=alert_rule.id
                         )
                     except Detector.DoesNotExist:
                         raise Http404

src/sentry/incidents/endpoints/serializers/workflow_engine_data_condition.py

@@ -43,7 +43,7 @@ def get_attrs(
                 workflow_condition_group__in=[
                     detector_trigger.condition_group
                     for detector_trigger in detector_triggers.values()
-                ],
+                ]
             ).values_list("id", flat=True)
         )
         workflow_dcg_ids = DataConditionGroup.objects.filter(

src/sentry/notifications/notification_action/metric_alert_registry/handlers/discord_metric_alert_handler.py

@@ -1,4 +1,3 @@
-from sentry.constants import ObjectStatus
 from sentry.incidents.models.incident import TriggerStatus
 from sentry.incidents.typings.metric_detector import (
     AlertContext,
@@ -37,9 +36,7 @@ def send_alert(
             send_incident_alert_notification,
         )
 
-        detector = Detector.objects.get(
-            id=alert_context.action_identifier_id, status=ObjectStatus.ACTIVE
-        )
+        detector = Detector.objects.get(id=alert_context.action_identifier_id)
         if not detector:
             raise ValueError("Detector not found")
 

src/sentry/workflow_engine/endpoints/organization_detector_details.py

@@ -59,9 +59,7 @@ class OrganizationDetectorDetailsEndpoint(OrganizationEndpoint):
     def convert_args(self, request: Request, detector_id, *args, **kwargs):
         args, kwargs = super().convert_args(request, *args, **kwargs)
         try:
-            detector = Detector.objects.select_related("project").get(
-                id=detector_id,
-            )
+            detector = Detector.objects.select_related("project").get(id=detector_id)
             if detector.project.organization_id != kwargs["organization"].id:
                 raise ResourceDoesNotExist
             kwargs["detector"] = detector