Skip to content

Commit 593978b

Browse files
authored
ref(cache): update transaction title, update chart tooltips, remove legend (#70599)
1. Update `txn` titles to `transaction` 2. Add more human readible tooltip on cache miss rate chart and transaction duration chart 3. Remove legend on cache miss chart as it only has one series.
1 parent f5e9c6d commit 593978b

File tree

4 files changed

+17
-7
lines changed

4 files changed

+17
-7
lines changed

static/app/views/performance/cache/cacheLandingPage.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ import {useMetrics, useSpanMetrics} from 'sentry/views/starfish/queries/useDisco
3737
import {useSpanMetricsSeries} from 'sentry/views/starfish/queries/useDiscoverSeries';
3838
import {SpanFunction, SpanMetricsField} from 'sentry/views/starfish/types';
3939
import {QueryParameterNames} from 'sentry/views/starfish/views/queryParameters';
40+
import {DataTitles} from 'sentry/views/starfish/views/spans/types';
4041

4142
const {CACHE_MISS_RATE} = SpanFunction;
4243
const {CACHE_ITEM_SIZE} = SpanMetricsField;
@@ -168,7 +169,10 @@ export function CacheLandingPage() {
168169
</ModuleLayout.Full>
169170
<ModuleLayout.Half>
170171
<CacheHitMissChart
171-
series={cacheHitRateData[`${CACHE_MISS_RATE}()`]}
172+
series={{
173+
seriesName: DataTitles.cacheMissRate,
174+
data: cacheHitRateData[`${CACHE_MISS_RATE}()`]?.data,
175+
}}
172176
isLoading={isCacheHitRateLoading}
173177
error={cacheHitRateError}
174178
/>

static/app/views/performance/cache/charts/hitMissChart.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ export function CacheHitMissChart({series, isLoading, error}: Props) {
1616
return (
1717
<ChartPanel title={DataTitles.cacheMissRate}>
1818
<Chart
19-
showLegend
2019
height={CHART_HEIGHT}
2120
grid={{
2221
left: '4px',

static/app/views/performance/cache/samplePanel/charts/transactionDurationChart.tsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import {t} from 'sentry/locale';
12
import type {EChartHighlightHandler} from 'sentry/types/echarts';
23
import {decodeScalar} from 'sentry/utils/queryString';
34
import {MutableSearch} from 'sentry/utils/tokenizeSearch';
@@ -73,7 +74,7 @@ export function TransactionDurationChart({
7374
};
7475

7576
return (
76-
<ChartPanel title={DataTitles.transactionDuration}>
77+
<ChartPanel title={DataTitles['transaction.duration']}>
7778
<Chart
7879
height={CHART_HEIGHT}
7980
grid={{
@@ -83,7 +84,13 @@ export function TransactionDurationChart({
8384
bottom: '0',
8485
}}
8586
scatterPlot={sampledSpanDataSeries}
86-
data={[data['avg(transaction.duration)']]}
87+
data={[
88+
{
89+
seriesName: t('Average Transaction Duration'),
90+
data: data['avg(transaction.duration)'].data,
91+
},
92+
]}
93+
aggregateOutputFormat="duration"
8794
loading={isLoading}
8895
onHighlight={handleChartHighlight}
8996
chartColors={[AVG_COLOR]}

static/app/views/starfish/views/spans/types.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export type DataKey =
2525
| 'httpCodeBreakdown'
2626
| 'cacheMissRate'
2727
| 'avg(cache.item_size)'
28-
| 'transactionDuration';
28+
| 'transaction.duration';
2929

3030
export const DataTitles: Record<DataKey, string> = {
3131
change: t('Change'),
@@ -45,12 +45,12 @@ export const DataTitles: Record<DataKey, string> = {
4545
'avg(http.response_content_length)': t('Avg Encoded Size'),
4646
'avg(http.decoded_response_content_length)': t('Avg Decoded Size'),
4747
'avg(http.response_transfer_size)': t('Avg Transfer Size'),
48-
'avg(transaction.duration)': t('Avg Txn Duration'),
48+
'avg(transaction.duration)': t('Avg Transaction Duration'),
4949
'avg(cache.item_size)': t('Avg Value Size'),
5050
unsuccessfulHTTPCodes: t('Response Codes (3XX, 4XX, 5XX)'),
5151
httpCodeBreakdown: t('Response Code Breakdown'),
5252
cacheMissRate: t('Miss Rate'),
53-
transactionDuration: t('Transaction Duration'),
53+
'transaction.duration': t('Transaction Duration'),
5454
};
5555

5656
export const getThroughputTitle = (

0 commit comments

Comments
 (0)