Fully enable reprocessing-v2 (backend) (#69204)

This fully enables the feature by simply removing all the checks and
early returns for the feature flag.

---

Split out from #68412

Author: Swatinem

src/sentry/api/endpoints/event_reprocessable.py

@@ -2,7 +2,6 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import features
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
@@ -56,14 +55,6 @@ def get(self, request: Request, project, event_id) -> Response:
         :auth: required
         """
 
-        if not features.has(
-            "organizations:reprocessing-v2", project.organization, actor=request.user
-        ):
-            return self.respond(
-                {"error": "This project does not have the reprocessing v2 feature"},
-                status=404,
-            )
-
         try:
             pull_event_data(project.id, event_id)
         except CannotReprocess as e:

src/sentry/api/endpoints/group_reprocessing.py

@@ -1,7 +1,6 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import features
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
 from sentry.api.bases import GroupEndpoint
@@ -27,14 +26,6 @@ def post(self, request: Request, group) -> Response:
         :auth: required
         """
 
-        if not features.has(
-            "organizations:reprocessing-v2", group.project.organization, actor=request.user
-        ):
-            return self.respond(
-                {"error": "This project does not have the reprocessing v2 feature"},
-                status=404,
-            )
-
         max_events = request.data.get("maxEvents")
         if max_events:
             max_events = int(max_events)

tests/sentry/api/endpoints/test_event_reprocessable.py

@@ -17,8 +17,7 @@ def test_simple(self):
         )
 
         path = f"/api/0/projects/{event1.project.organization.slug}/{event1.project.slug}/events/{event1.event_id}/reprocessable/"
-        with self.feature("organizations:reprocessing-v2"):
-            response = self.client.get(path, format="json")
-            assert response.status_code == 200
-            assert not response.data["reprocessable"]
-            assert response.data["reason"] == "unprocessed_event.not_found"
+        response = self.client.get(path, format="json")
+        assert response.status_code == 200
+        assert not response.data["reprocessable"]
+        assert response.data["reason"] == "unprocessed_event.not_found"

tests/sentry/tasks/test_reprocessing2.py

@@ -26,7 +26,6 @@
 from sentry.tasks.reprocessing2 import finish_reprocessing, reprocess_group
 from sentry.tasks.store import preprocess_event
 from sentry.testutils.cases import TestCase
-from sentry.testutils.helpers import Feature
 from sentry.testutils.helpers.datetime import before_now, iso_format
 from sentry.testutils.pytest.fixtures import django_db_all
 from sentry.testutils.skips import requires_snuba
@@ -62,8 +61,7 @@ def _create_user_report(evt):
 def reprocessing_feature(settings):
     settings.SENTRY_REPROCESSING_PAGE_SIZE = 1
 
-    with Feature({"organizations:reprocessing-v2": True}):
-        yield
+    yield
 
 
 @pytest.fixture

tests/symbolicator/test_minidump_full.py

@@ -36,8 +36,9 @@ class SymbolicatorMinidumpIntegrationTest(RelayStoreHelper, TransactionTestCase)
     def initialize(self, live_server, reset_snuba):
         self.project.update_option("sentry:builtin_symbol_sources", [])
 
-        with patch("sentry.auth.system.is_internal_ip", return_value=True), self.options(
-            {"system.url-prefix": live_server.url}
+        with (
+            patch("sentry.auth.system.is_internal_ip", return_value=True),
+            self.options({"system.url-prefix": live_server.url}),
         ):
             # Run test case
             yield
@@ -162,9 +163,7 @@ def test_reprocessing(self):
 
         self.project.update_option("sentry:store_crash_reports", STORE_CRASH_REPORTS_ALL)
 
-        features = dict(self._FEATURES)
-        features["organizations:reprocessing-v2"] = True
-        with self.feature(features):
+        with self.feature(self._FEATURES):
             with open(get_fixture_path("native", "windows.dmp"), "rb") as f:
                 event = self.post_and_retrieve_minidump(
                     {"upload_file_minidump": f}, {"sentry[logger]": "test-logger"}