s/_save_aggregate/_save_aggregate_legacy

Author: lobsterkatie

src/sentry/event_manager.py

@@ -911,7 +911,7 @@ def _materialize_metadata_many(jobs: Sequence[Job]) -> None:
         job["culprit"] = data["culprit"]
 
 
-# TODO: This is only called in `_save_aggregate`, so when that goes, so can this (it's been
+# TODO: This is only called in `_save_aggregate_legacy`, so when that goes, so can this (it's been
 # supplanted by `_get_group_processing_kwargs` below)
 def _get_group_creation_kwargs(job: Job | PerformanceJob) -> dict[str, Any]:
     kwargs = {
@@ -1381,7 +1381,7 @@ def assign_event_to_group(event: Event, job: Job, metric_tags: MutableTags) -> G
             metric_tags=metric_tags,
         )
     else:
-        group_info = _save_aggregate(
+        group_info = _save_aggregate_legacy(
             event=event,
             job=job,
             release=job["release"],
@@ -1396,7 +1396,7 @@ def assign_event_to_group(event: Event, job: Job, metric_tags: MutableTags) -> G
     return group_info
 
 
-def _save_aggregate(
+def _save_aggregate_legacy(
     event: Event,
     job: Job,
     release: Release | None,
@@ -1462,7 +1462,7 @@ def _save_aggregate(
     # attributes can be defined in eventtypes.
     #
     # Additionally the `last_received` key is set for group metadata, later in
-    # _save_aggregate
+    # _save_aggregate_legacy
     group_creation_kwargs["data"] = materialize_metadata(
         event.data,
         get_event_type(event.data),

tests/sentry/event_manager/test_hierarchical_hashes.py

@@ -5,7 +5,7 @@
 
 import pytest
 
-from sentry.event_manager import EventManager, _save_aggregate
+from sentry.event_manager import EventManager, _save_aggregate_legacy
 from sentry.eventstore.models import Event
 from sentry.grouping.result import CalculatedHashes
 from sentry.models.group import Group
@@ -78,7 +78,7 @@ def inner(last_frame):
                     return_value=group_creation_kwargs,
                 ):
                     with patch("sentry.event_manager._materialize_metadata_many"):
-                        return _save_aggregate(
+                        return _save_aggregate_legacy(
                             evt,
                             job={"event_metadata": {}},
                             release=None,

tests/sentry/event_manager/test_save_aggregate.py

@@ -7,7 +7,7 @@
 import pytest
 from django.db import router, transaction
 
-from sentry.event_manager import GroupInfo, _save_aggregate, _save_aggregate_new
+from sentry.event_manager import GroupInfo, _save_aggregate_legacy, _save_aggregate_new
 from sentry.eventstore.models import Event
 from sentry.grouping.result import CalculatedHashes
 from sentry.models.grouphash import GroupHash
@@ -74,7 +74,7 @@ def atomic(*args, **kwds):
     )
 
     save_aggregate_fn: Callable[..., GroupInfo] = (
-        _save_aggregate_new if use_save_aggregate_new else _save_aggregate
+        _save_aggregate_new if use_save_aggregate_new else _save_aggregate_legacy
     )
     group_kwargs_fn_name = (
         "_get_group_processing_kwargs" if use_save_aggregate_new else "_get_group_creation_kwargs"