feat(typing): add possibly undefined check for issues team code

Author: JoshFerge

pyproject.toml

@@ -66,9 +66,6 @@ warn_unused_ignores = true
 warn_redundant_casts = true
 enable_error_code = ["ignore-without-code"]
 
-enable_error_code = ["possibly-undefined"]
-
-enable_error_code = ["possibly-undefined"]
 
 [tool.django-stubs]
 django_settings_module = "sentry.conf.server_mypy"
@@ -655,3 +652,16 @@ module = [
 disallow_any_generics = true
 disallow_untyped_defs = true
 # end: stronger typing
+
+# begin: possibly-undefined checks for issue team critical code
+[[tool.mypy.overrides]]
+module = [
+  "sentry.issues.*",
+  "sentry.tasks.post_process",
+  "sentry.event_manager",
+  "sentry.grouping.*",
+  "sentry.tasks.store",
+  "sentry.ingest.consumer.processors"
+]
+enable_error_code = ["possibly-undefined"]
+# end: possibly-undefined

src/sentry/issues/grouptype.py

@@ -49,6 +49,7 @@ def add(self, group_type: type[GroupType]) -> None:
             raise ValueError(
                 f"A group type with the type_id {group_type.type_id} has already been registered."
             )
+
         self._registry[group_type.type_id] = group_type
         self._slug_lookup[group_type.slug] = group_type
         self._category_lookup[group_type.category].add(group_type.type_id)

src/sentry/issues/ingest.py

@@ -137,7 +137,6 @@ def materialize_metadata(occurrence: IssueOccurrence, event: Event) -> Occurrenc
     event_metadata["title"] = occurrence.issue_title
     event_metadata["value"] = occurrence.subtitle
     event_metadata["initial_priority"] = occurrence.initial_issue_priority
-
     if occurrence.type == FeedbackGroup:
         # TODO: Should feedbacks be their own event type, so above call to event.get_event_medata
         # could populate this instead?
@@ -199,14 +198,14 @@ def save_issue_from_occurrence(
             metrics.incr("issues.issue.dropped.rate_limiting")
             return None
 
-        with sentry_sdk.start_span(
-            op="issues.save_issue_from_occurrence.transaction"
-        ) as span, metrics.timer(
-            "issues.save_issue_from_occurrence.transaction",
-            tags={"platform": event.platform or "unknown", "type": occurrence.type.type_id},
-            sample_rate=1.0,
-        ) as metric_tags, transaction.atomic(
-            router.db_for_write(GroupHash)
+        with (
+            sentry_sdk.start_span(op="issues.save_issue_from_occurrence.transaction") as span,
+            metrics.timer(
+                "issues.save_issue_from_occurrence.transaction",
+                tags={"platform": event.platform or "unknown", "type": occurrence.type.type_id},
+                sample_rate=1.0,
+            ) as metric_tags,
+            transaction.atomic(router.db_for_write(GroupHash)),
         ):
             group, is_new = _save_grouphash_and_group(
                 project, event, new_grouphash, **cast(Mapping[str, Any], issue_kwargs)

src/sentry/tasks/post_process.py

@@ -1068,6 +1068,7 @@ def _get_replay_id(event):
         kafka_payload = transform_event_for_linking_payload(replay_id, group_event)
     except ValueError:
         metrics.incr("post_process.process_replay_link.id_invalid")
+        return
 
     publisher.publish(
         "ingest-replay-events",