make failure rate generic to span status

Author: DominikB2014

src/sentry/search/eap/spans/formulas.py

@@ -172,7 +172,7 @@ def failure_rate_if(args: ResolvedArguments, settings: ResolverSettings) -> Colu
             conditional_aggregation=AttributeConditionalAggregation(
                 aggregate=Function.FUNCTION_COUNT,
                 key=AttributeKey(
-                    name="sentry.trace.status",
+                    name="sentry.status",
                     type=AttributeKey.TYPE_STRING,
                 ),
                 filter=TraceItemFilter(
@@ -181,7 +181,7 @@ def failure_rate_if(args: ResolvedArguments, settings: ResolverSettings) -> Colu
                             TraceItemFilter(
                                 comparison_filter=ComparisonFilter(
                                     key=AttributeKey(
-                                        name="sentry.trace.status",
+                                        name="sentry.status",
                                         type=AttributeKey.TYPE_STRING,
                                     ),
                                     op=ComparisonFilter.OP_NOT_IN,
@@ -219,13 +219,13 @@ def failure_rate(_: ResolvedArguments, settings: ResolverSettings) -> Column.Bin
             conditional_aggregation=AttributeConditionalAggregation(
                 aggregate=Function.FUNCTION_COUNT,
                 key=AttributeKey(
-                    name="sentry.trace.status",
+                    name="sentry.status",
                     type=AttributeKey.TYPE_STRING,
                 ),
                 filter=TraceItemFilter(
                     comparison_filter=ComparisonFilter(
                         key=AttributeKey(
-                            name="sentry.trace.status",
+                            name="sentry.status",
                             type=AttributeKey.TYPE_STRING,
                         ),
                         op=ComparisonFilter.OP_NOT_IN,

tests/snuba/api/endpoints/test_organization_events_span_indexed.py

@@ -2826,7 +2826,7 @@ def test_failure_rate(self):
         self.store_spans(
             [
                 self.create_span(
-                    {"sentry_tags": {"trace.status": status}},
+                    {"sentry_tags": {"status": status}},
                     start_ts=self.ten_mins_ago,
                 )
                 for status in trace_statuses
@@ -2855,7 +2855,7 @@ def test_failure_rate_if(self):
         spans = [
             self.create_span(
                 {
-                    "sentry_tags": {"trace.status": status},
+                    "sentry_tags": {"status": status},
                     "is_segment": True,
                 },
                 start_ts=self.ten_mins_ago,
@@ -2866,7 +2866,7 @@ def test_failure_rate_if(self):
         spans.append(
             self.create_span(
                 {
-                    "sentry_tags": {"trace.status": "ok"},
+                    "sentry_tags": {"status": "ok"},
                     "is_segment": False,
                 },
                 start_ts=self.ten_mins_ago,