Revert "chore(performance-issues): Create experimental N+1 API Call detector (#90070)"

This reverts commit 1349128.

Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>

Author: getsentry-bot

src/sentry/issues/grouptype.py

@@ -382,16 +382,6 @@ class PerformanceNPlusOneAPICallsGroupType(GroupType):
     released = True
 
 
-@dataclass(frozen=True)
-class PerformanceNPlusOneAPICallsExperimentalGroupType(GroupType):
-    type_id = 1910
-    slug = "performance_n_plus_one_api_calls_experimental"
-    description = "N+1 API Call (Experimental)"
-    category = GroupCategory.PERFORMANCE.value
-    default_priority = PriorityLevel.LOW
-    released = False
-
-
 @dataclass(frozen=True)
 class PerformanceMNPlusOneDBQueriesGroupType(PerformanceGroupTypeDefaults, GroupType):
     type_id = 1011

src/sentry/notifications/utils/__init__.py

@@ -21,7 +21,6 @@
 from sentry.integrations.services.integration import integration_service
 from sentry.issues.grouptype import (
     PerformanceConsecutiveDBQueriesGroupType,
-    PerformanceNPlusOneAPICallsExperimentalGroupType,
     PerformanceNPlusOneAPICallsGroupType,
     PerformanceRenderBlockingAssetSpanGroupType,
 )
@@ -337,7 +336,7 @@ def occurrence_perf_to_email_html(context: Any) -> str:
 
 
 def get_spans(
-    entries: list[dict[str, list[dict[str, str | float]] | str]],
+    entries: list[dict[str, list[dict[str, str | float]] | str]]
 ) -> list[dict[str, str | float]] | None:
     """Get the given event's spans"""
     if not len(entries):
@@ -497,10 +496,7 @@ def from_problem_and_spans(
         spans: list[dict[str, str | float]] | None,
         event: Event | None = None,
     ) -> PerformanceProblemContext:
-        if problem.type in (
-            PerformanceNPlusOneAPICallsGroupType,
-            PerformanceNPlusOneAPICallsExperimentalGroupType,
-        ):
+        if problem.type == PerformanceNPlusOneAPICallsGroupType:
             return NPlusOneAPICallProblemContext(problem, spans, event)
         if problem.type == PerformanceConsecutiveDBQueriesGroupType:
             return ConsecutiveDBQueriesProblemContext(problem, spans, event)

src/sentry/utils/performance_issues/detectors/__init__.py

@@ -0,0 +1,14 @@
+from .consecutive_db_detector import ConsecutiveDBSpanDetector  # NOQA
+from .consecutive_http_detector import ConsecutiveHTTPSpanDetector  # NOQA
+from .http_overhead_detector import HTTPOverheadDetector  # NOQA
+from .io_main_thread_detector import DBMainThreadDetector, FileIOMainThreadDetector  # NOQA
+from .large_payload_detector import LargeHTTPPayloadDetector  # NOQA
+from .mn_plus_one_db_span_detector import MNPlusOneDBSpanDetector  # NOQA
+from .n_plus_one_api_calls_detector import NPlusOneAPICallsDetector  # NOQA
+from .n_plus_one_db_span_detector import (  # NOQA
+    NPlusOneDBSpanDetector,
+    NPlusOneDBSpanDetectorExtended,
+)
+from .render_blocking_asset_span_detector import RenderBlockingAssetSpanDetector  # NOQA
+from .slow_db_query_detector import SlowDBQueryDetector  # NOQA
+from .uncompressed_asset_detector import UncompressedAssetSpanDetector  # NOQA

src/sentry/utils/performance_issues/detectors/experiments/__init__.py

@@ -14,7 +14,9 @@
 from sentry.issues.issue_occurrence import IssueEvidence
 from sentry.models.organization import Organization
 from sentry.models.project import Project
-from sentry.utils.performance_issues.base import (
+from sentry.utils.performance_issues.detectors.utils import get_total_span_duration
+
+from ..base import (
     DetectorType,
     PerformanceDetector,
     fingerprint_http_spans,
@@ -23,9 +25,8 @@
     get_url_from_span,
     parameterize_url,
 )
-from sentry.utils.performance_issues.detectors.utils import get_total_span_duration
-from sentry.utils.performance_issues.performance_problem import PerformanceProblem
-from sentry.utils.performance_issues.types import PerformanceProblemsMap, Span
+from ..performance_problem import PerformanceProblem
+from ..types import PerformanceProblemsMap, Span
 
 
 class NPlusOneAPICallsDetector(PerformanceDetector):