chore(github): Only support pagination for getting labels (#91570)

A follow-up to #91271.

Author: armenzg

src/sentry/features/temporary.py

@@ -500,8 +500,6 @@ def register_temporary_features(manager: FeatureManager):
     manager.add("organizations:jira-per-project-statuses", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable using paginated projects endpoint for Jira integration
     manager.add("organizations:jira-paginated-projects", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
-    # Enable using paginated labels for GitHub integration
-    manager.add("organizations:github-paginated-labels", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable single trace summary
     manager.add("organizations:single-trace-summary", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable Relay extracting logs from breadcrumbs for a project.

src/sentry/integrations/github/client.py

@@ -498,15 +498,12 @@ def get_user(self, gh_username: str) -> Any:
         """
         return self.get(f"/users/{gh_username}")
 
-    def get_labels(self, owner: str, repo: str, paginated: bool = False) -> list[Any]:
+    def get_labels(self, owner: str, repo: str) -> list[Any]:
         """
         Fetches all labels for a repository.
         https://docs.github.com/en/rest/issues/labels#list-labels-for-a-repository
         """
-        if paginated:
-            return self.get_with_pagination(f"/repos/{owner}/{repo}/labels")
-        else:
-            return self.get(f"/repos/{owner}/{repo}/labels")
+        return self.get_with_pagination(f"/repos/{owner}/{repo}/labels")
 
     def check_file(self, repo: Repository, path: str, version: str | None) -> object | None:
         return self.head_cached(path=f"/repos/{repo.name}/contents/{path}", params={"ref": version})

src/sentry/integrations/github/issues.py

@@ -7,7 +7,6 @@
 
 from django.urls import reverse
 
-from sentry import features
 from sentry.eventstore.models import Event, GroupEvent
 from sentry.integrations.mixins.issues import MAX_CHAR
 from sentry.integrations.models.external_issue import ExternalIssue
@@ -139,8 +138,7 @@ def get_create_issue_config(
         labels: Sequence[tuple[str, str]] = []
         if default_repo:
             owner, repo = default_repo.split("/")
-            paginated = features.has("organizations:github-paginated-labels", org, actor=user)
-            labels = self.get_repo_labels(owner, repo, paginated)
+            labels = self.get_repo_labels(owner, repo)
 
         autocomplete_url = reverse(
             "sentry-integration-github-search", args=[org.slug, self.model.id]
@@ -297,12 +295,10 @@ def get_allowed_assignees(self, repo: str) -> Sequence[tuple[str, str]]:
 
         return (("", "Unassigned"),) + users
 
-    def get_repo_labels(
-        self, owner: str, repo: str, paginated: bool = False
-    ) -> Sequence[tuple[str, str]]:
+    def get_repo_labels(self, owner: str, repo: str) -> Sequence[tuple[str, str]]:
         client = self.get_client()
         try:
-            response = client.get_labels(owner, repo, paginated)
+            response = client.get_labels(owner, repo)
         except Exception as e:
             self.raise_error(e)
 

tests/sentry/integrations/github/test_issues.py

@@ -169,49 +169,6 @@ def test_get_allowed_assignees(self):
 
     @responses.activate
     def test_get_repo_labels(self):
-        responses.add(
-            responses.POST,
-            "https://api.github.com/app/installations/github_external_id/access_tokens",
-            json={"token": "token_1", "expires_at": "2018-10-11T22:14:10Z"},
-        )
-        responses.add(
-            responses.GET,
-            "https://api.github.com/repos/getsentry/sentry/labels",
-            json=[
-                {"name": "bug"},
-                {"name": "Big Bug"},
-                {"name": "enhancement"},
-                {"name": "duplicate"},
-                {"name": "1"},
-                {"name": "10"},
-                {"name": "2"},
-            ],
-        )
-
-        # results should be sorted alphabetically
-        assert self.install.get_repo_labels("getsentry", "sentry") == (
-            ("1", "1"),
-            ("2", "2"),
-            ("10", "10"),
-            ("Big Bug", "Big Bug"),
-            ("bug", "bug"),
-            ("duplicate", "duplicate"),
-            ("enhancement", "enhancement"),
-        )
-
-        if self.should_call_api_without_proxying():
-            assert len(responses.calls) == 2
-
-            request = responses.calls[0].request
-            assert request.headers["Authorization"] == "Bearer jwt_token_1"
-
-            request = responses.calls[1].request
-            assert request.headers["Authorization"] == "Bearer token_1"
-        else:
-            self._check_proxying()
-
-    @responses.activate
-    def test_get_repo_labels_with_pagination(self):
         """Test that labels are fetched using pagination when the feature flag is enabled."""
         responses.add(
             responses.POST,
@@ -236,7 +193,7 @@ def test_get_repo_labels_with_pagination(self):
             "sentry.integrations.github.client.GitHubBaseClient.page_size", new=len(labels) - 1
         ):
             # results should be sorted alphabetically
-            assert self.install.get_repo_labels("getsentry", "sentry", paginated=True) == (
+            assert self.install.get_repo_labels("getsentry", "sentry") == (
                 ("1", "1"),
                 ("2", "2"),
                 ("10", "10"),