feat(uptime): Write date_in_progress to CheckIn table

Author: evanpurkhiser

migrations_lockfile.txt

@@ -13,7 +13,7 @@ hybridcloud: 0021_django_arrayfield_scope_list
 
 insights: 0001_add_starred_transactions_model
 
-monitors: 0004_record_date_in_progress_sql_only
+monitors: 0005_record_date_in_progress_state
 
 nodestore: 0002_nodestore_no_dictfield
 

src/sentry/monitors/consumers/monitor_consumer.py

@@ -828,13 +828,17 @@ def _process_checkin(item: CheckinItem, txn: Transaction | Span) -> None:
                 # to UTC
                 clock_time = item.ts.replace(tzinfo=UTC)
 
+                # Record the reported in_progress time when the check is in progress
+                date_in_progress = start_time if status == CheckInStatus.IN_PROGRESS else None
+
                 check_in, created = MonitorCheckIn.objects.get_or_create(
                     defaults={
                         "duration": duration,
                         "status": status,
                         "date_added": start_time,
                         "date_updated": start_time,
                         "date_clock": clock_time,
+                        "date_in_progress": date_in_progress,
                         "expected_time": expected_time,
                         "timeout_at": timeout_at,
                         "monitor_config": monitor_config,

src/sentry/monitors/migrations/0005_record_date_in_progress_state.py

@@ -0,0 +1,39 @@
+# Generated by Django 5.2.1 on 2025-05-15 16:51
+
+from django.db import migrations, models
+
+from django.db.migrations import SeparateDatabaseAndState
+from sentry.new_migrations.migrations import CheckedMigration
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production.
+    # This should only be used for operations where it's safe to run the migration after your
+    # code has deployed. So this should not be used for most operations that alter the schema
+    # of a table.
+    # Here are some things that make sense to mark as post deployment:
+    # - Large data migrations. Typically we want these to be run manually so that they can be
+    #   monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   run this outside deployments so that we don't block them. Note that while adding an index
+    #   is a schema change, it's completely safe to run the operation after the code has deployed.
+    # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
+
+    is_post_deployment = False
+
+    dependencies = [
+        ("monitors", "0004_record_date_in_progress_sql_only"),
+    ]
+
+    operations = [
+        SeparateDatabaseAndState(
+            database_operations=[],
+            state_operations=[
+                migrations.AddField(
+                    model_name="monitorcheckin",
+                    name="date_in_progress",
+                    field=models.DateTimeField(null=True),
+                )
+            ],
+        )
+    ]

src/sentry/monitors/models.py

@@ -495,6 +495,12 @@ class MonitorCheckIn(Model):
     as detecting misses)
     """
 
+    date_in_progress = models.DateTimeField(null=True)
+    """
+    Records the time when the first in_progress check-in was received by relay.
+    If no in_progress check-in was ever sent this will remain null.
+    """
+
     expected_time = models.DateTimeField(null=True)
     """
     Holds the exact time we expected to receive this check-in

src/sentry/monitors/serializers.py

@@ -278,6 +278,7 @@ class MonitorCheckInSerializerResponse(MonitorCheckInSerializerResponseOptional)
     dateCreated: datetime
     dateAdded: datetime
     dateUpdated: datetime
+    dateInProgress: datetime
     dateClock: datetime
     expectedTime: datetime
     monitorConfig: MonitorConfigSerializerResponse
@@ -348,6 +349,7 @@ def serialize(self, obj, attrs, user, **kwargs) -> MonitorCheckInSerializerRespo
             "dateAdded": obj.date_added,
             "dateUpdated": obj.date_updated,
             "dateClock": obj.date_clock,
+            "dateInProgress": obj.date_in_progress,
             "expectedTime": obj.expected_time,
             "monitorConfig": cast(MonitorConfigSerializerResponse, config),
         }

tests/sentry/monitors/consumers/test_monitor_consumer.py

@@ -359,6 +359,38 @@ def test_check_in_date_clock(self):
         assert checkin.date_added == ts.replace(tzinfo=UTC)
         assert checkin.date_clock == item_ts.replace(tzinfo=UTC)
 
+    def test_check_in_date_in_progress(self):
+        monitor = self._create_monitor(slug="my-monitor")
+        now = datetime.now()
+        now_tz = now.replace(tzinfo=UTC)
+
+        guid1 = uuid.uuid4().hex
+
+        # First check-in will not have a date_in_progress, since we never sent
+        # an in-progress check.
+        self.send_checkin(monitor.slug, guid=guid1, ts=now, status="ok")
+        checkin1 = MonitorCheckIn.objects.get(guid=guid1)
+        assert not checkin1.date_in_progress
+
+        # Second check-in does have a date_in_progress
+        guid2 = uuid.uuid4().hex
+
+        self.send_checkin(
+            monitor.slug,
+            guid=guid2,
+            ts=now + timedelta(minutes=1),
+            status="in_progress",
+        )
+        self.send_checkin(
+            monitor.slug,
+            guid=guid2,
+            ts=now + timedelta(minutes=1, seconds=25),
+            status="ok",
+        )
+
+        checkin2 = MonitorCheckIn.objects.get(guid=guid2)
+        assert checkin2.date_in_progress == now_tz + timedelta(minutes=1)
+
     def test_check_in_timeout_at(self):
         monitor = self._create_monitor(slug="my-monitor")
         self.send_checkin(monitor.slug, status="in_progress")