ref(views): Delete editableTabTitle component and tests (#91750)

Renames any issue views components that included "Nav" in the signature.
This was done to differentiate the old tabs component for issue views
from the new navigation component for issue views. Now that the tabs are
removed and the navigation is the only surface area for issue views, we
can remove this distinction. Full list of changes:

* `<IssueViewNavItems/>` => `<IssueViews>`
* `type NavIssueView` => `type IssueView`
* `<IssueViewNavQueryCount/>`  => `<IssueViewQueryCount/>` 
* `<IssueViewNavItemContent/>` => `<IssueViewItem/>`
* Delete `<IssueViewNavEditableTitle/>` (I missed this in a PR to delete
old issue views components)

Author: MichaelSun48

static/app/views/nav/secondary/sections/issues/issueViews/issueViewNavItemContent.tsx renamed to static/app/views/nav/secondary/sections/issues/issueViews/issueViewItem.tsx

@@ -16,13 +16,13 @@ import {useIssueViewUnsavedChanges} from 'sentry/views/issueList/issueViews/useI
 import {useNavContext} from 'sentry/views/nav/context';
 import ProjectIcon from 'sentry/views/nav/projectIcon';
 import {SecondaryNav} from 'sentry/views/nav/secondary/secondary';
+import {IssueViewQueryCount} from 'sentry/views/nav/secondary/sections/issues/issueViews/issueViewQueryCount';
 import {
   constructViewLink,
-  type NavIssueView,
-} from 'sentry/views/nav/secondary/sections/issues/issueViews/issueViewNavItems';
-import {IssueViewNavQueryCount} from 'sentry/views/nav/secondary/sections/issues/issueViews/issueViewNavQueryCount';
+  type IssueView,
+} from 'sentry/views/nav/secondary/sections/issues/issueViews/issueViews';
 
-interface IssueViewNavItemContentProps {
+interface IssueViewItemProps {
   /**
    * Whether the item is active.
    */
@@ -47,7 +47,7 @@ interface IssueViewNavItemContentProps {
   /**
    * The issue view to display
    */
-  view: NavIssueView;
+  view: IssueView;
   /**
    * Ref to the body of the section that contains the reorderable items.
    * This is used as the portal container for the ellipsis menu, and as
@@ -56,14 +56,14 @@ interface IssueViewNavItemContentProps {
   sectionRef?: React.RefObject<HTMLDivElement | null>;
 }
 
-export function IssueViewNavItemContent({
+export function IssueViewItem({
   view,
   sectionRef,
   isActive,
   onReorderComplete,
   isDragging,
   setIsDragging,
-}: IssueViewNavItemContentProps) {
+}: IssueViewItemProps) {
   const organization = useOrganization();
   const {projects} = useProjects();
 
@@ -135,7 +135,7 @@ export function IssueViewNavItemContent({
         }
         trailingItems={
           <TrailingItemsWrapper>
-            <IssueViewNavQueryCount view={view} isActive={isActive} />
+            <IssueViewQueryCount view={view} isActive={isActive} />
           </TrailingItemsWrapper>
         }
         onPointerDown={e => {

static/app/views/nav/secondary/sections/issues/issueViews/issueViewNavEditableTitle.spec.tsx

@@ -3,9 +3,9 @@ import {GroupSearchViewFixture} from 'sentry-fixture/groupSearchView';
 import {render, screen} from 'sentry-test/reactTestingLibrary';
 
 import {IssueSortOptions} from 'sentry/views/issueList/utils';
-import {IssueViewNavQueryCount} from 'sentry/views/nav/secondary/sections/issues/issueViews/issueViewNavQueryCount';
+import {IssueViewQueryCount} from 'sentry/views/nav/secondary/sections/issues/issueViews/issueViewQueryCount';
 
-describe('IssueViewNavQueryCount', () => {
+describe('IssueViewQueryCount', () => {
   const mockView = {
     ...GroupSearchViewFixture({
       id: '1',
@@ -38,7 +38,7 @@ describe('IssueViewNavQueryCount', () => {
       },
     });
 
-    render(<IssueViewNavQueryCount view={mockView} isActive />);
+    render(<IssueViewQueryCount view={mockView} isActive />);
 
     expect(await screen.findByText('71')).toBeInTheDocument();
   });
@@ -52,7 +52,7 @@ describe('IssueViewNavQueryCount', () => {
       },
     });
 
-    render(<IssueViewNavQueryCount view={mockView} isActive />);
+    render(<IssueViewQueryCount view={mockView} isActive />);
 
     expect(await screen.findByText('99+')).toBeInTheDocument();
   });

static/app/views/nav/secondary/sections/issues/issueViews/issueViewNavEditableTitle.tsx

@@ -9,7 +9,7 @@ import {useLocation} from 'sentry/utils/useLocation';
 import useOrganization from 'sentry/utils/useOrganization';
 import {createIssueViewFromUrl} from 'sentry/views/issueList/issueViews/createIssueViewFromUrl';
 import {useFetchIssueCounts} from 'sentry/views/issueList/queries/useFetchIssueCounts';
-import type {NavIssueView} from 'sentry/views/nav/secondary/sections/issues/issueViews/issueViewNavItems';
+import type {IssueView} from 'sentry/views/nav/secondary/sections/issues/issueViews/issueViews';
 
 const TAB_MAX_COUNT = 99;
 
@@ -30,12 +30,12 @@ const constructCountTimeFrame = (
   };
 };
 
-interface IssueViewNavQueryCountProps {
+interface IssueViewQueryCountProps {
   isActive: boolean;
-  view: NavIssueView;
+  view: IssueView;
 }
 
-export function IssueViewNavQueryCount({view, isActive}: IssueViewNavQueryCountProps) {
+export function IssueViewQueryCount({view, isActive}: IssueViewQueryCountProps) {
   const organization = useOrganization();
   const theme = useTheme();
   const location = useLocation();