Skip to content

Commit 6fa8854

Browse files
authored
fix(ourlogs): Remove page filter container (#92334)
### Summary This is affecting other parts of the issues detail page; the page already has a container [here](https://github.com/getsentry/sentry/blob/master/static/app/views/issueDetails/groupDetails.tsx#L899-L903)
1 parent 9559d5f commit 6fa8854

File tree

1 file changed

+21
-26
lines changed

1 file changed

+21
-26
lines changed

static/app/components/events/ourlogs/ourlogsSection.tsx

Lines changed: 21 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import styled from '@emotion/styled';
44
import {Button} from 'sentry/components/core/button';
55
import {OurlogsDrawer} from 'sentry/components/events/ourlogs/ourlogsDrawer';
66
import useDrawer from 'sentry/components/globalDrawer';
7-
import PageFiltersContainer from 'sentry/components/organizations/pageFilters/container';
87
import {IconChevron} from 'sentry/icons';
98
import {t} from 'sentry/locale';
109
import type {Event} from 'sentry/types/event';
@@ -38,18 +37,16 @@ export function OurlogsSection({
3837
project: Project;
3938
}) {
4039
return (
41-
<PageFiltersContainer>
42-
<LogsPageParamsProvider
43-
analyticsPageSource={LogsAnalyticsPageSource.ISSUE_DETAILS}
44-
isTableFrozen
45-
blockRowExpanding
46-
limitToTraceId={event.contexts?.trace?.trace_id}
47-
>
48-
<LogsPageDataProvider>
49-
<OurlogsSectionContent event={event} group={group} project={project} />
50-
</LogsPageDataProvider>
51-
</LogsPageParamsProvider>
52-
</PageFiltersContainer>
40+
<LogsPageParamsProvider
41+
analyticsPageSource={LogsAnalyticsPageSource.ISSUE_DETAILS}
42+
isTableFrozen
43+
blockRowExpanding
44+
limitToTraceId={event.contexts?.trace?.trace_id}
45+
>
46+
<LogsPageDataProvider>
47+
<OurlogsSectionContent event={event} group={group} project={project} />
48+
</LogsPageDataProvider>
49+
</LogsPageParamsProvider>
5350
);
5451
}
5552

@@ -78,19 +75,17 @@ function OurlogsSectionContent({
7875
});
7976
openDrawer(
8077
() => (
81-
<PageFiltersContainer>
82-
<LogsPageParamsProvider
83-
analyticsPageSource={LogsAnalyticsPageSource.ISSUE_DETAILS}
84-
isTableFrozen
85-
limitToTraceId={limitToTraceId}
86-
>
87-
<LogsPageDataProvider>
88-
<TraceItemAttributeProvider traceItemType={TraceItemDataset.LOGS} enabled>
89-
<OurlogsDrawer group={group} event={event} project={project} />
90-
</TraceItemAttributeProvider>
91-
</LogsPageDataProvider>
92-
</LogsPageParamsProvider>
93-
</PageFiltersContainer>
78+
<LogsPageParamsProvider
79+
analyticsPageSource={LogsAnalyticsPageSource.ISSUE_DETAILS}
80+
isTableFrozen
81+
limitToTraceId={limitToTraceId}
82+
>
83+
<LogsPageDataProvider>
84+
<TraceItemAttributeProvider traceItemType={TraceItemDataset.LOGS} enabled>
85+
<OurlogsDrawer group={group} event={event} project={project} />
86+
</TraceItemAttributeProvider>
87+
</LogsPageDataProvider>
88+
</LogsPageParamsProvider>
9489
),
9590
{
9691
ariaLabel: 'logs drawer',

0 commit comments

Comments
 (0)