Merge branch 'master' into corsaCompat-2025-05-14

Author: scttcper

.cursor/mcp.json

@@ -0,0 +1,8 @@
+{
+  "mcpServers": {
+    "sentry": {
+      "command": "npx",
+      "args": ["-y", "mcp-remote@latest", "https://mcp.sentry.dev/sse"]
+    }
+  }
+}

.github/CODEOWNERS

@@ -145,6 +145,12 @@ yarn.lock                                                @getsentry/owners-js-de
 # Sentry product. These rules generally map to a signle team, but that may not
 # always be the case.
 
+# Demo Mode - moved upwards because it wraps other parts of the codebase
+# and was assigned many issues to telemetry-experience that should not have been
+/src/sentry/demo_mode/                                   @getsentry/telemetry-experience
+/tests/sentry/demo_mode/                                 @getsentry/telemetry-experience
+/static/app/utils/demoMode/                              @getsentry/telemetry-experience
+
 ## Crons
 /static/app/views/monitors                               @getsentry/crons
 /src/sentry/monitors                                     @getsentry/crons
@@ -368,8 +374,6 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py     @ge
 /src/sentry/toolbar/                         @getsentry/replay-frontend @getsentry/replay-backend
 /tests/sentry/toolbar/                       @getsentry/replay-frontend @getsentry/replay-backend
 /static/app/components/devtoolbar/           @getsentry/replay-frontend
-/src/sentry/middleware/devtoolbar.py         @getsentry/replay-backend
-/tests/sentry/middleware/test_devtoolbar.py  @getsentry/replay-backend
 ## End of DevToolbar
 
 ## Codecov Merge UX
@@ -508,7 +512,6 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py     @ge
 /tests/sentry/sentry_metrics/querying/                                           @getsentry/telemetry-experience
 /src/sentry/snuba/metrics/                                                       @getsentry/telemetry-experience
 /tests/sentry/snuba/metrics/                                                     @getsentry/telemetry-experience
-/src/sentry/demo_mode/
 
 /static/app/actionCreators/metrics.tsx                                           @getsentry/telemetry-experience
 /static/app/data/platformCategories.tsx                                          @getsentry/telemetry-experience
@@ -520,7 +523,8 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py     @ge
 /static/app/views/settings/dynamicSampling/                                      @getsentry/telemetry-experience
 /static/app/views/onboarding*                                                    @getsentry/telemetry-experience
 /static/app/views/projectInstall/                                                @getsentry/telemetry-experience
-/static/app/utils/demoMode/                                                      @getsentry/telemetry-experience
+/static/app/views/insights/agentMonitoring/                                      @getsentry/telemetry-experience
+/static/app/views/insights/pages/platform/                                       @getsentry/telemetry-experience
 ## End of Telemetry Experience
 
 
@@ -682,6 +686,9 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py     @ge
 /src/sentry/migrations/                                  @getsentry/owners-migrations
 /src/sentry/*/migrations/                                @getsentry/owners-migrations
 
+# Preprod build artifact analysis
+/src/sentry/preprod                                   @getsentry/emerge-tool
+# End of preprod
 
 ## Frontend Platform (keep last as we want highest specificity)
 /static/app/utils/theme/                              @getsentry/design-engineering

.github/workflows/acceptance.yml

@@ -84,7 +84,7 @@ jobs:
         uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
         with:
           path: ${{ steps.config.outputs.webpack-path }}
-          key: ${{ runner.os }}-v2-webpack-cache-${{ hashFiles('webpack.config.ts') }}
+          key: ${{ runner.os }}-v2-webpack-cache-${{ hashFiles('rspack.config.ts', 'yarn.lock', 'package.json') }}
 
       - name: node_modules cache
         uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0

.pre-commit-config.yaml

@@ -143,6 +143,14 @@ repos:
             |static/app/utils/profiling/profile/formats/typescript/trace\.json
           )$
 
+      - id: knip
+        name: knip
+        language: system
+        files: \.(ts|js|tsx|jsx|mjs)$
+        pass_filenames: false
+        stages: [pre-push]
+        entry: bash -c 'if [ -n "${SENTRY_KNIP_PRE_PUSH:-}" ]; then exec ./node_modules/.bin/knip; fi' --
+
   - repo: https://github.com/pre-commit/pygrep-hooks
     rev: v1.10.0
     hooks:

CHANGES

@@ -1,3 +1,67 @@
+25.5.1
+------
+
+### Various fixes & improvements
+
+- :wrench: chore(integrations): use `IntegrationProviderSlug` for Integration `key` (#91465) by @iamrajjoshi
+- ref: fix types for group_integration_details (#92026) by @asottile-sentry
+- Bump `devenv`/`devservices` to make Python SDK 3 compatible (#92028) by @antonpirker
+- build(ui): Remove react prod sourcemaps (#92006) by @scttcper
+- feat(spans): Produce items from process-segments (#91714) by @untitaker
+- feat(explore): Add attribute description throughout explore (#91829) by @Zylphrex
+- fix(symbolicator): check source credentials and not the credential token (#92024) by @Litarnus
+- feat(replay): Start bringing in new replay context wrappers to test (#91982) by @ryan953
+- feat(agents-insights): dashboard placeholder (#92021) by @obostjancic
+- ref: remove remote_subscriptions migrations (#92004) by @asottile-sentry
+- fix(apps): disallow Manager to rotate an app secret with org:admin scope (#92019) by @oioki
+- issues: remove custom save button styling (#91974) by @JonasBa
+- replay: replace colors for tokens on timeline (#91933) by @JonasBa
+- trace: fix buttons in chonk (#91878) by @JonasBa
+- tag: fix bad tag change and flickering text (#91927) by @JonasBa
+- chore(sdk): Use add_full_stack by default (#91939) by @armenzg
+- fix(codeowners): move demomode upwards in codewards to stop matching everything (#92020) by @shellmayr
+- fix(nextjs-insight): Filter spans without component type from tree view (#92017) by @ArthurKnaus
+- Add directory for preprod (#91961) by @chromy
+- fix(span-buffer): Fix crashing behavior in flusher (#91949) by @untitaker
+- feat(agents-insights): feature flag registration (#92014) by @obostjancic
+- fix(codeowners): add owner to demomode line (#92012) by @shellmayr
+- ref: add flags to migrations lockfile (#91991) by @asottile-sentry
+- feat(source-maps): Do not render source maps wizard if platform is react native (#91860) by @priscilawebdev
+
+_Plus 231 more_
+
+25.5.0
+------
+
+### Various fixes & improvements
+
+- chore(perf-issues): Add a flag and check it to allow customer to disable detectors (#91734) by @leeandher
+- feat(trace-tabs-ui): Adding ops to search on click and hiding trace level ops breakdown (#91684) by @Abdkhan14
+- build(ui): Add rspack as webpack alternative (#77077) by @scttcper
+- fix(taskworker) Fix async notification parameter serialization (#91720) by @markstory
+- fix(profiles): Set the proper span entity to insert data to in tests (#91736) by @phacops
+- fix(insights): line of code not working with db module on eap (#91654) by @DominikB2014
+- ref(reserved budgets): Update types + constants (#91606) by @isabellaenriquez
+- feat(taskworker) Check 2% of tasks for pickle (#91624) by @markstory
+- chore(github): Only support pagination for getting labels (#91570) by @armenzg
+- Skip test_queries_profile_candidates_from_spans (#91724) by @armenzg
+- fix(issue-details): Avoid persisting stacktrace folding behaviour (#91719) by @leeandher
+- feat(dashboards): Newly added widgets should scroll into view (#91721) by @narsaynorath
+- ref(crons): Use dateAdded over dateCreated (#91667) by @evanpurkhiser
+- fix(utils): return 0% for null and undefined values in formatpercentage (#91710) by @shellmayr
+- ref: fix nullability of requires_org_level_access (#91694) by @asottile-sentry
+- feat(explore): Flatten visualize yaxes into multiple (#91664) by @Zylphrex
+- fix(widget-library): Hide filters at top of panel if not small screen (#91716) by @narsaynorath
+- feat(attachments): Include all attachment with screenshot in name (#91602) by @armenzg
+- fix(insights): show - instead of null when metric value is null (#91656) by @DominikB2014
+- feat(ourlogs): Add a "new" badge for logs in the sidebar (#91674) by @colin-sentry
+- fix(nextjs-insights): remove project icon from rage/dead click widget (#91711) by @shellmayr
+- fix(nextjs-insights): show 0% for failure_rate()==0 instead of <0% (#91709) by @shellmayr
+- feat(nextjs-insights): add avg & p95 duration to navigations table (#91708) by @shellmayr
+- fix(sandbox): for debugging add telex org to exclude from redirect (#91704) by @constantinius
+
+_Plus 1819 more_
+
 25.4.0
 ------
 

Makefile

@@ -100,7 +100,7 @@ test-cli: create-db
 	cd test_cli && sentry init test_conf
 	cd test_cli && sentry --config=test_conf help
 	cd test_cli && sentry --config=test_conf upgrade --traceback --noinput
-	cd test_cli && sentry --config=test_conf export
+	cd test_cli && sentry --config=test_conf export --help
 	rm -r test_cli
 	@echo ""
 

bin/load-integration-data

@@ -0,0 +1,152 @@
+#!/usr/bin/env python
+from sentry.runner import configure
+
+configure()
+
+import argparse
+
+import click
+from django.core import serializers
+from django.db import IntegrityError, router
+
+from sentry.integrations.models.integration import Integration
+from sentry.integrations.models.organization_integration import OrganizationIntegration
+from sentry.users.models.identity import Identity, IdentityProvider
+from sentry.utils.db import atomic_transaction
+
+# The order in which models should be loaded to respect foreign key dependencies.
+MODEL_LOAD_ORDER = [
+    "sentry.identityprovider",
+    "sentry.integration",
+    "sentry.identity",  # Depends on sentry.identityprovider
+    "sentry.organizationintegration",  # Depends on sentry.integration (and sentry.organization)
+]
+
+
+def load_data(input_file, org_id):
+    """
+    Loads data from a JSON file and saves it to the database.
+    Assumes that PKs from the file should be preserved.
+    """
+    click.echo(f"Reading serialized data from {input_file}...")
+    with open(input_file) as f:
+        serialized_data = f.read()
+
+    if not serialized_data.strip() or serialized_data.strip() == "[]":
+        click.echo("Input file is empty or contains no data. Nothing to load.")
+        return
+
+    click.echo("Deserializing objects...")
+    try:
+        deserialized_objects = list(serializers.deserialize("json", serialized_data))
+    except Exception as e:
+        click.echo(f"Error during deserialization: {e}")
+        click.echo(
+            "Please ensure the input file is a valid JSON dump created by the save_integration_data.py script."
+        )
+        return
+
+    if not deserialized_objects:
+        click.echo("No objects were deserialized from the file.")
+        return
+
+    click.echo(f"Deserialized {len(deserialized_objects)} objects.")
+
+    # Sort deserialized objects based on MODEL_LOAD_ORDER to handle dependencies.
+    # Objects not in MODEL_LOAD_ORDER will be placed at the end.
+    def get_sort_key(d_obj):
+        model_key = f"{d_obj.object._meta.app_label}.{d_obj.object._meta.model_name}"
+        try:
+            return MODEL_LOAD_ORDER.index(model_key)
+        except ValueError:
+            return len(MODEL_LOAD_ORDER)  # Put unknown models at the end
+
+    sorted_deserialized_objects = sorted(deserialized_objects, key=get_sort_key)
+
+    saved_count = 0
+    skipped_count = 0
+    error_count = 0
+
+    parsed_org_id = None
+    if org_id:
+        try:
+            parsed_org_id = int(org_id)
+            click.echo(
+                f"Will update OrganizationIntegration objects to organization_id: {parsed_org_id}"
+            )
+        except ValueError:
+            click.echo(
+                f"Warning: Invalid org_id '{org_id}'. It will be ignored. Please provide a valid integer."
+            )
+            parsed_org_id = None
+
+    click.echo("Attempting to save objects to the database...")
+    with atomic_transaction(
+        using=(
+            router.db_for_write(Integration),
+            router.db_for_write(OrganizationIntegration),
+            router.db_for_write(Identity),
+            router.db_for_write(IdentityProvider),
+        )
+    ):
+        for deserialized_object in sorted_deserialized_objects:
+            model_name = deserialized_object.object._meta.object_name
+            pk = deserialized_object.object.pk
+
+            # If org_id is provided, update OrganizationIntegration's organization_id
+            if parsed_org_id is not None and isinstance(
+                deserialized_object.object, OrganizationIntegration
+            ):
+                click.echo(
+                    f"  Updating organization_id for {model_name} (PK: {pk}) to {parsed_org_id}"
+                )
+                deserialized_object.object.organization_id = parsed_org_id
+
+            try:
+                # The deserialized_object.save() method handles saving the object
+                # and its many-to-many data (if any). It attempts to use the PK
+                # from the serialized data.
+                deserialized_object.save()
+                saved_count += 1
+                click.echo(f"  Saved: {model_name} (PK: {pk})")
+            except IntegrityError as e:
+                # This can occur due to PK conflict, unique constraint violation,
+                # or a non-existent foreign key (e.g., if a referenced User or Organization
+                # doesn't exist in the target DB).
+                skipped_count += 1
+                click.echo(f"  Skipped: {model_name} (PK: {pk}) due to IntegrityError: {e}")
+            except Exception as e:
+                # Catch other potential errors during save.
+                error_count += 1
+                click.echo(f"  Error saving: {model_name} (PK: {pk}): {e}")
+                # Depending on severity, you might want to re-raise to stop the transaction.
+                # For now, we'll log and continue.
+
+    click.echo("\nLoad process completed.")
+    click.echo(f"  Successfully saved: {saved_count} objects.")
+    click.echo(f"  Skipped (IntegrityError): {skipped_count} objects.")
+    click.echo(f"  Errors (Other): {error_count} objects.")
+    if skipped_count > 0 or error_count > 0:
+        click.echo(
+            "Please check skipped/error messages. This might indicate that the target database was not clean,"
+        )
+        click.echo("or that required related objects (like Organizations or Users) were missing.")
+
+
+if __name__ == "__main__":
+    parser = argparse.ArgumentParser(
+        description="Load Sentry integration-related models from a JSON file into the database."
+    )
+    parser.add_argument(
+        "--input-file",
+        required=True,
+        help="Path to the input JSON file containing the data to load.",
+    )
+    parser.add_argument(
+        "--org-id",
+        required=False,
+        help="The organization ID to save integration data for.",
+    )
+    args = parser.parse_args()
+
+    load_data(args.input_file, args.org_id)

bin/save-integration-data

@@ -0,0 +1,61 @@
+#!/usr/bin/env python
+from sentry.runner import configure
+
+configure()
+
+import argparse
+
+import click
+from django.core import serializers
+
+from sentry.integrations.models import Integration, OrganizationIntegration
+from sentry.users.models.identity import Identity, IdentityProvider
+
+MODELS_TO_SERIALIZE = [
+    IdentityProvider,  # Has no FKs to other serialized models
+    Integration,  # Has no FKs to other serialized models
+    Identity,  # Depends on IdentityProvider
+    OrganizationIntegration,  # Depends on Integration
+]
+
+
+def save_data(output_file):
+    """
+    Collects data from specified models and serializes it to a JSON file.
+    """
+    all_objects_to_serialize = []
+    click.echo("Collecting data from models...")
+    for model_cls in MODELS_TO_SERIALIZE:
+        model_name = f"{model_cls._meta.app_label}.{model_cls._meta.model_name}"
+        click.echo(f"  Fetching from {model_name}...")
+        # Order by PK for consistent output, though serializer might reorder.
+        # Convert queryset to list to avoid issues with extending during iteration if any.
+        objects = list(model_cls.objects.order_by("pk").all())
+        all_objects_to_serialize.extend(objects)
+        click.echo(f"    Found {len(objects)} objects.")
+
+    if not all_objects_to_serialize:
+        click.echo("No objects found to serialize.")
+        serialized_data = "[]"
+    else:
+        click.echo(f"\nSerializing {len(all_objects_to_serialize)} objects in total...")
+        serialized_data = serializers.serialize("json", all_objects_to_serialize, indent=2)
+
+    click.echo(f"Writing serialized data to {output_file}...")
+    with open(output_file, "w") as f:
+        f.write(serialized_data)
+    click.echo(f"Successfully saved data to {output_file}")
+
+
+if __name__ == "__main__":
+    parser = argparse.ArgumentParser(
+        description="Save Sentry integration-related models to a JSON file."
+    )
+    parser.add_argument(
+        "--output-file",
+        required=True,
+        help="Path to the output JSON file where data will be saved.",
+    )
+    args = parser.parse_args()
+
+    save_data(args.output_file)

build-utils/last-built-plugin.ts

@@ -1,6 +1,6 @@
 import fs from 'node:fs';
 import path from 'node:path';
-import type webpack from 'webpack';
+import type {Compiler} from 'webpack';
 
 type Options = {
   basePath: string;
@@ -15,7 +15,7 @@ class LastBuiltPlugin {
     this.isWatchMode = false;
   }
 
-  apply(compiler: webpack.Compiler) {
+  apply(compiler: Compiler) {
     compiler.hooks.watchRun.tapAsync('LastBuiltPlugin', (_, callback) => {
       this.isWatchMode = true;
       callback();