fix(crons): Fix project transfer to properly update the environment of the monitor (#70407)

We don't update the environment of `MonitorEnvironment` rows when we
transfer projects - this fixes transfer to do this correctly.

I will look into whether it's possible to fix existing rows via
backfills - I think that in most cases, a new monitor environment will
have already been created, and it won't be worth the effort to transfer
the existing checkins onto the new environment.

Author: wedamija

src/sentry/models/project.py

@@ -39,6 +39,7 @@
 from sentry.models.options.option import OptionMixin
 from sentry.models.outbox import OutboxCategory, OutboxScope, RegionOutbox, outbox_context
 from sentry.models.team import Team
+from sentry.monitors.models import MonitorEnvironment, MonitorStatus
 from sentry.services.hybrid_cloud.notifications import notifications_service
 from sentry.services.hybrid_cloud.user import RpcUser
 from sentry.services.hybrid_cloud.user.service import user_service
@@ -470,7 +471,7 @@ def transfer_to(self, organization):
             rules_by_environment_id[environment_id].add(rule_id)
 
         environment_names = dict(
-            Environment.objects.filter(id__in=rules_by_environment_id).values_list("id", "name")
+            Environment.objects.filter(organization_id=old_org_id).values_list("id", "name")
         )
 
         for environment_id, rule_ids in rules_by_environment_id.items():
@@ -487,6 +488,14 @@ def transfer_to(self, organization):
             if monitor.slug in new_monitors:
                 RegionScheduledDeletion.schedule(monitor, days=0)
             else:
+                for monitor_env_id, env_id in MonitorEnvironment.objects.filter(
+                    monitor_id=monitor.id, status=MonitorStatus.ACTIVE
+                ).values_list("id", "environment_id"):
+                    MonitorEnvironment.objects.filter(id=monitor_env_id).update(
+                        environment_id=Environment.get_or_create(
+                            self, name=environment_names.get(env_id, None)
+                        ).id
+                    )
                 monitor.update(organization_id=organization.id)
 
         # Remove alert owners not in new org

tests/sentry/models/test_project.py

@@ -17,7 +17,7 @@
 from sentry.models.rule import Rule
 from sentry.models.scheduledeletion import RegionScheduledDeletion
 from sentry.models.user import User
-from sentry.monitors.models import Monitor, MonitorType, ScheduleType
+from sentry.monitors.models import Monitor, MonitorEnvironment, MonitorType, ScheduleType
 from sentry.notifications.types import NotificationSettingEnum
 from sentry.notifications.utils.participants import get_notification_recipients
 from sentry.services.hybrid_cloud.actor import RpcActor
@@ -66,6 +66,11 @@ def test_transfer_to_organization(self):
             label="Golden Rule",
             data={},
         )
+        environment_from_new = self.create_environment(organization=from_org)
+        environment_from_existing = self.create_environment(organization=from_org)
+        environment_to_existing = self.create_environment(
+            organization=to_org, name=environment_from_existing.name
+        )
 
         monitor = Monitor.objects.create(
             name="test-monitor",
@@ -84,6 +89,12 @@ def test_transfer_to_organization(self):
             type=MonitorType.CRON_JOB,
             config={"schedule": [1, "month"], "schedule_type": ScheduleType.INTERVAL},
         )
+        monitor_env_new = MonitorEnvironment.objects.create(
+            monitor=monitor_also, environment_id=environment_from_new.id
+        )
+        monitor_env_existing = MonitorEnvironment.objects.create(
+            monitor=monitor_also, environment_id=environment_from_existing.id
+        )
 
         monitor_other = Monitor.objects.create(
             name="test-monitor-other",
@@ -124,6 +135,12 @@ def test_transfer_to_organization(self):
         assert updated_monitor.id == monitor_also.id
         assert updated_monitor.organization_id == to_org.id
         assert updated_monitor.project_id == project.id
+        monitor_env_new.refresh_from_db()
+        environment_to_new = Environment.objects.get(id=monitor_env_new.environment_id)
+        assert environment_to_new.organization_id == to_org.id
+        assert environment_to_new.name == environment_from_new.name
+        monitor_env_existing.refresh_from_db()
+        assert monitor_env_existing.environment_id == environment_to_existing.id
 
         unmoved_monitor = Monitor.objects.get(slug="test-monitor-other")
         assert unmoved_monitor.id == monitor_other.id