nit: query for environment name '' (#63634)

if groupenvironment is guaranteed to exist on the group model, then we
should query for environments with name ''

Author: nhsiehgit

src/sentry/api/endpoints/release_thresholds/utils/get_new_issue_counts.py

@@ -15,27 +15,18 @@ def get_new_issue_counts(
 ) -> dict[str, int]:
     """
     constructs a query for each threshold, filtering on project
+    NOTE: group messages are guaranteed to have a related groupenvironment
     """
     queryset: QuerySet | None = None
     for t in thresholds:
+        env: dict[str, Any] = t.get("environment") or {}
         query = Q(
             project__organization__id=organization_id,
             project__id=t["project_id"],
+            groupenvironment__first_release__version=t["release"],
+            groupenvironment__first_seen__range=(t["start"], t["end"]),
+            groupenvironment__environment__name=env.get("name", ""),
         )
-        env: dict[str, Any] = t.get("environment") or {}
-        if env:
-            # If we're filtering on environment, just use the first_release/first_seen from the groupenvironment so we don't need to cross reference tables
-            query &= Q(
-                groupenvironment__first_release__version=t["release"],
-                groupenvironment__first_seen__range=(t["start"], t["end"]),
-                groupenvironment__environment__name=env.get("name"),
-            )
-        else:
-            query &= Q(
-                first_release__version=t["release"],
-                first_seen__range=(t["start"], t["end"]),
-                groupenvironment__isnull=True,
-            )
         qs = (
             Group.objects.filter(query)
             .values("first_release__version")

tests/sentry/api/endpoints/release_thresholds/utils/test_get_new_issue_counts.py

@@ -21,8 +21,8 @@ def setUp(self):
         self.project2 = self.create_project(name="bar", organization=self.org)
 
         # 2 environments
-        self.production_environment = Environment.objects.create(
-            organization_id=self.organization.id, name="production"
+        self.null_environment = Environment.objects.create(
+            organization_id=self.organization.id, name=""
         )
         self.canary_environment = Environment.objects.create(
             organization_id=self.organization.id, name="canary"
@@ -59,12 +59,18 @@ def setUp(self):
             first_release=self.release1,
             first_seen=self.now - timedelta(minutes=30),
         )
+        self.groupenvironment_g1_r1 = GroupEnvironment.objects.create(
+            group_id=self.group1_p1_r1.id,
+            environment_id=self.null_environment.id,
+            first_release=self.release1,
+            first_seen=self.now - timedelta(minutes=30),
+        )
         self.group2_p1_r1 = Group.objects.create(
             project=self.project1,
             first_release=self.release1,
             first_seen=self.now - timedelta(minutes=30),
         )
-        self.groupenvironment_g1_r1 = GroupEnvironment.objects.create(
+        self.groupenvironment_g2_r1 = GroupEnvironment.objects.create(
             group_id=self.group2_p1_r1.id,
             environment_id=self.canary_environment.id,
             first_release=self.release1,