fix: remove set-cache-item experiment

Author: anonrig

src/sentry/db/models/fields/node.py

@@ -156,7 +156,7 @@ def save(self, subkeys=None):
         subkeys = subkeys or {}
         subkeys[None] = to_write
 
-        nodestore.backend.set_subkeys(self.id, subkeys)
+        nodestore.backend.set_subkeys(self.id, subkeys, override_cache=True)
 
 
 class NodeField(GzippedDictField):

src/sentry/issues/escalating_group_forecast.py

@@ -47,6 +47,7 @@ def save(self) -> None:
             self.build_storage_identifier(self.project_id, self.group_id),
             self.to_dict(),
             ttl=timedelta(GROUP_FORECAST_TTL),
+            override_cache=True,
         )
 
     @classmethod

src/sentry/nodestore/base.py

@@ -8,7 +8,6 @@
 from django.core.cache import BaseCache, InvalidCacheBackendError, caches
 from django.utils.functional import cached_property
 
-from sentry import options
 from sentry.utils import json, metrics
 from sentry.utils.services import Service
 
@@ -231,18 +230,28 @@ def set_bytes(self, item_id: str, data: bytes, ttl: timedelta | None = None) ->
     def _set_bytes(self, item_id: str, data: bytes, ttl: timedelta | None = None) -> None:
         raise NotImplementedError
 
-    def set(self, item_id: str, data: dict[str, str], ttl: timedelta | None = None) -> None:
+    def set(
+        self,
+        item_id: str,
+        data: dict[str, str],
+        ttl: timedelta | None = None,
+        override_cache: bool = False,
+    ) -> None:
         """
         Set value for `item_id`. Note that this deletes existing subkeys for `item_id` as
         well, use `set_subkeys` to write a value + subkeys.
 
         >>> nodestore.set('key1', {'foo': 'bar'})
         """
-        return self.set_subkeys(item_id, {None: data}, ttl=ttl)
+        return self.set_subkeys(item_id, {None: data}, ttl=ttl, override_cache=override_cache)
 
     @sentry_sdk.tracing.trace
     def set_subkeys(
-        self, item_id: str, data: dict[str | None, dict[str, str]], ttl: timedelta | None = None
+        self,
+        item_id: str,
+        data: dict[str | None, dict[str, str]],
+        ttl: timedelta | None = None,
+        override_cache: bool = False,
     ) -> None:
         """
         Set value for `item_id` and its subkeys.
@@ -261,7 +270,7 @@ def set_subkeys(
         bytes_data = self._encode(data)
         self.set_bytes(item_id, bytes_data, ttl=ttl)
         # set cache only after encoding and write to nodestore has succeeded
-        if options.get("nodestore.set-subkeys.enable-set-cache-item"):
+        if override_cache:
             self._set_cache_item(item_id, cache_item)
 
     def cleanup(self, cutoff_timestamp: datetime) -> None:

tests/sentry/nodestore/bigtable/test_backend.py

@@ -141,13 +141,6 @@ def test_cache(ns):
     ns.delete_multi([node_1[0], node_2[0]])
     assert ns.get_multi([node_1[0], node_2[0]]) == {node_1[0]: None, node_2[0]: None}
 
-    # Setting the item updates cache
-    new_value = {"event_id": "d" * 32}
-    ns.set(node_1[0], new_value)
-    with mock.patch.object(table, "read_row") as mock_read_row:
-        assert ns.get(node_1[0]) == new_value
-        assert mock_read_row.call_count == 0
-
     # Missing rows are never cached
     assert ns.get("node_4") is None
     with mock.patch.object(table, "read_row") as mock_read_row:

tests/sentry/nodestore/django/test_backend.py

@@ -119,13 +119,6 @@ def test_cache(self):
         self.ns.delete_multi([node_1[0], node_2[0]])
         assert self.ns.get_multi([node_1[0], node_2[0]]) == {}
 
-        # Setting the item updates cache
-        new_value = {"event_id": "d" * 32}
-        self.ns.set(node_1[0], new_value)
-        with mock.patch.object(Node.objects, "get") as mock_get:
-            assert self.ns.get(node_1[0]) == new_value
-            assert mock_get.call_count == 0
-
         # Missing rows are never cached
         assert self.ns.get("node_4") is None
         with mock.patch.object(Node.objects, "get") as mock_get:

tests/sentry/nodestore/test_common.py

@@ -7,7 +7,6 @@
 import pytest
 
 from sentry.nodestore.django.backend import DjangoNodeStorage
-from sentry.testutils.helpers import override_options
 from tests.sentry.nodestore.bigtable.test_backend import (
     MockedBigtableNodeStorage,
     get_temporary_bigtable_nodestorage,
@@ -31,7 +30,6 @@ def ns(request):
         yield ns
 
 
-@override_options({"nodestore.set-subkeys.enable-set-cache-item": False})
 def test_get_multi(ns):
     nodes = [("a" * 32, {"foo": "a"}), ("b" * 32, {"foo": "b"})]
 
@@ -42,15 +40,13 @@ def test_get_multi(ns):
     assert result == {n[0]: n[1] for n in nodes}
 
 
-@override_options({"nodestore.set-subkeys.enable-set-cache-item": False})
 def test_set(ns):
     node_id = "d2502ebbd7df41ceba8d3275595cac33"
     data = {"foo": "bar"}
     ns.set(node_id, data)
     assert ns.get(node_id) == data
 
 
-@override_options({"nodestore.set-subkeys.enable-set-cache-item": False})
 def test_delete(ns):
     node_id = "d2502ebbd7df41ceba8d3275595cac33"
     data = {"foo": "bar"}
@@ -60,7 +56,6 @@ def test_delete(ns):
     assert not ns.get(node_id)
 
 
-@override_options({"nodestore.set-subkeys.enable-set-cache-item": False})
 def test_delete_multi(ns):
     nodes = [("node_1", {"foo": "a"}), ("node_2", {"foo": "b"})]
 
@@ -72,7 +67,6 @@ def test_delete_multi(ns):
     assert not ns.get(nodes[1][0])
 
 
-@override_options({"nodestore.set-subkeys.enable-set-cache-item": False})
 def test_set_subkeys(ns):
     """
     Subkeys are used to store multiple JSON payloads under the same main key.