Skip to content

Commit 896150c

Browse files
authored
chore(aci): remove uses of WorkflowFireHistory rollout columns (#91904)
1 parent 312b3cb commit 896150c

File tree

6 files changed

+4
-16
lines changed

6 files changed

+4
-16
lines changed

src/sentry/api/serializers/models/rule.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ def _fetch_workflow_last_triggered(self, item_list: Sequence[Workflow]) -> dict[
422422
result_qs = reduce(
423423
lambda q1, q2: q1.union(q2),
424424
[
425-
WorkflowFireHistory.objects.filter(workflow=item, has_fired_actions=True)
425+
WorkflowFireHistory.objects.filter(workflow=item)
426426
.order_by("-date_added")
427427
.values("workflow_id", "date_added")[:1]
428428
for item in item_list

src/sentry/workflow_engine/processors/action.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,6 @@ def create_workflow_fire_histories(
8383
workflow_id=workflow_id,
8484
group=event_data.event.group,
8585
event_id=event_data.event.event_id,
86-
has_passed_filters=True,
87-
has_fired_actions=True,
8886
)
8987
for workflow_id in workflow_ids
9088
]

tests/sentry/api/serializers/test_rule.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ def assert_equal_serializers(self, issue_alert):
5656
WorkflowFireHistory.objects.create(
5757
workflow=workflow,
5858
group=self.group,
59-
has_fired_actions=True,
6059
event_id="fc6d8c0c43fc4630ad850ee518f1b9d0",
6160
)
6261

@@ -213,15 +212,13 @@ def test_fetch_workflow_last_triggered(self):
213212
workflow_2 = self.create_workflow()
214213

215214
WorkflowFireHistory.objects.create(workflow=workflow, group=self.group, event_id="asdf")
216-
WorkflowFireHistory.objects.create(
217-
workflow=workflow, group=self.group, event_id="jklm", has_fired_actions=True
218-
)
215+
WorkflowFireHistory.objects.create(workflow=workflow, group=self.group, event_id="jklm")
219216
wfh = WorkflowFireHistory.objects.create(
220-
workflow=workflow_2, group=self.group, event_id="qwer", has_fired_actions=True
217+
workflow=workflow_2, group=self.group, event_id="qwer"
221218
)
222219
wfh.update(date_added=before_now(days=1))
223220
wfh_2 = WorkflowFireHistory.objects.create(
224-
workflow=workflow_2, group=self.group, event_id="fdsa", has_fired_actions=True
221+
workflow=workflow_2, group=self.group, event_id="fdsa"
225222
)
226223
wfh_2.update(date_added=before_now(hours=1))
227224

tests/sentry/workflow_engine/processors/test_action.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ def test_create_workflow_fire_histories(self):
9393
workflow=self.workflow,
9494
group=self.group,
9595
event_id=self.group_event.event_id,
96-
has_passed_filters=True,
97-
has_fired_actions=True,
9896
).count()
9997
== 1
10098
)

tests/sentry/workflow_engine/processors/test_delayed_workflow.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -828,16 +828,12 @@ def test_fire_actions_for_groups__workflow_fire_history(self, mock_process):
828828
workflow=self.workflow2,
829829
group_id=self.group2.id,
830830
event_id=self.event2.event_id,
831-
has_passed_filters=True,
832-
has_fired_actions=True,
833831
).exists()
834832

835833
assert WorkflowFireHistory.objects.filter(
836834
workflow=self.workflow1,
837835
group_id=self.group1.id,
838836
event_id=self.event1.event_id,
839-
has_passed_filters=True,
840-
has_fired_actions=True,
841837
).exists()
842838

843839

tests/sentry/workflow_engine/processors/test_workflow.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,6 @@ def test_creates_histories(self):
628628
workflow=self.workflow,
629629
group=self.group,
630630
event_id=self.group_event.event_id,
631-
has_fired_actions=True,
632631
).count()
633632
== 1
634633
)

0 commit comments

Comments
 (0)