Skip to content

Commit 8b39295

Browse files
committed
ref(replay): Centralize some duplicate replay css
1 parent 86a4a4e commit 8b39295

File tree

3 files changed

+20
-31
lines changed

3 files changed

+20
-31
lines changed

static/app/views/replays/detail/breadcrumbs/breadcrumbRow.tsx

Lines changed: 12 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import type {CSSProperties, MouseEvent} from 'react';
22
import {useCallback} from 'react';
3-
import styled from '@emotion/styled';
43
import classNames from 'classnames';
54

65
import BreadcrumbItem from 'sentry/components/replays/breadcrumbs/breadcrumbItem';
@@ -58,33 +57,24 @@ export default function BreadcrumbRow({
5857
currentHoverTime === undefined || currentHoverTime >= frame.offsetMs;
5958

6059
return (
61-
<StyledTimeBorder
60+
<BreadcrumbItem
6261
className={classNames({
6362
beforeCurrentTime: hasOccurred,
6463
afterCurrentTime: !hasOccurred,
6564
beforeHoverTime: currentHoverTime !== undefined ? isBeforeHover : undefined,
6665
afterHoverTime: currentHoverTime !== undefined ? !isBeforeHover : undefined,
6766
})}
6867
style={style}
69-
>
70-
<BreadcrumbItem
71-
frame={frame}
72-
traces={traces}
73-
extraction={extraction}
74-
onClick={onClick}
75-
onMouseEnter={onMouseEnter}
76-
onMouseLeave={onMouseLeave}
77-
startTimestampMs={startTimestampMs}
78-
expandPaths={expandPaths}
79-
onDimensionChange={handleDimensionChange}
80-
onInspectorExpanded={handleObjectInspectorExpanded}
81-
/>
82-
</StyledTimeBorder>
68+
frame={frame}
69+
traces={traces}
70+
extraction={extraction}
71+
onClick={onClick}
72+
onMouseEnter={onMouseEnter}
73+
onMouseLeave={onMouseLeave}
74+
startTimestampMs={startTimestampMs}
75+
expandPaths={expandPaths}
76+
onDimensionChange={handleDimensionChange}
77+
onInspectorExpanded={handleObjectInspectorExpanded}
78+
/>
8379
);
8480
}
85-
86-
const StyledTimeBorder = styled('div')`
87-
/* Overridden in TabItemContainer, depending on *CurrentTime and *HoverTime classes */
88-
border-top: 1px solid transparent;
89-
border-bottom: 1px solid transparent;
90-
`;

static/app/views/replays/detail/console/consoleLogRow.tsx

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type {CSSProperties} from 'react';
2-
import {memo, useCallback} from 'react';
2+
import {useCallback} from 'react';
33
import styled from '@emotion/styled';
44
import classNames from 'classnames';
55

@@ -25,7 +25,7 @@ interface Props extends ReturnType<typeof useCrumbHandlers> {
2525
onDimensionChange?: OnDimensionChange;
2626
}
2727

28-
function UnmemoizedConsoleLogRow({
28+
export default function ConsoleLogRow({
2929
currentHoverTime,
3030
currentTime,
3131
expandPaths,
@@ -99,10 +99,6 @@ const ConsoleLog = styled('div')<{
9999
? p.theme.alert[String(p.level)].backgroundLight
100100
: 'inherit'};
101101
102-
/* Overridden in TabItemContainer, depending on *CurrentTime and *HoverTime classes */
103-
border-top: 1px solid transparent;
104-
border-bottom: 1px solid transparent;
105-
106102
color: ${p => p.theme.gray400};
107103
108104
/*
@@ -151,6 +147,3 @@ const Message = styled('div')`
151147
white-space: pre-wrap;
152148
word-break: break-word;
153149
`;
154-
155-
const ConsoleLogRow = memo(UnmemoizedConsoleLogRow);
156-
export default ConsoleLogRow;

static/app/views/replays/detail/tabItemContainer.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ const TabItemContainer = styled('div')`
88
border-radius: ${p => p.theme.borderRadius};
99
display: grid;
1010
11+
.beforeCurrentTime,
12+
.afterCurrentTime {
13+
border-top: 1px solid transparent;
14+
border-bottom: 1px solid transparent;
15+
}
16+
1117
.beforeHoverTime + .afterHoverTime {
1218
border-top-color: ${p => p.theme.purple200};
1319
}

0 commit comments

Comments
 (0)