fix(uptime): Disable uptime autodetection when a manual uptime monitor is created

If someone manually creates a monitor, we don't need to perform any more auto detection since they're now aware of the feature. So disable auto-detection, and remove any onboarding uptime monitors.

Author: wedamija

src/sentry/uptime/subscriptions/subscriptions.py

@@ -191,6 +191,16 @@ def create_project_uptime_subscription(
             project__organization=project.organization,
             config__mode=ProjectUptimeSubscriptionMode.MANUAL,
         ).count()
+
+        # Once a user has created a subscription manually, make sure we disable all autodetection, and remove any
+        # onboarding monitors
+        if project.organization.get_option("sentry:uptime_autodetection", False):
+            project.organization.update_option("sentry:uptime_autodetection", False)
+            for detector in get_auto_monitored_detectors_for_project(
+                project, modes=[ProjectUptimeSubscriptionMode.AUTO_DETECTED_ONBOARDING]
+            ):
+                delete_uptime_detector(detector)
+
         if (
             not override_manual_org_limit
             and manual_subscription_count >= MAX_MANUAL_SUBSCRIPTIONS_PER_ORG
@@ -456,15 +466,16 @@ def is_url_auto_monitored_for_project(project: Project, url: str) -> bool:
     ).exists()
 
 
-def get_auto_monitored_detectors_for_project(project: Project) -> list[Detector]:
+def get_auto_monitored_detectors_for_project(
+    project: Project,
+    modes: Sequence[ProjectUptimeSubscriptionMode] = (
+        ProjectUptimeSubscriptionMode.AUTO_DETECTED_ONBOARDING.value,
+        ProjectUptimeSubscriptionMode.AUTO_DETECTED_ACTIVE.value,
+    ),
+) -> list[Detector]:
     return list(
         Detector.objects.filter(
-            type=UptimeDomainCheckFailure.slug,
-            project=project,
-            config__mode__in=(
-                ProjectUptimeSubscriptionMode.AUTO_DETECTED_ONBOARDING.value,
-                ProjectUptimeSubscriptionMode.AUTO_DETECTED_ACTIVE.value,
-            ),
+            type=UptimeDomainCheckFailure.slug, project=project, config__mode__in=modes
         )
     )
 

tests/sentry/uptime/subscriptions/test_subscriptions.py

@@ -398,6 +398,30 @@ def test_no_seat_assignment(self, _mock_check_assign_seat):
         assert detector
         assert not detector.enabled
 
+    def test_create_manual_removes_onboarding(self):
+        assert self.organization.update_option("sentry:uptime_autodetection", True)
+        onboarding_monitor = create_project_uptime_subscription(
+            self.project,
+            self.environment,
+            url="https://sentry.io",
+            interval_seconds=3600,
+            timeout_ms=1000,
+            mode=ProjectUptimeSubscriptionMode.AUTO_DETECTED_ONBOARDING,
+        )
+        assert self.organization.get_option("sentry:uptime_autodetection")
+
+        create_project_uptime_subscription(
+            self.project,
+            self.environment,
+            url="https://sentry.io/manual",
+            interval_seconds=3600,
+            timeout_ms=1000,
+            mode=ProjectUptimeSubscriptionMode.MANUAL,
+        )
+        assert not self.organization.get_option("sentry:uptime_autodetection")
+        with pytest.raises(ProjectUptimeSubscription.DoesNotExist):
+            onboarding_monitor.refresh_from_db()
+
 
 class UpdateProjectUptimeSubscriptionTest(UptimeTestCase):
     def test(self):