Skip to content

Commit 930c103

Browse files
authored
fix(insights): span samples panel should pass fix(insights): sample queries should pass dataset param (#92119)
1 parent afa5060 commit 930c103

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

static/app/views/insights/common/queries/useSpanSamples.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import type {EventsMetaType} from 'sentry/utils/discover/eventView';
2+
import {DiscoverDatasets} from 'sentry/utils/discover/types';
23
import {useApiQuery} from 'sentry/utils/queryClient';
34
import {MutableSearch} from 'sentry/utils/tokenizeSearch';
45
import {useLocation} from 'sentry/utils/useLocation';
@@ -7,6 +8,7 @@ import usePageFilters from 'sentry/utils/usePageFilters';
78
import {computeAxisMax} from 'sentry/views/insights/common/components/chart';
89
import {useSpanMetricsSeries} from 'sentry/views/insights/common/queries/useDiscoverSeries';
910
import {getDateConditions} from 'sentry/views/insights/common/utils/getDateConditions';
11+
import {useInsightsEap} from 'sentry/views/insights/common/utils/useEap';
1012
import type {
1113
SpanIndexedFieldTypes,
1214
SpanIndexedProperty,
@@ -141,6 +143,7 @@ export const useSpanSamples = <Fields extends NonDefaultSpanSampleFields[]>(
141143
SpanIndexedField.TRANSACTION_SPAN_ID, // TODO: transaction.span_id should be a default from the backend
142144
...additionalFields,
143145
],
146+
dataset: useInsightsEap() ? DiscoverDatasets.SPANS_EAP : undefined,
144147
sort: `-${SPAN_SELF_TIME}`,
145148
},
146149
},

static/app/views/insights/http/queries/useSpanSamples.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import {defined} from 'sentry/utils';
44
import type {EventsMetaType} from 'sentry/utils/discover/eventView';
5+
import {DiscoverDatasets} from 'sentry/utils/discover/types';
56
import {useApiQuery} from 'sentry/utils/queryClient';
67
import type {MutableSearch} from 'sentry/utils/tokenizeSearch';
78
import useOrganization from 'sentry/utils/useOrganization';
@@ -11,6 +12,7 @@ import type {
1112
NonDefaultSpanSampleFields,
1213
} from 'sentry/views/insights/common/queries/useSpanSamples';
1314
import {getDateConditions} from 'sentry/views/insights/common/utils/getDateConditions';
15+
import {useInsightsEap} from 'sentry/views/insights/common/utils/useEap';
1416
import {SpanIndexedField, type SpanIndexedResponse} from 'sentry/views/insights/types';
1517

1618
interface UseSpanSamplesOptions<Fields> {
@@ -67,6 +69,7 @@ export const useSpanSamples = <Fields extends NonDefaultSpanSampleFields[]>(
6769
// TODO: transaction.span_id should be a default from the backend
6870
additionalFields: [...fields, SpanIndexedField.TRANSACTION_SPAN_ID],
6971
sort: '-timestamp',
72+
dataset: useInsightsEap() ? DiscoverDatasets.SPANS_EAP : undefined,
7073
referrer,
7174
},
7275
},

0 commit comments

Comments
 (0)