🐛 fix(vsts): truncate vsts issue title length (#92207)

Author: iamrajjoshi

src/sentry/integrations/vsts/issues.py

@@ -32,6 +32,8 @@
     "is currently Deleted within the following Microsoft Entra tenant"
 ]
 
+VSTS_ISSUE_TITLE_MAX_LENGTH = 128
+
 
 class VstsIssuesSpec(IssueSyncIntegration, SourceCodeIssueIntegration, ABC):
     description = "Integrate Azure DevOps work items by linking a project."
@@ -201,6 +203,9 @@ def create_issue(self, data: Mapping[str, str], **kwargs: Any) -> Mapping[str, A
         description = data["description"]
         item_type = data["work_item_type"]
 
+        if len(title) > VSTS_ISSUE_TITLE_MAX_LENGTH:
+            title = title[: VSTS_ISSUE_TITLE_MAX_LENGTH - 3] + "..."
+
         try:
             created_item = client.create_work_item(
                 project=project_id,

tests/sentry/integrations/vsts/test_issues.py

@@ -193,6 +193,41 @@ def test_create_issue(self):
             {"op": "add", "path": "/fields/System.History", "value": "<p>Fix this.</p>\n"},
         ]
 
+    @responses.activate
+    def test_create_issue_title_too_long(self):
+        responses.add(
+            responses.PATCH,
+            "https://fabrikam-fiber-inc.visualstudio.com/0987654321/_apis/wit/workitems/$Microsoft.VSTS.WorkItemTypes.Task",
+            body=WORK_ITEM_RESPONSE,
+            content_type="application/json",
+        )
+
+        long_title = "A" * 200  # Title longer than VSTS's 128 character limit
+        expected_title = "A" * 125 + "..."
+
+        form_data = {
+            "title": long_title,
+            "description": "Fix this.",
+            "project": "0987654321",
+            "work_item_type": "Microsoft.VSTS.WorkItemTypes.Task",
+        }
+        assert self.integration.create_issue(form_data) == {
+            "key": self.issue_id,
+            "description": "Fix this.",
+            "title": expected_title,
+            "metadata": {"display_name": "Fabrikam-Fiber-Git#309"},
+        }
+        request = responses.calls[-1].request
+        assert request.headers["Content-Type"] == "application/json-patch+json"
+        payload = orjson.loads(request.body)
+        assert payload == [
+            {"op": "add", "path": "/fields/System.Title", "value": expected_title},
+            # Adds both a comment and a description.
+            # See method for details.
+            {"op": "add", "path": "/fields/System.Description", "value": "<p>Fix this.</p>\n"},
+            {"op": "add", "path": "/fields/System.History", "value": "<p>Fix this.</p>\n"},
+        ]
+
     @responses.activate
     def test_create_issue_failure(self):
         form_data = {