chore: Enable a few eslint rules that overlap with biomes rule list (#83693)

Looking at our biome config here we can see all the linty rules that are
enabled for JavaScript files:
https://github.com/getsentry/sentry/blob/fc9ccb0f4754939a4cf19bfdb08b526f5a491f5a/biome.json#L14-L87

The docs provide the name of the equiv rule inside eslint core, or
inside other eslint plugins if available. I mapped the names of the
biome rules to those eslint rules here (below).

Then I went through each rule and enabled it within the codebase. It was
meant to be trivial because biome should've prevented violations, but a
few places did need to be fixed up. Anywhere that had a biome-ignore
statement needed an eslint one too.

There are still a few rules that biome implements which are not in our
eslint config right now. The categories are broadly:
1. Rules from plugins that i haven't installed yet, like from
`unicorn/*` or from `barrel-files/*`. I'll import these plugins in a
followup and check things off the list.
2. Some rules have no eslint equiv: `noApproximativeNumericConstant` &
`noMisrefactoredShorthandAssign`, they're also not important to have
enabled imo
3. Some rules have an eslint equiv but are also not important:
`noShoutyConstants` & `noInvalidUseBeforeDeclaration` would cause lots
of churn in the repo for example. Others are repalced by prettier.
4. Some rules depend on type annotations, these are challenging because
they are often nice to have but type annotations are _slow_ in eslint.
It would make pre-commit checks really terrible if that was enabled.
`consistent-type-imports` is an example.

I intend to get plugins to fill these specific biome gaps while
maintaining pre-commit perf.

----

The rules table is here:

| Biome Rule | ESLint Rule | Handled by |
| ------------------------------------- |
------------------------------------------------- |
------------------------ |
| noBlankTarget | react/jsx-no-target-blank | ✅ react/recommended
| noGlobalObjectCalls | no-obj-calls | ✅ tsc
| noUnreachable | no-unreachable | ✅ tsc
| useIsNan | use-isnan | ✅ eslint/recommended
| noUnusedPrivateClassMembers | no-unused-private-class-members | ✅
eslint/recommended
| noInvalidUseBeforeDeclaration |
@typescript-eslint/no-use-before-define | ✅ Disabled in sentry
| noNodejsModules | import/no-nodejs-modules | ✅ eslint.config (except
scripts)
| useFlatMap | unicorn/prefer-array-flat-map | TODO
| useOptionalChain | @typescript-eslint/prefer-optional-chain | TODO
typescript/stylistic-type-checked
| noEmptyTypeParameters | Prettier? | TODO
| noUselessLoneBlockStatements | no-lone-blocks | ✅ eslint.config
| noUselessEmptyExport | @typescript-eslint/no-useless-empty-export | ✅
eslint.config
| noUselessConstructor | @typescript-eslint/no-useless-constructor | ✅
typescript/strict
| noUselessTypeConstraint |
@typescript-eslint/no-unnecessary-type-constraint | ✅
typescript/recommended
| noExcessiveNestedTestSuites | jest/max-nested-describe (max=5) | ✅
eslint.config
| noBarrelFile | barrel-files/avoid-barrel-files | TODO
| noDangerouslySetInnerHtmlWithChildren | react/no-danger-with-children
| ✅ react/recommended
| noDebugger | no-debugger | ✅ eslint/recommended
| noDoubleEquals | eqeqeq | ✅ eslint.config
| noDuplicateJsxProps | react/jsx-no-duplicate-props | ✅
react/recommended
| noDuplicateObjectKeys | no-dupe-keys | ✅ tsc
| noDuplicateParameters | no-dupe-args | ✅ tsc
| noDuplicateCase | no-duplicate-case | ✅ eslint/recommended
| noFallthroughSwitchClause | no-fallthrough | ✅ eslint/recommended
| noRedeclare | @typescript-eslint/no-redeclare | ✅ tsc
| noSparseArray | no-sparse-arrays | ✅ eslint recommended
| noUnsafeDeclarationMerging |
@typescript-eslint/no-unsafe-declaration-merging | ✅
typescript/recommended
| noUnsafeNegation | no-unsafe-negation | ✅ tsc
| useIsArray | unicorn/no-instanceof-array | TODO
| noApproximativeNumericConstant | approx_constant | TODO
| noMisrefactoredShorthandAssign | misrefactored_assign_op | TODO
| useAwait | require-await & @typescript-eslint/require-await | ✅
esint.config
| useNamespaceKeyword | @typescript-eslint/prefer-namespace-keyword | ✅
typescript/recommended
| noFocusedTests | jest/no-focused-tests | ✅ jest/recommended
| noDuplicateTestHooks | jest/no-duplicate-hooks | ✅ eslint.config
| noCommaOperator | no-sequences | ✅ eslint.config
| noShoutyConstants | ??? | TODO
| noParameterProperties | @typescript-eslint/parameter-properties | ✅
typescript
| noVar | no-var | ✅ eslint.config
| useConst | prefer-const | ✅ tsc
| useShorthandFunctionType | @typescript-eslint/prefer-function-type | ✅
typescript/stylistic
| useExportType | @typescript-eslint/consistent-type-exports | TODO
requires types
| useImportType | @typescript-eslint/consistent-type-imports | TODO
requires types
| useNodejsImportProtocol | unicorn/prefer-node-protocol | TODO
| useLiteralEnumMembers | @typescript-eslint/prefer-literal-enum-member
| ✅ typescript/strict
| useEnumInitializers | @typescript-eslint/prefer-enum-initializers | ✅
| useAsConstAssertion | @typescript-eslint/prefer-as-const | ✅
typescript/recommended
| useBlockStatements | curly | ✅ prettier

New plugins: 
-
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-array-flat-map.md
-
https://github.com/thepassle/eslint-plugin-barrel-files/blob/main/docs/rules/avoid-barrel-files.md
- https://tanstack.com/query/v5/docs/eslint/eslint-plugin-query

Author: ryan953

eslint.config.mjs

@@ -236,6 +236,7 @@ export default typescript.config([
       'consistent-return': 'error',
       'default-case': 'error',
       'dot-notation': 'error',
+      eqeqeq: 'error',
       'guard-for-in': 'off', // TODO(ryan953): Fix violations and enable this rule
       'multiline-comment-style': ['error', 'separate-lines'],
       'no-alert': 'error',
@@ -268,6 +269,7 @@ export default typescript.config([
       'no-sequences': 'error',
       'no-throw-literal': 'error',
       'object-shorthand': ['error', 'properties'],
+      radix: 'error',
       'require-await': 'error', // Enabled in favor of @typescript-eslint/require-await, which requires type info
       'spaced-comment': [
         'error',
@@ -277,10 +279,9 @@ export default typescript.config([
           block: {exceptions: ['*'], balanced: true},
         },
       ],
+      strict: 'error',
       'vars-on-top': 'off',
       'wrap-iife': ['error', 'any'],
-      radix: 'error',
-      strict: 'error',
       yoda: 'error',
 
       // https://github.com/eslint/eslint/blob/main/packages/js/src/configs/eslint-recommended.js
@@ -369,6 +370,7 @@ export default typescript.config([
         {selector: 'typeLike', format: ['PascalCase'], leadingUnderscore: 'allow'},
         {selector: 'enumMember', format: ['UPPER_CASE']},
       ],
+
       '@typescript-eslint/no-restricted-types': [
         'error',
         {
@@ -392,6 +394,7 @@ export default typescript.config([
       ],
       '@typescript-eslint/no-shadow': 'error',
       '@typescript-eslint/no-use-before-define': 'off', // Enabling this will cause a lot of thrash to the git history
+      '@typescript-eslint/no-useless-empty-export': 'error',
     },
   },
   // https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/base.ts
@@ -406,8 +409,8 @@ export default typescript.config([
     // https://typescript-eslint.io/rules/
     plugins: {'@typescript-eslint': typescript.plugin},
     rules: {
-      'no-var': 'off', // TODO(ryan953): Fix violations and delete this line
       'prefer-spread': 'off', // TODO(ryan953): Fix violations and delete this line
+      '@typescript-eslint/prefer-enum-initializers': 'error',
 
       // Recommended overrides
       '@typescript-eslint/ban-ts-comment': 'off', // TODO(ryan953): Fix violations and delete this line
@@ -427,7 +430,6 @@ export default typescript.config([
       '@typescript-eslint/no-extraneous-class': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/no-invalid-void-type': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/no-non-null-assertion': 'off', // TODO(ryan953): Fix violations and delete this line
-      '@typescript-eslint/prefer-literal-enum-member': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/unified-signatures': 'off', // TODO(ryan953): Fix violations and delete this line
 
       // Stylistic overrides
@@ -439,7 +441,6 @@ export default typescript.config([
       '@typescript-eslint/no-empty-function': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/no-inferrable-types': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/prefer-for-of': 'off', // TODO(ryan953): Fix violations and delete this line
-      '@typescript-eslint/prefer-function-type': 'off', // TODO(ryan953): Fix violations and delete this line
 
       // Customization
       '@typescript-eslint/no-unused-vars': [
@@ -558,26 +559,18 @@ export default typescript.config([
     // https://github.com/jest-community/eslint-plugin-jest/tree/main/docs/rules
     plugins: jest.configs['flat/recommended'].plugins,
     rules: {
+      'jest/max-nested-describe': 'error',
+      'jest/no-duplicate-hooks': 'error',
+      'jest/no-large-snapshots': ['error', {maxSize: 2000}], // We don't recommend snapshots, but if there are any keep it small
+
       // https://github.com/jest-community/eslint-plugin-jest/blob/main/src/index.ts
       ...jest.configs['flat/recommended'].rules,
       ...jest.configs['flat/style'].rules,
 
-      // `recommended` set this to warn, we've upgraded to error
-      'jest/no-disabled-tests': 'error',
-
-      // `recommended` set this to warn, we've downgraded to off
-      // Disabled as we have many tests which render as simple validations
-      'jest/expect-expect': 'off',
-
-      // Disabled as we have some comment out tests that cannot be
-      // uncommented due to typescript errors.
+      'jest/expect-expect': 'off', // Disabled as we have many tests which render as simple validations
       'jest/no-commented-out-tests': 'off', // TODO(ryan953): Fix violations then delete this line
-
-      // Disabled as we do sometimes have conditional expects
       'jest/no-conditional-expect': 'off', // TODO(ryan953): Fix violations then delete this line
-
-      // We don't recommend snapshots, but if there are any keep it small
-      'jest/no-large-snapshots': ['error', {maxSize: 2000}],
+      'jest/no-disabled-tests': 'error', // `recommended` set this to warn, we've upgraded to error
     },
   },
   {

package.json

@@ -146,7 +146,6 @@
     "qrcode.react": "^3.1.0",
     "query-string": "7.0.1",
     "react": "18.2.0",
-    "react-textarea-autosize": "8.5.7",
     "react-date-range": "^1.4.0",
     "react-dom": "18.2.0",
     "react-grid-layout": "^1.3.4",
@@ -156,6 +155,7 @@
     "react-router-dom": "^6.26.2",
     "react-select": "4.3.1",
     "react-sparklines": "1.7.0",
+    "react-textarea-autosize": "8.5.7",
     "react-virtualized": "^9.22.5",
     "reflux": "0.4.1",
     "screenfull": "^6.0.2",

static/app/components/events/autofix/autofixMessageBox.tsx

@@ -481,7 +481,7 @@ function AutofixMessageBox({
     }
 
     if (text.trim() !== '' || allowEmptyMessage) {
-      if (onSend != null) {
+      if (onSend !== null) {
         onSend(text);
       } else {
         send({

static/app/utils/profiling/renderers/UIFramesRenderer.tsx

@@ -6,14 +6,12 @@ import type {UIFrameNode, UIFrames} from 'sentry/utils/profiling/uiFrames';
 
 import {upperBound} from '../gl/utils';
 
-export interface UIFramesRendererConstructor {
-  new (
-    canvas: HTMLCanvasElement,
-    uiFrames: UIFrames,
-    theme: FlamegraphTheme,
-    options?: {draw_border: boolean}
-  ): UIFramesRenderer;
-}
+export type UIFramesRendererConstructor = new (
+  canvas: HTMLCanvasElement,
+  uiFrames: UIFrames,
+  theme: FlamegraphTheme,
+  options?: {draw_border: boolean}
+) => UIFramesRenderer;
 
 export abstract class UIFramesRenderer {
   ctx: CanvasRenderingContext2D | WebGLRenderingContext | null = null;

static/app/utils/profiling/renderers/flamegraphRenderer.tsx

@@ -17,14 +17,12 @@ export const DEFAULT_FLAMEGRAPH_RENDERER_OPTIONS: FlamegraphRendererOptions = {
   draw_border: false,
 };
 
-export interface FlamegraphRendererConstructor {
-  new (
-    canvas: HTMLCanvasElement,
-    flamegraph: Flamegraph,
-    theme: FlamegraphTheme,
-    options?: FlamegraphRendererOptions
-  ): FlamegraphRenderer;
-}
+export type FlamegraphRendererConstructor = new (
+  canvas: HTMLCanvasElement,
+  flamegraph: Flamegraph,
+  theme: FlamegraphTheme,
+  options?: FlamegraphRendererOptions
+) => FlamegraphRenderer;
 
 export abstract class FlamegraphRenderer {
   ctx: CanvasRenderingContext2D | WebGLRenderingContext | null = null;

static/app/utils/statics-setup.tsx

@@ -1,7 +1,7 @@
 /* eslint no-native-reassign:0 */
 
 // biome-ignore lint/style/noVar: Not required
-declare var __webpack_public_path__: string;
+declare var __webpack_public_path__: string; // eslint-disable-line no-var
 
 /**
  * Set the webpack public path at runtime. This is necessary so that imports

static/app/views/alerts/rules/issue/setupMessagingIntegrationButton.tsx

@@ -63,7 +63,7 @@ function SetupMessagingIntegrationButton({
     messagingIntegrationsQuery.isError ||
     integrationProvidersQuery.some(({isPending}) => isPending) ||
     integrationProvidersQuery.some(({isError}) => isError) ||
-    integrationProvidersQuery[0]!.data == null
+    integrationProvidersQuery[0]!.data === undefined
   ) {
     return null;
   }

static/app/views/insights/mobile/screens/utils.ts

@@ -5,7 +5,7 @@ import {formatPercentage} from 'sentry/utils/number/formatPercentage';
 import {VitalState} from 'sentry/views/performance/vitalDetail/utils';
 
 const formatMetricValue = (metric: MetricValue, field?: string | undefined): string => {
-  if (metric.value == null) {
+  if (metric.value === undefined) {
     return '-';
   }
   if (typeof metric.value === 'number' && metric.type === 'duration' && metric.unit) {

static/app/views/issueList/utils.tsx

@@ -10,7 +10,7 @@ import type {Organization} from 'sentry/types/organization';
 export enum Query {
   FOR_REVIEW = 'is:unresolved is:for_review assigned_or_suggested:[me, my_teams, none]',
   // biome-ignore lint/style/useLiteralEnumMembers: Disable for maintenance cost.
-  PRIORITIZED = DEFAULT_QUERY,
+  PRIORITIZED = DEFAULT_QUERY, // eslint-disable-line @typescript-eslint/prefer-literal-enum-member
   UNRESOLVED = 'is:unresolved',
   IGNORED = 'is:ignored',
   NEW = 'is:new',

tests/js/setup.ts

@@ -159,10 +159,12 @@ declare global {
   /**
    * Generates a promise that resolves on the next macro-task
    */
+  // eslint-disable-next-line no-var
   var tick: () => Promise<void>;
   /**
    * Used to mock API requests
    */
+  // eslint-disable-next-line no-var
   var MockApiClient: typeof Client;
 }