ref(shared-views): Delete default views logic and PUT endpoint (#91352)

With the release of shared views, there are a few clean up things to do
on the backend:

1. Having no starred views is a valid state now, so we should no longer
return a default view if a user has no starred views.
2. The bulk update endpoint is now completely deprecated, since it was
only used in the old UI. We can now delete that endpoint along with all
of its helper functions and serializers (thank god). I confirmed that
traffic to that endpoint has gone to 0 since the release yesterday
(internal [discover
query](https://sentry.sentry.io/explore/discover/results/?field=count()&name=Deprecated%20Issue%20Views%20Endpoints&query=transaction:/api/0/organizations/%7Borganization_id_or_slug%7D/group-search-views/%20http.method:PUT&queryDataset=transaction-like&sort=count&statsPeriod=7d&yAxis=count())

I'll probably merge this early next week once we are sure the release is
stable

Author: MichaelSun48

src/sentry/api/serializers/rest_framework/groupsearchview.py

@@ -65,16 +65,6 @@ def validate(self, data) -> GroupSearchViewValidatorResponse:
         return data
 
 
-class GroupSearchViewValidator(serializers.Serializer):
-    # TODO(msun): Remove min_length when tabbed views are removed
-    views = serializers.ListField(
-        child=ViewValidator(), required=True, min_length=1, max_length=MAX_VIEWS
-    )
-
-    def validate(self, data):
-        return data
-
-
 class GroupSearchViewPostValidator(ViewValidator):
     starred = serializers.BooleanField(required=False)
 

src/sentry/issues/endpoints/organization_group_search_views.py

@@ -1,5 +1,4 @@
 from django.contrib.auth.models import AnonymousUser
-from django.db import IntegrityError, router, transaction
 from django.db.models import Count, F, OuterRef, Q, Subquery
 from rest_framework import serializers, status
 from rest_framework.request import Request
@@ -10,14 +9,10 @@
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
 from sentry.api.bases.organization import OrganizationEndpoint, OrganizationPermission
-from sentry.api.paginator import ChainPaginator, OffsetPaginator
+from sentry.api.paginator import ChainPaginator
 from sentry.api.serializers import serialize
 from sentry.api.serializers.models.groupsearchview import GroupSearchViewSerializer
-from sentry.api.serializers.rest_framework.groupsearchview import (
-    GroupSearchViewPostValidator,
-    GroupSearchViewValidator,
-    GroupSearchViewValidatorResponse,
-)
+from sentry.api.serializers.rest_framework.groupsearchview import GroupSearchViewPostValidator
 from sentry.models.groupsearchview import GroupSearchView, GroupSearchViewVisibility
 from sentry.models.groupsearchviewlastvisited import GroupSearchViewLastVisited
 from sentry.models.groupsearchviewstarred import GroupSearchViewStarred
@@ -31,7 +26,6 @@ class MemberPermission(OrganizationPermission):
     scope_map = {
         "GET": ["member:read", "member:write"],
         "POST": ["member:read", "member:write"],
-        "PUT": ["member:read", "member:write"],
     }
 
 
@@ -68,7 +62,6 @@ class OrganizationGroupSearchViewsEndpoint(OrganizationEndpoint):
     publish_status = {
         "GET": ApiPublishStatus.EXPERIMENTAL,
         "POST": ApiPublishStatus.EXPERIMENTAL,
-        "PUT": ApiPublishStatus.EXPERIMENTAL,
     }
     owner = ApiOwner.ISSUES
     permission_classes = (MemberPermission,)
@@ -236,145 +229,6 @@ def post(self, request: Request, organization: Organization) -> Response:
             status=status.HTTP_201_CREATED,
         )
 
-    def put(self, request: Request, organization: Organization) -> Response:
-        """
-        Bulk updates the current organization member's custom views. This endpoint
-        will delete any views that are not included in the request, add views if
-        they are new, and update existing views if they are included in the request.
-        This endpoint is explcititly designed to be used by our frontend.
-        """
-        if not features.has(
-            "organizations:issue-stream-custom-views", organization, actor=request.user
-        ):
-            return Response(status=status.HTTP_404_NOT_FOUND)
-
-        serializer = GroupSearchViewValidator(
-            data=request.data, context={"organization": organization}
-        )
-
-        if not serializer.is_valid():
-            return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
-
-        validated_data = serializer.validated_data
-
-        try:
-            with transaction.atomic(using=router.db_for_write(GroupSearchView)):
-                new_view_ids_state = bulk_update_views(
-                    organization, request.user.id, validated_data["views"]
-                )
-        except IntegrityError:
-            return Response(status=status.HTTP_500_INTERNAL_SERVER_ERROR)
-
-        new_user_starred_views = (
-            GroupSearchView.objects.filter(id__in=new_view_ids_state)
-            .prefetch_related("projects")
-            .order_by("groupsearchviewstarred__position")
-        )
-
-        has_global_views = features.has("organizations:global-views", organization)
-        default_project = pick_default_project(organization, request.user)
-
-        return self.paginate(
-            request=request,
-            queryset=new_user_starred_views,
-            paginator_cls=OffsetPaginator,
-            on_results=lambda x: serialize(
-                x,
-                request.user,
-                serializer=GroupSearchViewSerializer(
-                    has_global_views=has_global_views,
-                    default_project=default_project,
-                    organization=organization,
-                ),
-            ),
-        )
-
-
-def bulk_update_views(
-    org: Organization, user_id: int, views: list[GroupSearchViewValidatorResponse]
-) -> list[int]:
-    existing_view_ids = [view["id"] for view in views if "id" in view]
-
-    _delete_missing_views(org, user_id, view_ids_to_keep=existing_view_ids)
-    created_view_ids = []
-    for idx, view in enumerate(views):
-        if "id" not in view:
-            created_view_ids.append(_create_view(org, user_id, view, position=idx).id)
-        else:
-            created_view_ids.append(_update_existing_view(org, user_id, view, position=idx).id)
-
-    return created_view_ids
-
-
-def _delete_missing_views(org: Organization, user_id: int, view_ids_to_keep: list[str]) -> None:
-    GroupSearchView.objects.filter(organization=org, user_id=user_id).exclude(
-        id__in=view_ids_to_keep
-    ).delete()
-
-
-def _update_existing_view(
-    org: Organization, user_id: int, view: GroupSearchViewValidatorResponse, position: int
-) -> GroupSearchView:
-    try:
-        gsv = GroupSearchView.objects.get(id=view["id"], user_id=user_id)
-        gsv.name = view["name"]
-        gsv.query = view["query"]
-        gsv.query_sort = view["querySort"]
-        gsv.is_all_projects = view.get("isAllProjects", False)
-
-        if "projects" in view:
-            gsv.projects.set(view["projects"])
-
-        if "environments" in view:
-            gsv.environments = view["environments"]
-
-        if "timeFilters" in view:
-            gsv.time_filters = view["timeFilters"]
-
-        gsv.save()
-        GroupSearchViewStarred.objects.update_or_create(
-            organization=org,
-            user_id=user_id,
-            group_search_view=gsv,
-            defaults={
-                "position": position,
-                "visibility": GroupSearchViewVisibility.ORGANIZATION,
-            },
-        )
-        return gsv
-    except GroupSearchView.DoesNotExist:
-        # It is possible – though unlikely under normal circumstances – for a view to come in that
-        # doesn't exist anymore. If, for example, the user has the issue stream open in separate
-        # windows, deletes a view in one window, then updates it in the other before refreshing.
-        # In this case, we decide to recreate the tab instead of leaving it deleted.
-        return _create_view(org, user_id, view, position)
-
-
-def _create_view(
-    org: Organization, user_id: int, view: GroupSearchViewValidatorResponse, position: int
-) -> GroupSearchView:
-    gsv = GroupSearchView.objects.create(
-        organization=org,
-        user_id=user_id,
-        name=view["name"],
-        query=view["query"],
-        query_sort=view["querySort"],
-        is_all_projects=view.get("isAllProjects", False),
-        environments=view.get("environments", []),
-        time_filters=view.get("timeFilters", {"period": "14d"}),
-        visibility=GroupSearchViewVisibility.ORGANIZATION,
-    )
-    if "projects" in view:
-        gsv.projects.set(view["projects"] or [])
-
-    GroupSearchViewStarred.objects.create(
-        organization=org,
-        user_id=user_id,
-        group_search_view=gsv,
-        position=position,
-    )
-    return gsv
-
 
 def pick_default_project(org: Organization, user: User | AnonymousUser) -> int | None:
     user_teams = Team.objects.get_for_user(organization=org, user=user)

src/sentry/issues/endpoints/organization_group_search_views_starred.py

@@ -8,10 +8,8 @@
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
 from sentry.api.bases.organization import OrganizationEndpoint, OrganizationPermission
-from sentry.api.paginator import SequencePaginator
 from sentry.api.serializers import serialize
 from sentry.api.serializers.models.groupsearchviewstarred import GroupSearchViewStarredSerializer
-from sentry.models.groupsearchview import DEFAULT_VIEWS
 from sentry.models.groupsearchviewstarred import GroupSearchViewStarred
 from sentry.models.organization import Organization
 from sentry.models.project import Project
@@ -57,32 +55,6 @@ def get(self, request: Request, organization: Organization) -> Response:
             organization=organization, user_id=request.user.id
         )
 
-        # TODO(msun): Remove when tabbed views are deprecated
-
-        if not starred_views.exists() and not features.has(
-            "organizations:enforce-stacked-navigation", organization
-        ):
-            return self.paginate(
-                request=request,
-                paginator=SequencePaginator(
-                    [
-                        (
-                            idx,
-                            {
-                                **view,
-                                "projects": (
-                                    []
-                                    if has_global_views
-                                    else [pick_default_project(organization, request.user)]
-                                ),
-                            },
-                        )
-                        for idx, view in enumerate(DEFAULT_VIEWS)
-                    ]
-                ),
-                on_results=lambda results: serialize(results, request.user),
-            )
-
         return self.paginate(
             request=request,
             queryset=starred_views,