feat(laravel-insights): Remove experimental UI toggle (#89262)

Remove the experimental UI toggle for Laravel insights.
This will activate the new UI for all users that have the feature flag,
without an option to opt out.

Author: ArthurKnaus

static/app/views/insights/pages/backend/backendOverviewPage.tsx

@@ -1,4 +1,3 @@
-import {Fragment} from 'react';
 import {useTheme} from '@emotion/react';
 import styled from '@emotion/styled';
 
@@ -36,11 +35,7 @@ import {ToolRibbon} from 'sentry/views/insights/common/components/ribbon';
 import {useOnboardingProject} from 'sentry/views/insights/common/queries/useOnboardingProject';
 import {BackendHeader} from 'sentry/views/insights/pages/backend/backendPageHeader';
 import {LaravelOverviewPage} from 'sentry/views/insights/pages/backend/laravel';
-import {
-  hasLaravelInsightsFeature,
-  useIsLaravelInsightsEnabled,
-} from 'sentry/views/insights/pages/backend/laravel/features';
-import {NewLaravelExperienceButton} from 'sentry/views/insights/pages/backend/laravel/newLaravelExperienceButton';
+import {useIsLaravelInsightsAvailable} from 'sentry/views/insights/pages/backend/laravel/features';
 import {
   BACKEND_LANDING_TITLE,
   OVERVIEW_PAGE_ALLOWED_OPS,
@@ -97,8 +92,12 @@ export const BACKEND_COLUMN_TITLES = [
 
 function BackendOverviewPage() {
   useOverviewPageTrackPageload();
-  const [isLaravelPageEnabled] = useIsLaravelInsightsEnabled();
-  return isLaravelPageEnabled ? <LaravelOverviewPage /> : <GenericBackendOverviewPage />;
+  const isLaravelPageAvailable = useIsLaravelInsightsAvailable();
+  return isLaravelPageAvailable ? (
+    <LaravelOverviewPage />
+  ) : (
+    <GenericBackendOverviewPage />
+  );
 }
 
 function GenericBackendOverviewPage() {
@@ -242,14 +241,7 @@ function GenericBackendOverviewPage() {
       organization={organization}
       renderDisabled={NoAccess}
     >
-      <BackendHeader
-        headerTitle={BACKEND_LANDING_TITLE}
-        headerActions={
-          <Fragment>
-            <NewLaravelExperienceButton />
-          </Fragment>
-        }
-      />
+      <BackendHeader headerTitle={BACKEND_LANDING_TITLE} />
       <Layout.Body>
         <Layout.Main fullWidth>
           <ModuleLayout.Layout>
@@ -320,16 +312,12 @@ function GenericBackendOverviewPage() {
 
 function BackendOverviewPageWithProviders() {
   const organization = useOrganization();
-  const [isLaravelInsightsEnabled] = useIsLaravelInsightsEnabled();
+  const isLaravelPageAvailable = useIsLaravelInsightsAvailable();
   const {maxPickableDays} = limitMaxPickableDays(organization);
 
   return (
     <DomainOverviewPageProviders
-      maxPickableDays={
-        isLaravelInsightsEnabled && hasLaravelInsightsFeature(organization)
-          ? maxPickableDays
-          : undefined
-      }
+      maxPickableDays={isLaravelPageAvailable ? maxPickableDays : undefined}
     >
       <BackendOverviewPage />
     </DomainOverviewPageProviders>

static/app/views/insights/pages/backend/laravel/features.tsx

@@ -1,12 +1,8 @@
-import {useCallback} from 'react';
-
 import type {Organization} from 'sentry/types/organization';
 import {getSelectedProjectList} from 'sentry/utils/project/useSelectedProjectsHaveField';
-import useMutateUserOptions from 'sentry/utils/useMutateUserOptions';
 import useOrganization from 'sentry/utils/useOrganization';
 import usePageFilters from 'sentry/utils/usePageFilters';
 import useProjects from 'sentry/utils/useProjects';
-import {useUser} from 'sentry/utils/useUser';
 
 export function hasLaravelInsightsFeature(organization: Organization) {
   return organization.features.includes('laravel-insights');
@@ -25,37 +21,3 @@ export function useIsLaravelInsightsAvailable() {
 
   return hasLaravelInsightsFeature(organization) && isOnlyLaravelSelected;
 }
-
-// It started out as a dictionary of project IDs, but as we now want a global toggle we use a special key
-// to represent all projects. (This user option is a temporary feature and will be removed in the future.)
-const ALL_PROJECTS_KEY = 'all';
-
-export function useIsLaravelInsightsEnabled() {
-  const organization = useOrganization();
-  const user = useUser();
-  const isAvailable = useIsLaravelInsightsAvailable();
-
-  const isEnabled = Boolean(
-    isAvailable &&
-      (user.options.prefersSpecializedProjectOverview[ALL_PROJECTS_KEY] ?? true)
-  );
-
-  const {mutate: mutateUserOptions} = useMutateUserOptions();
-
-  const setIsEnabled = useCallback(
-    (enabled: boolean) => {
-      if (!hasLaravelInsightsFeature(organization)) {
-        return;
-      }
-
-      mutateUserOptions({
-        prefersSpecializedProjectOverview: {
-          [ALL_PROJECTS_KEY]: enabled,
-        },
-      });
-    },
-    [mutateUserOptions, organization]
-  );
-
-  return [isEnabled, setIsEnabled] as const;
-}

static/app/views/insights/pages/backend/laravel/index.tsx

@@ -28,7 +28,6 @@ import {CachesWidget} from 'sentry/views/insights/pages/backend/laravel/cachesWi
 import {DurationWidget} from 'sentry/views/insights/pages/backend/laravel/durationWidget';
 import {IssuesWidget} from 'sentry/views/insights/pages/backend/laravel/issuesWidget';
 import {JobsWidget} from 'sentry/views/insights/pages/backend/laravel/jobsWidget';
-import {NewLaravelExperienceButton} from 'sentry/views/insights/pages/backend/laravel/newLaravelExperienceButton';
 import {PathsTable} from 'sentry/views/insights/pages/backend/laravel/pathsTable';
 import {QueriesWidget} from 'sentry/views/insights/pages/backend/laravel/queriesWidget';
 import {RequestsWidget} from 'sentry/views/insights/pages/backend/laravel/requestsWidget';
@@ -101,7 +100,6 @@ export function LaravelOverviewPage() {
         headerActions={
           <Fragment>
             <ViewTrendsButton />
-            <NewLaravelExperienceButton />
           </Fragment>
         }
       />

static/app/views/insights/pages/backend/laravel/newLaravelExperienceButton.tsx

@@ -23,7 +23,7 @@ import {
   type RoutableModuleNames,
   useModuleURLBuilder,
 } from 'sentry/views/insights/common/utils/useModuleURL';
-import {useIsLaravelInsightsEnabled} from 'sentry/views/insights/pages/backend/laravel/features';
+import {useIsLaravelInsightsAvailable} from 'sentry/views/insights/pages/backend/laravel/features';
 import {OVERVIEW_PAGE_TITLE} from 'sentry/views/insights/pages/settings';
 import {
   isModuleConsideredNew,
@@ -63,7 +63,7 @@ export function DomainViewHeader({
   const location = useLocation();
   const navigate = useNavigate();
   const moduleURLBuilder = useModuleURLBuilder();
-  const [isLaravelInsightsEnabled] = useIsLaravelInsightsEnabled();
+  const isLaravelInsightsAvailable = useIsLaravelInsightsAvailable();
   const useEap = useInsightsEap();
   const hasEapFlag = organization.features.includes('insights-modules-use-eap');
 
@@ -136,7 +136,7 @@ export function DomainViewHeader({
             ) : (
               <FeedbackWidgetButton
                 optionOverrides={
-                  isLaravelInsightsEnabled
+                  isLaravelInsightsAvailable
                     ? {
                         tags: {
                           ['feedback.source']: 'laravel-insights',

static/app/views/insights/pages/domainViewHeader.tsx

@@ -14,7 +14,7 @@ import {
   AI_LANDING_SUB_PATH,
   AI_SIDEBAR_LABEL,
 } from 'sentry/views/insights/pages/ai/settings';
-import {useIsLaravelInsightsEnabled} from 'sentry/views/insights/pages/backend/laravel/features';
+import {useIsLaravelInsightsAvailable} from 'sentry/views/insights/pages/backend/laravel/features';
 import {
   BACKEND_LANDING_SUB_PATH,
   BACKEND_SIDEBAR_LABEL,
@@ -44,7 +44,7 @@ export function InsightsSecondaryNav() {
   const organization = useOrganization();
   const location = useLocation();
   const baseUrl = `/organizations/${organization.slug}/${DOMAIN_VIEW_BASE_URL}`;
-  const [isLaravelInsightsEnabled] = useIsLaravelInsightsEnabled();
+  const isLaravelInsightsAvailable = useIsLaravelInsightsAvailable();
 
   const {projects} = useProjects();
 
@@ -63,7 +63,7 @@ export function InsightsSecondaryNav() {
     return (
       project.platform &&
       platformsUsingOverviewAsProjectDetails.includes(project.platform) &&
-      isLaravelInsightsEnabled
+      isLaravelInsightsAvailable
     );
   }
 
@@ -95,7 +95,7 @@ export function InsightsSecondaryNav() {
                 location.pathname
               ) &&
               // The starred param indicates that the overview is being accessed via the starred projects nav item
-              (!isStarredProjectSelected || !isLaravelInsightsEnabled)
+              (!isStarredProjectSelected || !isLaravelInsightsAvailable)
             }
             to={`${baseUrl}/${BACKEND_LANDING_SUB_PATH}/`}
             analyticsItemName="insights_backend"

static/app/views/nav/secondary/sections/insights/insightsSecondaryNav.tsx

@@ -4,7 +4,7 @@ import useProjects from 'sentry/utils/useProjects';
 import withOrganization from 'sentry/utils/withOrganization';
 import {
   hasLaravelInsightsFeature,
-  useIsLaravelInsightsEnabled,
+  useIsLaravelInsightsAvailable,
 } from 'sentry/views/insights/pages/backend/laravel/features';
 
 import ProjectDetail from './projectDetail';
@@ -17,7 +17,7 @@ function ProjectDetailContainer(
 ) {
   const {organization} = props;
   const {projects} = useProjects();
-  const [isLaravelInsightsEnabled] = useIsLaravelInsightsEnabled();
+  const isLaravelInsightsAvailable = useIsLaravelInsightsAvailable();
 
   const project = projects.find(p => p.slug === props.params.projectId);
   useRouteAnalyticsParams(
@@ -32,7 +32,7 @@ function ProjectDetailContainer(
   if (
     project?.platform === 'php-laravel' &&
     hasLaravelInsightsFeature(organization) &&
-    isLaravelInsightsEnabled
+    isLaravelInsightsAvailable
   ) {
     return (
       <Redirect