feat: enable typescript biome rules (#69534)

anonrig · getsantry[bot] · web-flow · commit 9952d7f6bf31 · 2024-04-23T20:44:32.000Z
We weren't leveraging enough Typescript rules. Adding these caught
some...

---------

Co-authored-by: getsantry[bot] &lt;66042841+getsantry[bot]@users.noreply.github.com&gt;
diff --git a/biome.json b/biome.json
@@ -21,13 +21,17 @@
         "noUnreachable": "error",
         "useHookAtTopLevel": "error",
         "useIsNan": "error",
-        "noUnusedPrivateClassMembers": "error"
+        "noUnusedPrivateClassMembers": "error",
+        "noInvalidUseBeforeDeclaration": "error"
       },
       "complexity": {
         "useFlatMap": "error",
         "useOptionalChain": "error",
         "noEmptyTypeParameters": "error",
-        "noUselessLoneBlockStatements": "error"
+        "noUselessLoneBlockStatements": "error",
+        "noUselessEmptyExport": "error",
+        "noUselessConstructor": "error",
+        "noUselessTypeConstraint": "error"
       },
       "nursery": {
         "noDuplicateJsonKeys": "error",
@@ -53,7 +57,9 @@
         "noUnsafeNegation": "error",
         "useIsArray": "error",
         "noApproximativeNumericConstant": "error",
-        "noMisrefactoredShorthandAssign": "error"
+        "noMisrefactoredShorthandAssign": "error",
+        "useAwait": "error",
+        "useNamespaceKeyword": "error"
       },
       "style": {
         "noCommaOperator": "error",
@@ -64,7 +70,10 @@
         "useShorthandFunctionType": "error",
         "useExportType": "error",
         "useImportType": "error",
-        "useNodejsImportProtocol": "error"
+        "useNodejsImportProtocol": "error",
+        "useLiteralEnumMembers": "error",
+        "useEnumInitializers": "error",
+        "useAsConstAssertion": "error"
       }
     }
   },
@@ -108,12 +117,7 @@
   },
   "overrides": [
     {
-      "include": [
-        "biome.json",
-        "config/tsconfig.*",
-        "tsconfig.json",
-        ".vscode/*"
-      ],
+      "include": ["biome.json", "config/tsconfig.*", "tsconfig.json", ".vscode/*"],
       "json": {
         "parser": {
           "allowComments": true,
diff --git a/static/app/components/customIgnoreCountModal.tsx b/static/app/components/customIgnoreCountModal.tsx
@@ -66,7 +66,7 @@ class CustomIgnoreCountModal extends Component<Props, State> {
             label={countLabel}
             name="count"
             value={count}
-            onChange={val => this.handleChange('count' as 'count', Number(val))}
+            onChange={val => this.handleChange('count' as const, Number(val))}
             required
             placeholder={t('e.g. 100')}
           />
diff --git a/static/app/components/events/interfaces/spans/dragManager.tsx b/static/app/components/events/interfaces/spans/dragManager.tsx
@@ -10,8 +10,8 @@ import {setBodyUserSelect} from 'sentry/utils/userselect';
 const MINIMUM_WINDOW_SIZE = 0.5 / 100; // 0.5% window size
 
 enum ViewHandleType {
-  LEFT,
-  RIGHT,
+  LEFT = 0,
+  RIGHT = 1,
 }
 
 export type DragManagerChildrenProps = {
diff --git a/static/app/components/events/interfaces/spans/types.tsx b/static/app/components/events/interfaces/spans/types.tsx
@@ -208,9 +208,9 @@ export type ParsedTraceType = {
 };
 
 export enum TickAlignment {
-  LEFT,
-  RIGHT,
-  CENTER,
+  LEFT = 0,
+  RIGHT = 1,
+  CENTER = 2,
 }
 
 export type TraceContextType = {
@@ -263,15 +263,15 @@ export type DescendantGroup = {
 };
 
 export enum GroupType {
-  DESCENDANTS,
-  SIBLINGS,
+  DESCENDANTS = 0,
+  SIBLINGS = 1,
 }
 
 export enum SpanTreeNodeType {
-  SPAN,
-  DESCENDANT_GROUP,
-  SIBLING_GROUP,
-  MESSAGE,
+  SPAN = 0,
+  DESCENDANT_GROUP = 1,
+  SIBLING_GROUP = 2,
+  MESSAGE = 3,
 }
 
 type SpanBarNode = {
diff --git a/static/app/data/platformCategories.tsx b/static/app/data/platformCategories.tsx
@@ -1,12 +1,12 @@
 import type {PlatformKey} from 'sentry/types/project';
 
 export enum PlatformCategory {
-  FRONTEND,
-  MOBILE,
-  BACKEND,
-  SERVERLESS,
-  DESKTOP,
-  OTHER,
+  FRONTEND = 0,
+  MOBILE = 1,
+  BACKEND = 2,
+  SERVERLESS = 3,
+  DESKTOP = 4,
+  OTHER = 5,
 }
 
 // Mirrors `FRONTEND` in src/sentry/utils/platform_categories.py
diff --git a/static/app/gettingStartedDocs/dotnet/dotnet.tsx b/static/app/gettingStartedDocs/dotnet/dotnet.tsx
@@ -54,8 +54,8 @@ dotnet add package Sentry.Profiling -v ${getPackageVersion(
 )}`;
 
 enum DotNetPlatform {
-  WINDOWS,
-  IOS_MACCATALYST,
+  WINDOWS = 0,
+  IOS_MACCATALYST = 1,
 }
 
 const getConfigureSnippet = (params: Params, platform?: DotNetPlatform) => `
diff --git a/static/app/gettingStartedDocs/dotnet/maui.tsx b/static/app/gettingStartedDocs/dotnet/maui.tsx
@@ -50,8 +50,8 @@ dotnet add package Sentry.Profiling -v ${getPackageVersion(
 )}`;
 
 enum DotNetPlatform {
-  WINDOWS,
-  IOS_MACCATALYST,
+  WINDOWS = 0,
+  IOS_MACCATALYST = 1,
 }
 
 const getConfigureSnippet = (params: Params, platform?: DotNetPlatform) => `
diff --git a/static/app/utils/crashReports.tsx b/static/app/utils/crashReports.tsx
@@ -23,8 +23,8 @@ export function formatStoreCrashReports(
 }
 
 export enum SettingScope {
-  ORGANIZATION,
-  PROJECT,
+  ORGANIZATION = 0,
+  PROJECT = 1,
 }
 export function getStoreCrashReportsValues(settingScope: SettingScope) {
   const values: Array<number | null> = [
diff --git a/static/app/utils/performance/contexts/pageAlert.tsx b/static/app/utils/performance/contexts/pageAlert.tsx
@@ -9,7 +9,7 @@ import {useLocalStorageState} from 'sentry/utils/useLocalStorageState';
 type PageAlertType = keyof Theme['alert'];
 
 export enum DismissId {
-  RESOURCE_SIZE_ALERT,
+  RESOURCE_SIZE_ALERT = 0,
 }
 
 export type PageAlertOptions = {
diff --git a/static/app/utils/profiling/fzf/fzf.ts b/static/app/utils/profiling/fzf/fzf.ts
@@ -41,10 +41,10 @@ const bonusConsecutive = -(scoreGapStart + scoreGapExtention);
 const bonusFirstCharMultiplier = 2;
 
 enum CharTypes {
-  CHAR_LOWER,
-  CHAR_UPPER,
-  CHAR_NUMBER,
-  CHAR_NON_WORD,
+  CHAR_LOWER = 0,
+  CHAR_UPPER = 1,
+  CHAR_NUMBER = 2,
+  CHAR_NON_WORD = 3,
 }
 
 const CharCodes = {
diff --git a/static/app/utils/replays/timer.tsx b/static/app/utils/replays/timer.tsx
@@ -10,10 +10,6 @@ export class Timer extends EventTarget {
   private _additionalTime: number = 0;
   private _callbacks: Map<number, (() => void)[]> = new Map();
 
-  constructor() {
-    super();
-  }
-
   step = () => {
     if (!this._active) {
       return;
diff --git a/static/app/utils/tokenizeSearch.tsx b/static/app/utils/tokenizeSearch.tsx
@@ -8,9 +8,9 @@ export const ALLOWED_WILDCARD_FIELDS = [
 export const EMPTY_OPTION_VALUE = '(empty)' as const;
 
 export enum TokenType {
-  OPERATOR,
-  FILTER,
-  FREE_TEXT,
+  OPERATOR = 0,
+  FILTER = 1,
+  FREE_TEXT = 2,
 }
 
 export type Token = {
diff --git a/static/app/views/alerts/rules/metric/types.tsx b/static/app/views/alerts/rules/metric/types.tsx
@@ -6,8 +6,8 @@ import type {SchemaFormConfig} from 'sentry/views/settings/organizationIntegrati
 import type {Incident} from '../../types';
 
 export enum AlertRuleThresholdType {
-  ABOVE,
-  BELOW,
+  ABOVE = 0,
+  BELOW = 1,
 }
 
 export enum AlertRuleTriggerType {
diff --git a/static/app/views/discover/table/columnEditCollection.tsx b/static/app/views/discover/table/columnEditCollection.tsx
@@ -71,8 +71,8 @@ const GHOST_PADDING = 4;
 const MAX_COL_COUNT = 20;
 
 enum PlaceholderPosition {
-  TOP,
-  BOTTOM,
+  TOP = 0,
+  BOTTOM = 1,
 }
 
 class ColumnEditCollection extends Component<Props, State> {
diff --git a/static/app/views/issueList/utils.tsx b/static/app/views/issueList/utils.tsx
@@ -5,6 +5,7 @@ import type {Organization} from 'sentry/types/organization';
 
 export enum Query {
   FOR_REVIEW = 'is:unresolved is:for_review assigned_or_suggested:[me, my_teams, none]',
+  // biome-ignore lint/style/useLiteralEnumMembers: Disable for maintenance cost.
   PRIORITIZED = NEW_DEFAULT_QUERY,
   UNRESOLVED = 'is:unresolved',
   IGNORED = 'is:ignored',
diff --git a/static/app/views/performance/cache/referrers.ts b/static/app/views/performance/cache/referrers.ts
@@ -1,6 +1,4 @@
-const PREFIX = `api.performance.cache`;
-
 export enum Referrer {
-  LANDING_CACHE_HIT_MISS_CHART = `${PREFIX}.landing-cache-hit-miss-chart`,
-  LANDING_CACHE_THROUGHPUT_CHART = `${PREFIX}.landing-cache-throughput-chart`,
+  LANDING_CACHE_HIT_MISS_CHART = `api.performance.cache.landing-cache-hit-miss-chart`,
+  LANDING_CACHE_THROUGHPUT_CHART = `api.performance.cache.landing-cache-throughput-chart`,
 }
diff --git a/static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx b/static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx
@@ -1356,7 +1356,7 @@ export class TraceTreeNode<T extends TraceTree.NodeValue = TraceTree.NodeValue>
 
   profiles: TraceTree.Profile[] = [];
 
-  private unit: 'milliseconds' = 'milliseconds';
+  private unit = 'milliseconds' as const;
   private _depth: number | undefined;
   private _children: TraceTreeNode[] = [];
   private _spanChildren: TraceTreeNode[] = [];
diff --git a/static/app/views/projectInstall/issueAlertOptions.tsx b/static/app/views/projectInstall/issueAlertOptions.tsx
@@ -15,14 +15,14 @@ import type {Organization} from 'sentry/types/organization';
 import withOrganization from 'sentry/utils/withOrganization';
 
 export enum MetricValues {
-  ERRORS,
-  USERS,
+  ERRORS = 0,
+  USERS = 1,
 }
 
 export enum RuleAction {
-  DEFAULT_ALERT,
-  CUSTOMIZED_ALERTS,
-  CREATE_ALERT_LATER,
+  DEFAULT_ALERT = 0,
+  CUSTOMIZED_ALERTS = 1,
+  CREATE_ALERT_LATER = 2,
 }
 
 const ISSUE_ALERT_DEFAULT_ACTION: Omit<
diff --git a/static/app/views/relocation/relocation.tsx b/static/app/views/relocation/relocation.tsx
@@ -72,9 +72,9 @@ function getRelocationOnboardingSteps(): StepDescriptor[] {
 }
 
 enum LoadingState {
-  FETCHED,
-  FETCHING,
-  ERROR,
+  FETCHED = 0,
+  FETCHING = 1,
+  ERROR = 2,
 }
 
 function RelocationOnboarding(props: Props) {
diff --git a/static/app/views/settings/projectSourceMaps/projectSourceMaps.tsx b/static/app/views/settings/projectSourceMaps/projectSourceMaps.tsx
@@ -43,8 +43,8 @@ enum SortBy {
 }
 
 enum SourceMapsBundleType {
-  RELEASE,
-  DEBUG_ID,
+  RELEASE = 0,
+  DEBUG_ID = 1,
 }
 
 function SourceMapsTableRow({
diff --git a/static/app/views/starfish/components/chart.tsx b/static/app/views/starfish/components/chart.tsx
@@ -72,9 +72,9 @@ export const STARFISH_FIELDS: Record<string, {outputType: AggregationOutputType}
 };
 
 export enum ChartType {
-  BAR,
-  LINE,
-  AREA,
+  BAR = 0,
+  LINE = 1,
+  AREA = 2,
 }
 
 type Props = {
diff --git a/static/app/views/starfish/utils/sqlish/SQLishParser.ts b/static/app/views/starfish/utils/sqlish/SQLishParser.ts
@@ -3,8 +3,6 @@ import type {Token} from 'sentry/views/starfish/utils/sqlish/types';
 import grammar from './sqlish.pegjs';
 
 export class SQLishParser {
-  constructor() {}
-
   parse(sql: string) {
     return grammar.parse(sql) as Token[];
   }
diff --git a/static/app/views/starfish/views/screens/index.tsx b/static/app/views/starfish/views/screens/index.tsx
@@ -49,14 +49,14 @@ import {
 } from 'sentry/views/starfish/views/screens/utils';
 
 export enum YAxis {
-  WARM_START,
-  COLD_START,
-  TTID,
-  TTFD,
-  SLOW_FRAME_RATE,
-  FROZEN_FRAME_RATE,
-  THROUGHPUT,
-  COUNT,
+  WARM_START = 0,
+  COLD_START = 1,
+  TTID = 2,
+  TTFD = 3,
+  SLOW_FRAME_RATE = 4,
+  FROZEN_FRAME_RATE = 5,
+  THROUGHPUT = 6,
+  COUNT = 7,
 }
 
 export const TOP_SCREENS = 5;
diff --git a/static/app/views/starfish/views/screens/screenLoadSpans/charts.tsx b/static/app/views/starfish/views/screens/screenLoadSpans/charts.tsx
@@ -46,14 +46,14 @@ import {
 } from 'sentry/views/starfish/views/screens/utils';
 
 export enum YAxis {
-  WARM_START,
-  COLD_START,
-  TTID,
-  TTFD,
-  SLOW_FRAME_RATE,
-  FROZEN_FRAME_RATE,
-  THROUGHPUT,
-  COUNT,
+  WARM_START = 0,
+  COLD_START = 1,
+  TTID = 2,
+  TTFD = 3,
+  SLOW_FRAME_RATE = 4,
+  FROZEN_FRAME_RATE = 5,
+  THROUGHPUT = 6,
+  COUNT = 7,
 }
 
 type Props = {
diff --git a/tests/js/setup.ts b/tests/js/setup.ts
@@ -226,7 +226,6 @@ window.IntersectionObserver = class IntersectionObserver {
   thresholds = [];
   takeRecords = jest.fn();
 
-  constructor() {}
   observe() {}
   unobserve() {}
   disconnect() {}

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,8 @@ import {setBodyUserSelect} from 'sentry/utils/userselect';`
`10`	`10`	`const MINIMUM_WINDOW_SIZE = 0.5 / 100; // 0.5% window size`
`11`	`11`
`12`	`12`	`enum ViewHandleType {`
`13`		`- LEFT,`
`14`		`- RIGHT,`
	`13`	`+ LEFT = 0,`
	`14`	`+ RIGHT = 1,`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`export type DragManagerChildrenProps = {`
Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,8 @@ dotnet add package Sentry.Profiling -v ${getPackageVersion(`
`54`	`54`	)}`;
`55`	`55`
`56`	`56`	`enum DotNetPlatform {`
`57`		`- WINDOWS,`
`58`		`- IOS_MACCATALYST,`
	`57`	`+ WINDOWS = 0,`
	`58`	`+ IOS_MACCATALYST = 1,`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	const getConfigureSnippet = (params: Params, platform?: DotNetPlatform) => `
Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,8 @@ dotnet add package Sentry.Profiling -v ${getPackageVersion(`
`50`	`50`	)}`;
`51`	`51`
`52`	`52`	`enum DotNetPlatform {`
`53`		`- WINDOWS,`
`54`		`- IOS_MACCATALYST,`
	`53`	`+ WINDOWS = 0,`
	`54`	`+ IOS_MACCATALYST = 1,`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	const getConfigureSnippet = (params: Params, platform?: DotNetPlatform) => `
Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,8 @@ export function formatStoreCrashReports(`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`export enum SettingScope {`
`26`		`- ORGANIZATION,`
`27`		`- PROJECT,`
	`26`	`+ ORGANIZATION = 0,`
	`27`	`+ PROJECT = 1,`
`28`	`28`	`}`
`29`	`29`	`export function getStoreCrashReportsValues(settingScope: SettingScope) {`
`30`	`30`	`const values: Array<number \| null> = [`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ import {useLocalStorageState} from 'sentry/utils/useLocalStorageState';`
`9`	`9`	`type PageAlertType = keyof Theme['alert'];`
`10`	`10`
`11`	`11`	`export enum DismissId {`
`12`		`- RESOURCE_SIZE_ALERT,`
	`12`	`+ RESOURCE_SIZE_ALERT = 0,`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`export type PageAlertOptions = {`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,8 @@ import type {SchemaFormConfig} from 'sentry/views/settings/organizationIntegrati`
`6`	`6`	`import type {Incident} from '../../types';`
`7`	`7`
`8`	`8`	`export enum AlertRuleThresholdType {`
`9`		`- ABOVE,`
`10`		`- BELOW,`
	`9`	`+ ABOVE = 0,`
	`10`	`+ BELOW = 1,`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`export enum AlertRuleTriggerType {`
Original file line number	Diff line number	Diff line change
`@@ -71,8 +71,8 @@ const GHOST_PADDING = 4;`
`71`	`71`	`const MAX_COL_COUNT = 20;`
`72`	`72`
`73`	`73`	`enum PlaceholderPosition {`
`74`		`- TOP,`
`75`		`- BOTTOM,`
	`74`	`+ TOP = 0,`
	`75`	`+ BOTTOM = 1,`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`class ColumnEditCollection extends Component<Props, State> {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,4 @@`
`1`		-const PREFIX = `api.performance.cache`;
`2`		`-`
`3`	`1`	`export enum Referrer {`
`4`		- LANDING_CACHE_HIT_MISS_CHART = `${PREFIX}.landing-cache-hit-miss-chart`,
`5`		- LANDING_CACHE_THROUGHPUT_CHART = `${PREFIX}.landing-cache-throughput-chart`,
	`2`	+ LANDING_CACHE_HIT_MISS_CHART = `api.performance.cache.landing-cache-hit-miss-chart`,
	`3`	+ LANDING_CACHE_THROUGHPUT_CHART = `api.performance.cache.landing-cache-throughput-chart`,
`6`	`4`	`}`
Original file line number	Diff line number	Diff line change
`@@ -72,9 +72,9 @@ function getRelocationOnboardingSteps(): StepDescriptor[] {`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`enum LoadingState {`
`75`		`- FETCHED,`
`76`		`- FETCHING,`
`77`		`- ERROR,`
	`75`	`+ FETCHED = 0,`
	`76`	`+ FETCHING = 1,`
	`77`	`+ ERROR = 2,`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`function RelocationOnboarding(props: Props) {`
Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,8 @@ enum SortBy {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`enum SourceMapsBundleType {`
`46`		`- RELEASE,`
`47`		`- DEBUG_ID,`
	`46`	`+ RELEASE = 0,`
	`47`	`+ DEBUG_ID = 1,`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`function SourceMapsTableRow({`