Skip to content

Commit 9b9e176

Browse files
committed
leave a comment for future me
1 parent be231dc commit 9b9e176

File tree

1 file changed

+3
-0
lines changed
  • src/sentry/workflow_engine/handlers/detector

1 file changed

+3
-0
lines changed

src/sentry/workflow_engine/handlers/detector/stateful.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -379,6 +379,9 @@ def _has_breached_threshold(
379379
self,
380380
updated_threshold_counts: DetectorCounters,
381381
) -> DetectorPriorityLevel | None:
382+
# TODO @saponifi3d - Should this only be for thresholds configured on the detector?
383+
# If so, gather the self.detector.when_condition_group.conditions()
384+
# and see which ones are configured.
382385
threshold_keys: list[DetectorPriorityLevel] = list(self._thresholds.keys())
383386
threshold_keys.sort(reverse=True)
384387
for level in threshold_keys:

0 commit comments

Comments
 (0)