refactor(slack): Code cleanup

Author: ykamo001

src/sentry/notifications/utils/actions.py

@@ -5,40 +5,34 @@
 from typing import Any, Literal
 
 
-@dataclass
-class MessageAction:
-    name: str
-
-    # Optional label. This falls back to name.
-    label: str | None = None
+@dataclass(kw_only=True)
+class _BaseMessageAction:
+    """
+    Base class used to hold the fields for a notification message action.
+    TODO(ecosystem): this class seems to only be used for Slack notifications, can we move this?
+    """
 
+    name: str
     type: Literal["button", "select"] = "button"
-
-    # If this is a button type, a url is required.
+    # If the message action is a button type, the url is required
     url: str | None = None
-
-    # If this is a select type, the selected value.
+    # If the message action is a select type, this is the selected value
     value: str | None = None
-
     # Denotes the type of action
     action_id: str | None = None
+    block_id: str | None = None
+    selected_options: Sequence[Mapping[str, Any]] | None = None
 
-    style: Literal["primary", "danger", "default"] | None = None
 
-    # TODO(mgaeta): Refactor this to be provider-agnostic
-    selected_options: Sequence[Mapping[str, Any]] | None = None
+@dataclass
+class MessageAction(_BaseMessageAction):
+    # Label is optional, if empty it falls back to name
+    label: str | None = None
+    style: Literal["primary", "danger", "default"] | None = None
     option_groups: Sequence[Mapping[str, Any]] | None = None
-    block_id: str | None = None
     elements: Sequence[Mapping[str, Any]] | None = None
 
 
 @dataclass
-class BlockKitMessageAction:
-    name: str
+class BlockKitMessageAction(_BaseMessageAction):
     label: str
-    type: Literal["button", "select"] = "button"
-    url: str | None = None
-    value: str | None = None
-    action_id: str | None = None
-    block_id: str | None = None
-    selected_options: Sequence[Mapping[str, Any]] | None = None