remove stuff from old pr

Author: JoshFerge

pyproject.toml

@@ -66,7 +66,6 @@ warn_unused_ignores = true
 warn_redundant_casts = true
 enable_error_code = ["ignore-without-code"]
 
-
 [tool.django-stubs]
 django_settings_module = "sentry.conf.server_mypy"
 
@@ -258,7 +257,6 @@ module = [
     "sentry.auth.providers.saml2.views",
     "sentry.auth.system",
     "sentry.auth.view",
-    "sentry.buffer.redis",
     "sentry.db.mixin",
     "sentry.db.models.manager.base",
     "sentry.db.models.paranoia",
@@ -407,7 +405,6 @@ module = [
     "sentry.plugins.providers.repository",
     "sentry.profiles.task",
     "sentry.profiles.utils",
-    "sentry.quotas.redis",
     "sentry.receivers.releases",
     "sentry.receivers.sentry_apps",
     "sentry.release_health.metrics_sessions_v2",
@@ -589,14 +586,10 @@ module = [
     "tests.sentry.ingest.test_slicing",
     "tests.sentry.integrations.github.test_client",
     "tests.sentry.integrations.slack.test_requests",
-    "tests.sentry.issues.endpoints.test_group_events",
-    "tests.sentry.issues.endpoints.test_organization_group_index",
     "tests.sentry.issues.test_utils",
     "tests.sentry.models.test_organizationmember",
     "tests.sentry.replays.test_project_replay_recording_segment_index",
-    "tests.sentry.tasks.test_daily_summary",
     "tests.sentry.tasks.test_post_process",
-    "tools.mypy_helpers.make_module_ignores",
 ]
 disable_error_code = [
     "arg-type",
@@ -611,7 +604,6 @@ disable_error_code = [
     "misc",
     "operator",
     "override",
-    "possibly-undefined",
     "return-value",
     "typeddict-item",
     "typeddict-unknown-key",

src/sentry/issues/grouptype.py

@@ -49,7 +49,6 @@ def add(self, group_type: type[GroupType]) -> None:
             raise ValueError(
                 f"A group type with the type_id {group_type.type_id} has already been registered."
             )
-
         self._registry[group_type.type_id] = group_type
         self._slug_lookup[group_type.slug] = group_type
         self._category_lookup[group_type.category].add(group_type.type_id)

src/sentry/issues/ingest.py

@@ -137,6 +137,7 @@ def materialize_metadata(occurrence: IssueOccurrence, event: Event) -> Occurrenc
     event_metadata["title"] = occurrence.issue_title
     event_metadata["value"] = occurrence.subtitle
     event_metadata["initial_priority"] = occurrence.initial_issue_priority
+
     if occurrence.type == FeedbackGroup:
         # TODO: Should feedbacks be their own event type, so above call to event.get_event_medata
         # could populate this instead?
@@ -198,14 +199,14 @@ def save_issue_from_occurrence(
             metrics.incr("issues.issue.dropped.rate_limiting")
             return None
 
-        with (
-            sentry_sdk.start_span(op="issues.save_issue_from_occurrence.transaction") as span,
-            metrics.timer(
-                "issues.save_issue_from_occurrence.transaction",
-                tags={"platform": event.platform or "unknown", "type": occurrence.type.type_id},
-                sample_rate=1.0,
-            ) as metric_tags,
-            transaction.atomic(router.db_for_write(GroupHash)),
+        with sentry_sdk.start_span(
+            op="issues.save_issue_from_occurrence.transaction"
+        ) as span, metrics.timer(
+            "issues.save_issue_from_occurrence.transaction",
+            tags={"platform": event.platform or "unknown", "type": occurrence.type.type_id},
+            sample_rate=1.0,
+        ) as metric_tags, transaction.atomic(
+            router.db_for_write(GroupHash)
         ):
             group, is_new = _save_grouphash_and_group(
                 project, event, new_grouphash, **cast(Mapping[str, Any], issue_kwargs)

tools/mypy_helpers/make_module_ignores.py

@@ -57,51 +57,6 @@ def main() -> int:
     with open("pyproject.toml", "w") as f:
         f.write(before + begin + generated + end + rest)
 
-    # # begin possibly_undefined fixer
-    shutil.rmtree(".mypy_cache", ignore_errors=True)
-
-    codes = set()
-    filenames = set()
-    out = subprocess.run(
-        (
-            sys.executable,
-            "-m",
-            "tools.mypy_helpers.mypy_without_ignore_possibly_undefined",
-            *sys.argv[1:],
-        ),
-        capture_output=True,
-    )
-    for line in out.stdout.decode().splitlines():
-        filename, _, _ = line.partition(":")
-        if filename.endswith(".py"):
-            filenames.add(filename)
-        if match is not None:
-            codes.add(match[1])
-
-    os.makedirs(".artifacts", exist_ok=True)
-    with open(".artifacts/mypy-all", "wb") as f:
-        f.write(out.stdout)
-
-    mods = []
-    for filename in sorted(filenames):
-        # TODO: removeprefix / removesuffix python 3.9+
-        if filename.endswith(".py"):
-            filename = filename[: -len(".py")]
-        if filename.startswith("src/"):
-            filename = filename[len("src/") :]
-        if filename.endswith("/__init__"):
-            filename = filename[: -len("/__init__")]
-        mods.append(filename.replace("/", "."))
-    mods_s = "".join(f'    "{mod}",\n' for mod in mods)
-    generated = f"[[tool.mypy.overrides]]\n" f"module = [\n{mods_s}]\n"
-    with open("pyproject.toml") as f:
-        src = f.read()
-        msg = "sentry modules with possibly undefined variables"
-        before, begin, rest = src.partition(f"# begin: {msg}\n")
-        _, end, rest = rest.partition(f"# end: {msg}\n")
-    with open("pyproject.toml", "w") as f:
-        f.write(before + begin + generated + end + rest)
-
     return 0