Skip to content

Commit a909e82

Browse files
perf: avoid using sentry/types in some places (#69101)
A small patch to remove the usages of `sentry/types` in some of the places, but not all. There are currently 1200 more usages left Using `sentry/types` and other barrel files have performance impact. For a more detailed explanation, check out https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-7/ --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
1 parent 10f9c3f commit a909e82

File tree

554 files changed

+616
-577
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

554 files changed

+616
-577
lines changed

fixtures/js-stubs/accessRequest.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {MemberFixture} from 'sentry-fixture/member';
22
import {TeamFixture} from 'sentry-fixture/team';
33

4-
import {AccessRequest} from 'sentry/types';
4+
import type {AccessRequest} from 'sentry/types/organization';
55

66
export function AccessRequestFixture(params: Partial<AccessRequest> = {}): AccessRequest {
77
return {

fixtures/js-stubs/accountEmails.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {UserEmail} from 'sentry/types';
1+
import type {UserEmail} from 'sentry/types/user';
22

33
export function AccountEmailsFixture(params: UserEmail[] = []): UserEmail[] {
44
return [

fixtures/js-stubs/activityFeed.tsx

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,9 @@ import {EventFixture} from 'sentry-fixture/event';
22
import {ProjectFixture} from 'sentry-fixture/project';
33
import {UserFixture} from 'sentry-fixture/user';
44

5-
import {
6-
type Activity,
7-
EventOrGroupType,
8-
GroupActivityType,
9-
IssueCategory,
10-
IssueType,
11-
} from 'sentry/types';
5+
import {EventOrGroupType} from 'sentry/types/event';
6+
import type {Activity} from 'sentry/types/group';
7+
import {GroupActivityType, IssueCategory, IssueType} from 'sentry/types/group';
128

139
export function ActivityFeedFixture(params: Partial<Activity> = {}): Activity {
1410
return {

fixtures/js-stubs/actor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {Actor} from 'sentry/types';
1+
import type {Actor} from 'sentry/types/core';
22

33
export function ActorFixture(params: Partial<Actor> = {}): Actor {
44
return {

fixtures/js-stubs/apiApplication.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {ApiApplication} from 'sentry/types';
1+
import type {ApiApplication} from 'sentry/types/user';
22

33
export function ApiApplicationFixture(
44
params: Partial<ApiApplication> = {}

fixtures/js-stubs/apiToken.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {NewInternalAppApiToken} from 'sentry/types';
1+
import type {NewInternalAppApiToken} from 'sentry/types/user';
22

33
export function ApiTokenFixture(
44
params: Partial<NewInternalAppApiToken> = {}

fixtures/js-stubs/auditLogs.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {UserFixture} from 'sentry-fixture/user';
22

3-
import type {AuditLog} from 'sentry/types';
3+
import type {AuditLog} from 'sentry/types/organization';
44

55
export function AuditLogsFixture(params: AuditLog[] = []): AuditLog[] {
66
return [

fixtures/js-stubs/authProvider.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {AuthProvider} from 'sentry/types';
1+
import type {AuthProvider} from 'sentry/types/auth';
22

33
export function AuthProviderFixture(params: Partial<AuthProvider> = {}): AuthProvider {
44
return {

fixtures/js-stubs/authProviders.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {AuthProviderFixture} from 'sentry-fixture/authProvider';
22

3-
import type {AuthProvider} from 'sentry/types';
3+
import type {AuthProvider} from 'sentry/types/auth';
44

55
export function AuthProvidersFixture(params: AuthProvider[] = []): AuthProvider[] {
66
return [

fixtures/js-stubs/authenticators.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import type {
44
TotpAuthenticator,
55
U2fAuthenticator,
66
UserEnrolledAuthenticator,
7-
} from 'sentry/types';
7+
} from 'sentry/types/auth';
88

99
export function AuthenticatorsFixture(): {
1010
Recovery: (props?: Partial<RecoveryAuthenticator>) => RecoveryAuthenticator;

fixtures/js-stubs/availableNotificationActions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {AvailableNotificationAction} from 'sentry/types';
1+
import type {AvailableNotificationAction} from 'sentry/types/notificationActions';
22

33
export function AvailableNotificationActionsFixture(
44
params: AvailableNotificationAction[] = []

fixtures/js-stubs/broadcast.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {Broadcast} from 'sentry/types';
1+
import type {Broadcast} from 'sentry/types/system';
22

33
export function BroadcastFixture(params: Partial<Broadcast> = {}): Broadcast {
44
return {

fixtures/js-stubs/builtInSymbolSources.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {BuiltinSymbolSource} from 'sentry/types';
1+
import type {BuiltinSymbolSource} from 'sentry/types/debugFiles';
22

33
export function BuiltInSymbolSourcesFixture(
44
params: BuiltinSymbolSource[] = []

fixtures/js-stubs/codeOwner.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@ import {ProjectFixture} from 'sentry-fixture/project';
33
import {RepositoryFixture} from 'sentry-fixture/repository';
44
import {RepositoryProjectPathConfigFixture} from 'sentry-fixture/repositoryProjectPathConfig';
55

6-
import type {CodeOwner, OrganizationIntegration, Project, Repository} from 'sentry/types';
6+
import type {
7+
CodeOwner,
8+
OrganizationIntegration,
9+
Repository,
10+
} from 'sentry/types/integrations';
11+
import type {Project} from 'sentry/types/project';
712

813
interface CodeOwnerParams extends Partial<CodeOwner> {
914
integration?: OrganizationIntegration;

fixtures/js-stubs/commit.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {CommitAuthorFixture} from 'sentry-fixture/commitAuthor';
22
import {RepositoryFixture} from 'sentry-fixture/repository';
33

4-
import type {Commit} from 'sentry/types';
4+
import type {Commit} from 'sentry/types/integrations';
55

66
export function CommitFixture(params: Partial<Commit> = {}): Commit {
77
return {

fixtures/js-stubs/commitAuthor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {User} from 'sentry/types';
1+
import {User} from 'sentry/types/user';
22

33
export function CommitAuthorFixture(params: Partial<User> = {}): User {
44
return {

fixtures/js-stubs/config.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {UserFixture} from 'sentry-fixture/user';
22

3-
import type {Config} from 'sentry/types';
3+
import type {Config} from 'sentry/types/system';
44

55
export function ConfigFixture(params: Partial<Config> = {}): Config {
66
return {

fixtures/js-stubs/debugFile.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import {type DebugFile, DebugFileFeature, DebugFileType} from 'sentry/types';
1+
import type {DebugFile} from 'sentry/types/debugFiles';
2+
import {DebugFileFeature, DebugFileType} from 'sentry/types/debugFiles';
23

34
export function DebugFileFixture(params = {}): DebugFile {
45
return {

fixtures/js-stubs/discover.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {SavedQuery} from 'sentry/types';
1+
import type {SavedQuery} from 'sentry/types/organization';
22

33
export function DiscoverSavedQueryFixture(params = {}): SavedQuery {
44
return {

fixtures/js-stubs/docIntegration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {type DocIntegration} from 'sentry/types';
1+
import type {DocIntegration} from 'sentry/types/integrations';
22

33
export function DocIntegrationFixture(params = {}): DocIntegration {
44
return {

fixtures/js-stubs/entries.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {EventEntryFixture} from 'sentry-fixture/eventEntry';
22

3-
import {type Entry, EntryType} from 'sentry/types';
3+
import {type Entry, EntryType} from 'sentry/types/event';
44

55
export function Entries123Target(): Entry[] {
66
return [

fixtures/js-stubs/environments.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {Environment} from 'sentry/types';
1+
import {Environment} from 'sentry/types/project';
22

33
export function EnvironmentsFixture(): Environment[] {
44
return [

fixtures/js-stubs/event.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {type Event, EventOrGroupType, EventTransaction} from 'sentry/types';
1+
import {type Event, EventOrGroupType, EventTransaction} from 'sentry/types/event';
22

33
export function EventFixture(params = {}): Event {
44
return {

fixtures/js-stubs/eventAttachment.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {EventAttachment} from 'sentry/types';
1+
import type {EventAttachment} from 'sentry/types/group';
22

33
export function EventAttachmentFixture(params = {}): EventAttachment {
44
return {

fixtures/js-stubs/eventEntry.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
import {ImageFixture} from 'sentry-fixture/image';
22

3-
import {
4-
type Entry,
5-
type EntryDebugMeta,
6-
type EntryRequest,
7-
EntryType,
8-
} from 'sentry/types';
3+
import type {Entry, EntryDebugMeta, EntryRequest} from 'sentry/types/event';
4+
import {EntryType} from 'sentry/types/event';
95

106
export function EventEntryFixture(params = {}): Entry {
117
return {

fixtures/js-stubs/eventEntryExceptionGroup.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {EntryException, EntryType} from 'sentry/types';
1+
import {EntryException, EntryType} from 'sentry/types/event';
22

33
export function EventEntryExceptionGroupFixture(): EntryException {
44
return {

fixtures/js-stubs/eventEntryStacktrace.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {type EntryStacktrace, EntryType} from 'sentry/types';
1+
import {type EntryStacktrace, EntryType} from 'sentry/types/event';
22

33
export function EventEntryStacktraceFixture(params = {}): EntryStacktrace {
44
return {

fixtures/js-stubs/eventIdQueryResult.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {EventFixture} from 'sentry-fixture/event';
22

3-
import type {EventIdResponse} from 'sentry/types';
3+
import type {EventIdResponse} from 'sentry/types/event';
44

55
export function EventIdQueryResultFixture(params = {}): EventIdResponse {
66
const event = EventFixture({

fixtures/js-stubs/eventStacktraceException.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {EventFixture} from 'sentry-fixture/event';
22
import {EventEntryFixture} from 'sentry-fixture/eventEntry';
33

4-
import {EntryType} from 'sentry/types';
4+
import {EntryType} from 'sentry/types/event';
55

66
const exception = EventEntryFixture({
77
type: EntryType.EXCEPTION,

fixtures/js-stubs/eventStacktraceFrame.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {Frame} from 'sentry/types';
1+
import {Frame} from 'sentry/types/event';
22

33
export function EventStacktraceFrameFixture(params = {}): Frame {
44
return {

fixtures/js-stubs/events.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import {type Event, EventOrGroupType, EventsStats} from 'sentry/types';
1+
import {type Event, EventOrGroupType} from 'sentry/types/event';
2+
import {EventsStats} from 'sentry/types/organization';
23

34
export function EventsStatsFixture(params = {}): EventsStats {
45
return {

fixtures/js-stubs/exceptionValue.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {ExceptionValue} from 'sentry/types';
1+
import type {ExceptionValue} from 'sentry/types/event';
22

33
export function ExceptionValueFixture(
44
props: Partial<ExceptionValue> = {}

fixtures/js-stubs/feedbackIssue.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import {ProjectFixture} from 'sentry-fixture/project';
22

3-
import {EventOrGroupType, GroupStatus, PriorityLevel} from 'sentry/types';
3+
import {EventOrGroupType} from 'sentry/types/event';
4+
import {GroupStatus, PriorityLevel} from 'sentry/types/group';
45
import type {FeedbackIssue} from 'sentry/utils/feedback/types';
56

67
type Overwrite<T, U> = Pick<T, Exclude<keyof T, keyof U>> & U;

fixtures/js-stubs/frame.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {Frame} from 'sentry/types';
1+
import type {Frame} from 'sentry/types/event';
22

33
export function FrameFixture(props: Partial<Frame> = {}): Frame {
44
return {

fixtures/js-stubs/githubIntegration.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {GroupIntegration} from 'sentry/types';
1+
import {GroupIntegration} from 'sentry/types/integrations';
22

33
export function GitHubIntegrationFixture(
44
params: Partial<GroupIntegration> = {}

fixtures/js-stubs/githubIntegrationProvider.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {IntegrationProvider} from 'sentry/types';
1+
import {IntegrationProvider} from 'sentry/types/integrations';
22

33
export function GitHubIntegrationProviderFixture(
44
params: Partial<IntegrationProvider> = {}

fixtures/js-stubs/globalSelection.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {PageFilters} from 'sentry/types';
1+
import type {PageFilters} from 'sentry/types/core';
22

33
export function GlobalSelectionFixture(params: Partial<PageFilters> = {}): PageFilters {
44
return {

fixtures/js-stubs/group.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import {ProjectFixture} from 'sentry-fixture/project';
22

3+
import {EventOrGroupType} from 'sentry/types/event';
34
import {
4-
EventOrGroupType,
55
type Group,
66
GroupStatus,
77
GroupUnresolved,
88
IssueCategory,
99
IssueType,
1010
PriorityLevel,
11-
} from 'sentry/types';
11+
} from 'sentry/types/group';
1212

1313
export function GroupFixture(params: Partial<Group> = {}): Group {
1414
const unresolvedGroup: GroupUnresolved = {

fixtures/js-stubs/groupStats.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {GroupStats} from 'sentry/types';
1+
import type {GroupStats} from 'sentry/types/group';
22

33
export function GroupStatsFixture(params: Partial<GroupStats> = {}): GroupStats {
44
return {

fixtures/js-stubs/groupingConfigs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {EventGroupingConfig} from 'sentry/types';
1+
import type {EventGroupingConfig} from 'sentry/types/event';
22

33
export function GroupingConfigsFixture(): EventGroupingConfig[] {
44
return [

fixtures/js-stubs/groups.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {GroupFixture} from 'sentry-fixture/group';
22
import {ProjectFixture} from 'sentry-fixture/project';
33

4-
import {GroupStatus} from 'sentry/types';
4+
import {GroupStatus} from 'sentry/types/group';
55

66
export function GroupsFixture() {
77
const project = ProjectFixture({name: 'Internal', slug: 'project-slug', id: '123'});

fixtures/js-stubs/health.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {Health} from 'sentry/types';
1+
import type {Health} from 'sentry/types/release';
22

33
export function HealthFixture(params: Partial<Health> = {}): Health {
44
return {

fixtures/js-stubs/integrationListDirectory.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
import type {Integration, IntegrationProvider, Plugin, SentryApp} from 'sentry/types';
1+
import type {
2+
Integration,
3+
IntegrationProvider,
4+
Plugin,
5+
SentryApp,
6+
} from 'sentry/types/integrations';
27

38
export function ProviderListFixture(): {providers: IntegrationProvider[]} {
49
return {

fixtures/js-stubs/jiraIntegration.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {GroupIntegration} from 'sentry/types';
1+
import type {GroupIntegration} from 'sentry/types/integrations';
22

33
export function JiraIntegrationFixture(
44
params: Partial<GroupIntegration> = {}

fixtures/js-stubs/jiraIntegrationProvider.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {IntegrationProvider} from 'sentry/types';
1+
import type {IntegrationProvider} from 'sentry/types/integrations';
22

33
export function JiraIntegrationProviderFixture(
44
params: Partial<IntegrationProvider> = {}

fixtures/js-stubs/member.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {UserFixture} from 'sentry-fixture/user';
22

3-
import type {Member} from 'sentry/types';
3+
import type {Member} from 'sentry/types/organization';
44

55
export function MemberFixture(params: Partial<Member> = {}): Member {
66
return {

fixtures/js-stubs/members.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {MemberFixture} from 'sentry-fixture/member';
22
import {UserFixture} from 'sentry-fixture/user';
33

4-
import type {Member} from 'sentry/types';
4+
import type {Member} from 'sentry/types/organization';
55

66
export function MembersFixture(params: Member[] = []): Member[] {
77
return [

fixtures/js-stubs/metrics.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Totals will not be correct for all aggregation functions.
22
// Consider adding aggregation specific fixture (e.g. MetricsP75Field) if your test depends on it.
33

4-
import type {MetricsApiResponse} from 'sentry/types';
4+
import type {MetricsApiResponse} from 'sentry/types/metrics';
55

66
export function MetricsFieldFixture(
77
field: string,

fixtures/js-stubs/missingMembers.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {MissingMember} from 'sentry/types';
1+
import type {MissingMember} from 'sentry/types/organization';
22

33
export function MissingMembersFixture(params = []): MissingMember[] {
44
return [

fixtures/js-stubs/opsgenieIntegration.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {OrganizationIntegration} from 'sentry/types';
1+
import type {OrganizationIntegration} from 'sentry/types/integrations';
22

33
export function OpsgenieIntegrationFixture(
44
params: Partial<OrganizationIntegration> = {}

fixtures/js-stubs/opsgenieIntegrationProvider.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {IntegrationProvider} from 'sentry/types';
1+
import type {IntegrationProvider} from 'sentry/types/integrations';
22

33
export function OpsgenieIntegrationProviderFixture(
44
params: Partial<IntegrationProvider> = {}

fixtures/js-stubs/organization.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {OrgRoleListFixture, TeamRoleListFixture} from 'sentry-fixture/roleList';
22

3-
import type {DetailedOrganization} from 'sentry/types';
3+
import type {DetailedOrganization} from 'sentry/types/organization';
44

55
export function OrganizationFixture(
66
params: Partial<DetailedOrganization> = {}

0 commit comments

Comments
 (0)