Skip to content

Commit aac614f

Browse files
ref(crons): Improve wording on cron check-in badges (#91990)
1 parent d05f67d commit aac614f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

static/app/views/insights/crons/components/checkInCell.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,11 +281,11 @@ function OffScheduleIndicator({checkIn}: OffScheduleIndicatorProps) {
281281

282282
const title = dueToMissingInProgress
283283
? tct(
284-
'This check-in was received [earlyBy] before it was expected. This may be due to the missing in-progress check-in, as your job reported a duration of [jobDuration] without sending an in-progress. Your grace period for the first check-in is [checkInMargin].',
284+
'This check-in was recorded [earlyBy] earlier than expected. This may be due to a missing in-progress check-in, as your job reported a duration of [jobDuration] without sending one. The grace period for your monitor before the check-in is considered missed is [checkInMargin].',
285285
{earlyBy, jobDuration, checkInMargin}
286286
)
287287
: tct(
288-
'This check-in was Received [earlyBy] before it was expected. This is likely due to a misconfiguration.',
288+
'This check-in was recorded [earlyBy] earlier than expected, which may indicate a configuration issue.',
289289
{earlyBy}
290290
);
291291

static/app/views/insights/crons/components/monitorCheckInsGrid.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ describe('CheckInRow', () => {
142142
await userEvent.hover(earlyBadge);
143143

144144
const expectedTooltip = textWithMarkupMatcher(
145-
'This check-in was Received 24 hours before it was expected. This is likely due to a misconfiguration.'
145+
'This check-in was recorded 24 hours earlier than expected, which may indicate a configuration issue.'
146146
);
147147

148148
expect(await screen.findByText(expectedTooltip)).toBeInTheDocument();
@@ -165,7 +165,7 @@ describe('CheckInRow', () => {
165165
await userEvent.hover(earlyBadge);
166166

167167
const expectedTooltip = textWithMarkupMatcher(
168-
'This check-in was received 24 hours before it was expected. This may be due to the missing in-progress check-in, as your job reported a duration of 12 minutes without sending an in-progress. Your grace period for the first check-in is 5 minutes.'
168+
'This check-in was recorded 24 hours earlier than expected. This may be due to a missing in-progress check-in, as your job reported a duration of 12 minutes without sending one. The grace period for your monitor before the check-in is considered missed is 5 minutes.'
169169
);
170170

171171
expect(await screen.findByText(expectedTooltip)).toBeInTheDocument();

0 commit comments

Comments
 (0)