Skip to content

Commit aacdcfd

Browse files
authored
ref(rules): Remove inner lock and add logging on exception (#70629)
Part of debugging the delayed rule processor lead here, we don't need the inner lock (it's locked [here](https://github.com/getsentry/sentry/blob/370e78ca10dddc2b018d1e9b6e41e501386cc0d2/src/sentry/buffer/redis.py#L316-L318) before `process_batch` is called).
1 parent a9cb58e commit aacdcfd

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

src/sentry/buffer/redis.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -312,15 +312,10 @@ def get_hash(
312312
return decoded_hash
313313

314314
def process_batch(self) -> None:
315-
client = get_cluster_routing_client(self.cluster, self.is_redis_cluster)
316-
lock_key = self._lock_key(client, self.pending_key, ex=10)
317-
if not lock_key:
318-
return
319-
320315
try:
321316
redis_buffer_registry.callback(BufferHookEvent.FLUSH, self)
322-
finally:
323-
client.delete(lock_key)
317+
except Exception:
318+
logger.exception("process_batch.error")
324319

325320
def incr(
326321
self,

0 commit comments

Comments
 (0)