Skip to content

Commit b490ef4

Browse files
authored
fix(eap-spans): span ops breakdowns not working (#91722)
Measurements aren't stored with the `sentry` prefix
1 parent f8a7613 commit b490ef4

File tree

2 files changed

+33
-5
lines changed

2 files changed

+33
-5
lines changed

src/sentry/search/eap/spans/attributes.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -285,27 +285,27 @@ def validate_event_id(value: str | list[str]) -> bool:
285285
),
286286
ResolvedAttribute(
287287
public_alias="spans.browser",
288-
internal_name="sentry.span_ops.ops.browser",
288+
internal_name="span_ops.ops.browser",
289289
search_type="millisecond",
290290
),
291291
ResolvedAttribute(
292292
public_alias="spans.db",
293-
internal_name="sentry.span_ops.ops.db",
293+
internal_name="span_ops.ops.db",
294294
search_type="millisecond",
295295
),
296296
ResolvedAttribute(
297297
public_alias="spans.http",
298-
internal_name="sentry.span_ops.ops.http",
298+
internal_name="span_ops.ops.http",
299299
search_type="millisecond",
300300
),
301301
ResolvedAttribute(
302302
public_alias="spans.resource",
303-
internal_name="sentry.span_ops.ops.resource",
303+
internal_name="span_ops.ops.resource",
304304
search_type="millisecond",
305305
),
306306
ResolvedAttribute(
307307
public_alias="spans.ui",
308-
internal_name="sentry.span_ops.ops.ui",
308+
internal_name="span_ops.ops.ui",
309309
search_type="millisecond",
310310
),
311311
ResolvedAttribute(

tests/snuba/api/endpoints/test_organization_events_span_indexed.py

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4618,3 +4618,31 @@ def test_count_if_two_args(self):
46184618
assert len(data) == 1
46194619
assert data[0]["count_if(release,foo)"] == 1
46204620
assert meta["dataset"] == self.dataset
4621+
4622+
def test_span_ops_breakdown(self):
4623+
self.store_spans(
4624+
[
4625+
self.create_span(
4626+
{
4627+
"measurements": {"span_ops.ops.http": {"value": 100}},
4628+
},
4629+
),
4630+
],
4631+
is_eap=self.is_eap,
4632+
)
4633+
4634+
response = self.do_request(
4635+
{
4636+
"field": ["spans.http"],
4637+
"query": "",
4638+
"project": self.project.id,
4639+
"dataset": self.dataset,
4640+
}
4641+
)
4642+
assert response.status_code == 200, response.content
4643+
data = response.data["data"]
4644+
meta = response.data["meta"]
4645+
4646+
assert len(data) == 1
4647+
assert data[0]["spans.http"] == 100
4648+
assert meta["dataset"] == self.dataset

0 commit comments

Comments
 (0)