Skip to content

Commit b7fc82d

Browse files
authored
fix(eap-spans): count_op should use score.total (#87132)
1 parent 8ee6a25 commit b7fc82d

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/sentry/search/eap/spans/aggregates.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ def resolve_key_eq_value_filter(args: ResolvedArguments) -> tuple[AttributeKey,
6868
def resolve_count_scores(args: ResolvedArguments) -> tuple[AttributeKey, TraceItemFilter]:
6969
score_column = cast(str, args[0])
7070
ratio_column_name = score_column.replace("measurements.score", "score.ratio")
71+
if ratio_column_name == "score.ratio.total":
72+
ratio_column_name = "score.total"
7173
attribute_key = AttributeKey(name=ratio_column_name, type=AttributeKey.TYPE_DOUBLE)
7274
filter = TraceItemFilter(exists_filter=ExistsFilter(key=attribute_key))
7375

tests/snuba/api/endpoints/test_organization_events_span_indexed.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2985,23 +2985,23 @@ def test_count_scores(self):
29852985
{
29862986
"measurements": {
29872987
"score.ratio.lcp": {"value": 0.03},
2988-
"score.ratio.total": {"value": 0.43},
2988+
"score.total": {"value": 0.43},
29892989
}
29902990
},
29912991
start_ts=self.ten_mins_ago,
29922992
),
29932993
self.create_span(
29942994
{
29952995
"measurements": {
2996-
"score.ratio.total": {"value": 1.0},
2996+
"score.total": {"value": 1.0},
29972997
}
29982998
},
29992999
start_ts=self.ten_mins_ago,
30003000
),
30013001
self.create_span(
30023002
{
30033003
"measurements": {
3004-
"score.ratio.total": {"value": 0.0},
3004+
"score.total": {"value": 0.0},
30053005
}
30063006
},
30073007
start_ts=self.ten_mins_ago,

0 commit comments

Comments
 (0)