Skip to content

Commit b8796c4

Browse files
authored
fix(process-segments): Do not crash when messages are invalid (#91663)
We don't get much from crashing while this entire deployment is still a noop.
1 parent 06389a1 commit b8796c4

File tree

1 file changed

+5
-6
lines changed
  • src/sentry/spans/consumers/process_segments

1 file changed

+5
-6
lines changed

src/sentry/spans/consumers/process_segments/factory.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
from collections.abc import Mapping
33

44
import orjson
5+
import sentry_sdk
56
from arroyo import Topic as ArroyoTopic
67
from arroyo.backends.kafka import KafkaProducer, build_kafka_configuration
78
from arroyo.backends.kafka.consumer import KafkaPayload
@@ -107,12 +108,10 @@ def _process_message(message: Message[KafkaPayload]) -> list[bytes]:
107108
segment = orjson.loads(value)
108109
processed = process_segment(segment["spans"])
109110
return [orjson.dumps(span) for span in processed]
110-
except Exception: # NOQA
111-
raise
112-
# TODO: Implement error handling
113-
# sentry_sdk.capture_exception()
114-
# assert isinstance(message.value, BrokerValue)
115-
# raise InvalidMessage(message.value.partition, message.value.offset)
111+
except Exception:
112+
# TODO: revise error handling
113+
sentry_sdk.capture_exception()
114+
return []
116115

117116

118117
def _unfold_segment(spans: list[bytes]):

0 commit comments

Comments
 (0)