Skip to content

Commit bec8253

Browse files
committed
✅ Fix group type tests
1 parent 3249ad6 commit bec8253

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tests/sentry/utils/performance_issues/experiments/test_n_plus_one_api_calls_detector.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ def test_detects_problems_with_many_concurrent_calls_to_same_url(self):
7474
problems = self.find_problems(event)
7575
assert self.find_problems(event) == [
7676
PerformanceProblem(
77-
fingerprint="1-1010-d750ce46bb1b13dd5780aac48098d5e20eea682c",
77+
fingerprint=f"1-{PerformanceNPlusOneAPICallsExperimentalGroupType.type_id}-d750ce46bb1b13dd5780aac48098d5e20eea682c",
7878
op="http.client",
7979
type=PerformanceNPlusOneAPICallsExperimentalGroupType,
8080
desc="GET /api/0/organizations/sentry/events/?field=replayId&field=count%28%29&per_page=50&query=issue.id%3A",
@@ -142,7 +142,7 @@ def test_detects_problems_with_many_concurrent_calls_to_same_url(self):
142142
evidence_display=[],
143143
)
144144
]
145-
assert problems[0].title == "N+1 API Call"
145+
assert problems[0].title == "N+1 API Call (Experimental)"
146146

147147
def test_does_not_detect_problems_with_low_total_duration_of_spans(self):
148148
event = get_event("n-plus-one-api-calls/n-plus-one-api-calls-in-issue-stream")
@@ -200,7 +200,10 @@ def test_fingerprints_events(self):
200200
event = self.create_event(lambda i: "GET /clients/11/info")
201201
[problem] = self.find_problems(event)
202202

203-
assert problem.fingerprint == "1-1010-e9daac10ea509a0bf84a8b8da45d36394868ad67"
203+
assert (
204+
problem.fingerprint
205+
== f"1-{PerformanceNPlusOneAPICallsExperimentalGroupType.type_id}-e9daac10ea509a0bf84a8b8da45d36394868ad67"
206+
)
204207

205208
def test_fingerprints_identical_relative_urls_together(self):
206209
event1 = self.create_event(lambda i: "GET /clients/11/info")

0 commit comments

Comments
 (0)