tests

Author: mifu67

src/sentry/workflow_engine/migrations/0060_backfill_metric_alert_resolution_action_filters.py

@@ -38,14 +38,18 @@ def backfill_resolution_action_filters(apps: Apps, schema_editor: BaseDatabaseSc
             workflow_dcgs = DataConditionGroup.objects.filter(
                 workflowdataconditiongroup__workflow__id=workflow_id
             )
-            if DataCondition.objects.filter(
-                condition_group__in=workflow_dcgs, type="issue_priority_deescalating"
-            ).exists():
-                # the resolution action filters have already been created, either via dual write or a previous migration
-                continue
 
             with transaction.atomic(router.db_for_write(DataCondition)):
                 for dcg in workflow_dcgs:
+                    if DataCondition.objects.filter(
+                        condition_group=dcg, type="issue_priority_deescalating"
+                    ).exists():
+                        # the resolution action filter has already been created, either via dual write or a previous migration
+                        # I have this inside the loop because it's possible someone added a new condition after we turned
+                        # on dual write of resolution action filters, so one of the conditions is correct and the other
+                        # needs to be backfilled
+                        continue
+
                     action_filter = DataCondition.objects.get(
                         condition_group=dcg,
                     )

tests/sentry/workflow_engine/migrations/test_0060_backfill_metric_alert_resolution_action_filters.py

@@ -0,0 +1,76 @@
+from sentry.testutils.cases import TestMigrations
+from sentry.workflow_engine.models import Condition, DataCondition, DataConditionGroup
+from sentry.workflow_engine.types import DetectorPriorityLevel
+
+
+class TestBackfillMetricAlertResolutionActionFilters(TestMigrations):
+    app = "workflow_engine"
+    migrate_from = "0059_fix_high_priority_condition_triggers"
+    migrate_to = "0060_backfill_metric_alert_resolution_action_filters"
+
+    def mock_aci_objects(self) -> tuple[DataConditionGroup, DataConditionGroup]:
+        alert_rule = self.create_alert_rule(organization=self.organization)
+        workflow = self.create_workflow(organization=self.organization)
+        self.create_alert_rule_workflow(alert_rule=alert_rule, workflow=workflow)
+
+        critical_dcg = self.create_data_condition_group(organization=self.organization)
+        self.create_workflow_data_condition_group(workflow=workflow, condition_group=critical_dcg)
+        self.create_data_condition(
+            comparison=DetectorPriorityLevel.HIGH,
+            condition_result=True,
+            type=Condition.ISSUE_PRIORITY_GREATER_OR_EQUAL,
+            condition_group=critical_dcg,
+        )
+
+        warning_dcg = self.create_data_condition_group(organization=self.organization)
+        self.create_workflow_data_condition_group(workflow=workflow, condition_group=warning_dcg)
+        self.create_data_condition(
+            comparison=DetectorPriorityLevel.MEDIUM,
+            condition_result=True,
+            type=Condition.ISSUE_PRIORITY_GREATER_OR_EQUAL,
+            condition_group=warning_dcg,
+        )
+
+        return critical_dcg, warning_dcg
+
+    def create_resolve_action_filter(self, dcg: DataConditionGroup) -> None:
+        self.create_data_condition(
+            comparison=DetectorPriorityLevel.HIGH,
+            condition_result=True,
+            type=Condition.ISSUE_PRIORITY_DEESCALATING,
+            condition_group=dcg,
+        )
+
+    def assert_resolve_action_filter_exists(
+        self, dcg: DataConditionGroup, comparison: DetectorPriorityLevel
+    ) -> None:
+        queryset = DataCondition.objects.filter(
+            comparison=comparison, type=Condition.ISSUE_PRIORITY_DEESCALATING, condition_group=dcg
+        )
+        assert queryset.exists()
+        assert queryset.count() == 1
+
+    def setup_initial_state(self):
+        # vanilla
+        self.critical_dcg_1, self.warning_dcg_1 = self.mock_aci_objects()
+
+        # both dcgs have a resolution action filter
+        self.critical_dcg_2, self.warning_dcg_2 = self.mock_aci_objects()
+        self.create_resolve_action_filter(self.critical_dcg_2)
+        self.create_resolve_action_filter(self.warning_dcg_2)
+
+        # only one dcg has a resolution action filter
+        self.critical_dcg_3, self.warning_dcg_3 = self.mock_aci_objects()
+        self.create_resolve_action_filter(self.warning_dcg_3)
+
+    def test_simple(self):
+        self.assert_resolve_action_filter_exists(self.critical_dcg_1, DetectorPriorityLevel.HIGH)
+        self.assert_resolve_action_filter_exists(self.warning_dcg_1, DetectorPriorityLevel.MEDIUM)
+
+    def test_both_migrated(self):
+        self.assert_resolve_action_filter_exists(self.critical_dcg_2, DetectorPriorityLevel.HIGH)
+        self.assert_resolve_action_filter_exists(self.warning_dcg_2, DetectorPriorityLevel.MEDIUM)
+
+    def test_one_migrated(self):
+        self.assert_resolve_action_filter_exists(self.critical_dcg_3, DetectorPriorityLevel.HIGH)
+        self.assert_resolve_action_filter_exists(self.warning_dcg_3, DetectorPriorityLevel.MEDIUM)