Skip to content

Commit c13f4be

Browse files
committed
original approach
1 parent c1fbd74 commit c13f4be

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/sentry/sentry_apps/logic.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -350,9 +350,10 @@ def _generate_and_validate_slug(self) -> str:
350350

351351
def _create_proxy_user(self, slug: str) -> User:
352352
# need a proxy user name that will always be unique
353-
proxy_user = User.objects.create(username=f"{slug}-{default_uuid()}", is_sentry_app=True)
354-
email = f"{proxy_user.id}@proxy-user.sentry.io"
355-
proxy_user.update(email=email)
353+
username = f"{slug}-{default_uuid()}"
354+
proxy_user = User.objects.create(
355+
username=username, email=f"{username}@proxy-user.sentry.io", is_sentry_app=True
356+
)
356357
return proxy_user
357358

358359
def _create_api_application(self, proxy: User) -> ApiApplication:

tests/sentry/sentry_apps/test_sentry_app_installation_creator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,4 +148,4 @@ def test_placeholder_email(self):
148148
responses.add(responses.POST, "https://example.com/webhook")
149149
install = self.run_creator()
150150
proxy_user = User.objects.get(id=install.sentry_app.proxy_user.id)
151-
assert proxy_user.email == f"{proxy_user.id}@proxy-user.sentry.io"
151+
assert proxy_user.email == f"{proxy_user.username}@proxy-user.sentry.io"

0 commit comments

Comments
 (0)