perf(aci): Load slow conditions for all DataConditionGroups at once

Author: kcons

src/sentry/workflow_engine/models/data_condition_group.py

@@ -1,3 +1,4 @@
+from collections.abc import Mapping
 from enum import StrEnum
 from typing import ClassVar, Self
 
@@ -40,6 +41,21 @@ class Type(StrEnum):
     organization = models.ForeignKey("sentry.Organization", on_delete=models.CASCADE)
 
 
+def batch_get_slow_conditions(dcgs: list[DataConditionGroup]) -> Mapping[int, list[DataCondition]]:
+    """
+    Get all slow conditions for a list of data condition groups.
+    """
+    dcg_ids = [dcg.id for dcg in dcgs]
+    conditions = DataCondition.objects.filter(
+        condition_group__in=dcg_ids,
+    )
+    slow_conditions_by_dcg = {dcg.id: [] for dcg in dcgs}
+    for condition in conditions:
+        if is_slow_condition(condition):
+            slow_conditions_by_dcg[condition.condition_group_id].append(condition)
+    return slow_conditions_by_dcg
+
+
 def get_slow_conditions(dcg: DataConditionGroup) -> list[DataCondition]:
     """
     Get all conditions that are considered slow for a given data condition group

src/sentry/workflow_engine/processors/delayed_workflow.py

@@ -44,7 +44,7 @@
     SLOW_CONDITIONS,
     Condition,
 )
-from sentry.workflow_engine.models.data_condition_group import get_slow_conditions
+from sentry.workflow_engine.models.data_condition_group import batch_get_slow_conditions
 from sentry.workflow_engine.processors.action import filter_recently_fired_workflow_actions
 from sentry.workflow_engine.processors.data_condition_group import evaluate_data_conditions
 from sentry.workflow_engine.processors.detector import get_detector_by_event
@@ -224,9 +224,9 @@ def get_condition_query_groups(
     Map unique condition queries to the group IDs that need to checked for that query.
     """
     condition_groups: dict[UniqueConditionQuery, set[int]] = defaultdict(set)
+    slow_conditions_by_dcg = batch_get_slow_conditions(data_condition_groups)
     for dcg in data_condition_groups:
-        slow_conditions = get_slow_conditions(dcg)
-        for condition in slow_conditions:
+        for condition in slow_conditions_by_dcg[dcg.id]:
             workflow_id = dcg_to_workflow.get(dcg.id)
             workflow_env = workflows_to_envs[workflow_id] if workflow_id else None
             for condition_query in generate_unique_queries(condition, workflow_env):
@@ -273,8 +273,9 @@ def get_groups_to_fire(
     condition_group_results: dict[UniqueConditionQuery, QueryResult],
 ) -> dict[int, set[DataConditionGroup]]:
     groups_to_fire: dict[int, set[DataConditionGroup]] = defaultdict(set)
+    slow_conditions_by_dcg = batch_get_slow_conditions(data_condition_groups)
     for dcg in data_condition_groups:
-        slow_conditions = get_slow_conditions(dcg)
+        slow_conditions = slow_conditions_by_dcg[dcg.id]
         action_match = DataConditionGroup.Type(dcg.logic_type)
         workflow_id = dcg_to_workflow.get(dcg.id)
         workflow_env = workflows_to_envs[workflow_id] if workflow_id else None

tests/sentry/workflow_engine/models/test_data_condition_group.py

@@ -0,0 +1,41 @@
+from sentry.testutils.cases import TestCase
+from sentry.workflow_engine.models.data_condition import Condition, DataCondition
+from sentry.workflow_engine.models.data_condition_group import (
+    DataConditionGroup,
+    batch_get_slow_conditions,
+)
+
+
+class TestBatchGetSlowConditions(TestCase):
+    def setUp(self):
+        super().setUp()
+        self.dcg = self.create_data_condition_group()
+
+    def create_slow_condition(self, condition_group: DataConditionGroup) -> DataCondition:
+        return self.create_data_condition(
+            condition_group=condition_group,
+            type=Condition.EVENT_FREQUENCY_COUNT,
+            comparison={
+                "interval": "1d",
+                "value": 7,
+            },
+        )
+
+    def test_batch_get_slow_conditions(self):
+        condition = self.create_slow_condition(self.dcg)
+        assert batch_get_slow_conditions([self.dcg]) == {self.dcg.id: [condition]}
+
+    def test_batch_get_slow_conditions__no_slow_conditions(self):
+        self.create_data_condition(condition_group=self.dcg, type=Condition.EQUAL)
+        assert batch_get_slow_conditions([self.dcg]) == {self.dcg.id: []}
+
+    def test_multiple_dcgs(self):
+        dcg2 = self.create_data_condition_group()
+        condition1 = self.create_slow_condition(self.dcg)
+        condition2 = self.create_slow_condition(dcg2)
+        self.create_data_condition(condition_group=self.dcg, type=Condition.EQUAL)
+        condition4 = self.create_slow_condition(dcg2)
+        assert batch_get_slow_conditions([self.dcg, dcg2]) == {
+            self.dcg.id: [condition1],
+            dcg2.id: [condition2, condition4],
+        }