Skip to content

Commit cdcc87e

Browse files
authored
fix(processing): Don't pretend to log 'not_sent' (#92050)
Stop tracking/logging `not_sent` based on callback return value being None; callback return value is always expected to be `None`, not just on exception, so logging it as `not_sent` is misleading.
1 parent bcd9085 commit cdcc87e

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/sentry/rules/processing/delayed_processing.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -593,18 +593,14 @@ def fire_rules(
593593
).values()
594594

595595
# TODO(cathy): add opposite of the FF organizations:workflow-engine-trigger-actions
596-
not_sent = 0
597596
for callback, futures in callback_and_futures:
598-
results = safe_execute(callback, groupevent, futures)
599-
if results is None:
600-
not_sent += 1
597+
safe_execute(callback, groupevent, futures)
601598

602599
if log_config.num_events_issue_debugging:
603600
logger.info(
604601
"delayed_processing.rules_fired",
605602
extra={
606603
"total": len(callback_and_futures),
607-
"not_sent": not_sent,
608604
"project_id": project_id,
609605
"rule_id": rule.id,
610606
},

0 commit comments

Comments
 (0)