Skip to content

Commit ce6dec0

Browse files
authored
fix(flagpole) Fix metric tag name (#69028)
The `name` tag is used by container/host name so this tag needs to move in order to be useful.
1 parent 6cb8a73 commit ce6dec0

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/sentry/features/manager.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ def has(self, name: str, *args: Any, skip_entity: bool | None = False, **kwargs:
214214
"""
215215
sample_rate = 0.01
216216
try:
217-
with metrics.timer("features.has", tags={"name": name}, sample_rate=sample_rate):
217+
with metrics.timer("features.has", tags={"feature": name}, sample_rate=sample_rate):
218218
actor = kwargs.pop("actor", None)
219219
feature = self.get(name, *args, **kwargs)
220220

@@ -223,7 +223,7 @@ def has(self, name: str, *args: Any, skip_entity: bool | None = False, **kwargs:
223223
if rv is not None:
224224
metrics.incr(
225225
"feature.has.result",
226-
tags={"name": name, "result": rv},
226+
tags={"feature": name, "result": rv},
227227
sample_rate=sample_rate,
228228
)
229229
return rv
@@ -233,7 +233,7 @@ def has(self, name: str, *args: Any, skip_entity: bool | None = False, **kwargs:
233233
if rv is not None:
234234
metrics.incr(
235235
"feature.has.result",
236-
tags={"name": name, "result": rv},
236+
tags={"feature": name, "result": rv},
237237
sample_rate=sample_rate,
238238
)
239239
return rv
@@ -242,15 +242,15 @@ def has(self, name: str, *args: Any, skip_entity: bool | None = False, **kwargs:
242242
if rv is not None:
243243
metrics.incr(
244244
"feature.has.result",
245-
tags={"name": name, "result": rv},
245+
tags={"feature": name, "result": rv},
246246
sample_rate=sample_rate,
247247
)
248248
return rv
249249

250250
# Features are by default disabled if no plugin or default enables them
251251
metrics.incr(
252252
"feature.has.result",
253-
tags={"name": name, "result": False},
253+
tags={"feature": name, "result": False},
254254
sample_rate=sample_rate,
255255
)
256256

0 commit comments

Comments
 (0)