add a new prop, finagle things a bit more

Author: colin-sentry

static/app/components/events/breadcrumbs/combinedBreadcrumbsAndLogsSection.tsx

@@ -26,6 +26,7 @@ export function CombinedBreadcrumbsAndLogsSection({
   return (
     <LogsPageParamsProvider
       isTableFrozen
+      blockRowExpanding
       limitToTraceId={event.contexts?.trace?.trace_id}
       analyticsPageSource={LogsAnalyticsPageSource.ISSUE_DETAILS}
     >

static/app/views/explore/contexts/logs/logsPageParams.tsx

@@ -31,6 +31,7 @@ export const LOGS_FIELDS_KEY = 'logsFields';
 
 interface LogsPageParams {
   readonly analyticsPageSource: LogsAnalyticsPageSource;
+  readonly blockRowExpanding: boolean | undefined;
   readonly cursor: string;
   readonly fields: string[];
   readonly isTableFrozen: boolean | undefined;
@@ -57,6 +58,7 @@ const [_LogsPageParamsProvider, _useLogsPageParams, LogsPageParamsContext] =
 export interface LogsPageParamsProviderProps {
   analyticsPageSource: LogsAnalyticsPageSource;
   children: React.ReactNode;
+  blockRowExpanding?: boolean;
   isTableFrozen?: boolean;
   limitToProjectIds?: number[];
   limitToSpanId?: string;
@@ -68,6 +70,7 @@ export function LogsPageParamsProvider({
   limitToTraceId,
   limitToSpanId,
   limitToProjectIds,
+  blockRowExpanding,
   isTableFrozen,
   analyticsPageSource,
 }: LogsPageParamsProviderProps) {
@@ -103,6 +106,7 @@ export function LogsPageParamsProvider({
         sortBys,
         cursor,
         isTableFrozen,
+        blockRowExpanding,
         baseSearch,
         projectIds,
         analyticsPageSource,
@@ -202,7 +206,12 @@ export function useSetLogsSearch() {
 
 export function useLogsIsTableFrozen() {
   const {isTableFrozen} = useLogsPageParams();
-  return isTableFrozen;
+  return !!isTableFrozen;
+}
+
+export function useLogsBlockRowExpanding() {
+  const {blockRowExpanding} = useLogsPageParams();
+  return !!blockRowExpanding;
 }
 
 export function usePersistedLogsPageParams() {

static/app/views/explore/logs/logsIssuesSection.tsx

@@ -89,6 +89,7 @@ export function LogsIssuesSection({
       <LogsPageParamsProvider
         analyticsPageSource={LogsAnalyticsPageSource.ISSUE_DETAILS}
         isTableFrozen
+        blockRowExpanding
         limitToTraceId={limitToTraceId}
       >
         <LogsSectionContent tableData={tableData} openDrawer={onOpenLogsDrawer} />

static/app/views/explore/logs/logsTableRow.tsx

@@ -1,4 +1,4 @@
-import type {SyntheticEvent} from 'react';
+import type {ComponentProps, SyntheticEvent} from 'react';
 import {Fragment, useCallback, useState} from 'react';
 import {useTheme} from '@emotion/react';
 
@@ -20,6 +20,7 @@ import type {TableColumn} from 'sentry/views/discover/table/types';
 import {AttributesTree} from 'sentry/views/explore/components/traceItemAttributes/attributesTree';
 import {
   useLogsAnalyticsPageSource,
+  useLogsBlockRowExpanding,
   useLogsFields,
   useLogsIsTableFrozen,
   useLogsSearch,
@@ -94,6 +95,7 @@ export function LogRowContent({
   const search = useLogsSearch();
   const setLogsSearch = useSetLogsSearch();
   const isTableFrozen = useLogsIsTableFrozen();
+  const blockRowExpanding = useLogsBlockRowExpanding();
 
   function toggleExpanded() {
     setExpanded(e => !e);
@@ -165,24 +167,30 @@ export function LogRowContent({
     projectSlug,
   };
 
+  const rowInteractProps: ComponentProps<typeof LogTableRow> = blockRowExpanding
+    ? {}
+    : {
+        ...hoverProps,
+        onPointerUp,
+        onTouchEnd: onPointerUp,
+        isClickable: true,
+      };
+
   return (
     <Fragment>
-      <LogTableRow
-        data-test-id="log-table-row"
-        onPointerUp={onPointerUp}
-        onTouchEnd={onPointerUp}
-        {...hoverProps}
-      >
+      <LogTableRow data-test-id="log-table-row" {...rowInteractProps}>
         <LogsTableBodyFirstCell key={'first'}>
           <LogFirstCellContent>
-            <StyledChevronButton
-              icon={<IconChevron size="xs" direction={expanded ? 'down' : 'right'} />}
-              aria-label={t('Toggle trace details')}
-              aria-expanded={expanded}
-              size="zero"
-              borderless
-              onClick={() => toggleExpanded()}
-            />
+            {blockRowExpanding ? null : (
+              <StyledChevronButton
+                icon={<IconChevron size="xs" direction={expanded ? 'down' : 'right'} />}
+                aria-label={t('Toggle trace details')}
+                aria-expanded={expanded}
+                size="zero"
+                borderless
+                onClick={() => toggleExpanded()}
+              />
+            )}
             <SeverityCircleRenderer extra={rendererExtra} meta={meta} />
           </LogFirstCellContent>
         </LogsTableBodyFirstCell>

static/app/views/explore/logs/styles.tsx

@@ -19,9 +19,13 @@ const StyledPanel = styled(Panel)`
   margin-bottom: 0;
 `;
 
-export const LogTableRow = styled(TableRow)`
+interface LogTableRowProps {
+  isClickable?: boolean;
+}
+
+export const LogTableRow = styled(TableRow)<LogTableRowProps>`
   &:not(thead > &) {
-    cursor: pointer;
+    cursor: ${p => (p.isClickable ? 'pointer' : 'default')};
 
     &:hover {
       background-color: ${p => p.theme.backgroundSecondary};