Skip to content

Commit cfbdf44

Browse files
ryan953michellewzhang
authored andcommitted
feat(insights): Rename Errored Sessions chart to Unhealthy Sessions (#89340)
Followup to a comment here: https://github.com/getsentry/sentry/pull/89315/files#r2038106208 --------- Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com>
1 parent da2a93a commit cfbdf44

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

static/app/views/insights/sessions/charts/erroredSessionsChart.tsx renamed to static/app/views/insights/sessions/charts/unhealthySessionsChart.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import useErroredSessions from 'sentry/views/insights/sessions/queries/useErrore
66
import {CHART_TITLES} from 'sentry/views/insights/sessions/settings';
77
import {SESSION_HEALTH_CHART_HEIGHT} from 'sentry/views/insights/sessions/utils/sessions';
88

9-
export default function ErroredSessionsChart() {
9+
export default function UnhealthySessionsChart() {
1010
const {series, isPending, error} = useErroredSessions();
1111

1212
const aliases = {
@@ -15,13 +15,13 @@ export default function ErroredSessionsChart() {
1515

1616
return (
1717
<InsightsLineChartWidget
18-
title={CHART_TITLES.ErroredSessionsChart}
18+
title={CHART_TITLES.UnhealthySessionsChart}
1919
interactiveTitle={() => (
20-
<ChartSelectionTitle title={CHART_TITLES.ErroredSessionsChart} />
20+
<ChartSelectionTitle title={CHART_TITLES.UnhealthySessionsChart} />
2121
)}
2222
height={SESSION_HEALTH_CHART_HEIGHT}
2323
description={tct(
24-
'The percent of sessions terminating without a single error occurring. See [link:session status].',
24+
'The percent of sessions ending normally, with no errors occurring during its lifetime. See [link:session status].',
2525
{
2626
link: (
2727
<ExternalLink href="https://docs.sentry.io/product/releases/health/#session-status" />

static/app/views/insights/sessions/components/chartMap.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@ import type {ReactElement} from 'react';
33
import type {Project} from 'sentry/types/project';
44
import type {DomainView} from 'sentry/views/insights/pages/useFilters';
55
import CrashFreeSessionsChart from 'sentry/views/insights/sessions/charts/crashFreeSessionsChart';
6-
import ErroredSessionsChart from 'sentry/views/insights/sessions/charts/erroredSessionsChart';
76
import NewAndResolvedIssueChart from 'sentry/views/insights/sessions/charts/newAndResolvedIssueChart';
87
import ReleaseNewIssuesChart from 'sentry/views/insights/sessions/charts/releaseNewIssuesChart';
98
import ReleaseSessionCountChart from 'sentry/views/insights/sessions/charts/releaseSessionCountChart';
109
import ReleaseSessionPercentageChart from 'sentry/views/insights/sessions/charts/releaseSessionPercentageChart';
1110
import SessionHealthCountChart from 'sentry/views/insights/sessions/charts/sessionHealthCountChart';
1211
import SessionHealthRateChart from 'sentry/views/insights/sessions/charts/sessionHealthRateChart';
12+
import UnhealthySessionsChart from 'sentry/views/insights/sessions/charts/unhealthySessionsChart';
1313
import UserHealthCountChart from 'sentry/views/insights/sessions/charts/userHealthCountChart';
1414
import UserHealthRateChart from 'sentry/views/insights/sessions/charts/userHealthRateChart';
1515
import type {CHART_TITLES} from 'sentry/views/insights/sessions/settings';
@@ -19,7 +19,7 @@ export const CHART_MAP: Record<
1919
(props: {project: Project}) => ReactElement
2020
> = {
2121
CrashFreeSessionsChart,
22-
ErroredSessionsChart,
22+
UnhealthySessionsChart,
2323
NewAndResolvedIssueChart,
2424
ReleaseNewIssuesChart,
2525
ReleaseSessionCountChart,
@@ -32,7 +32,8 @@ export const CHART_MAP: Record<
3232

3333
export const CHART_RENAMES: Record<string, keyof typeof CHART_TITLES> = {
3434
// Map from the old name to the new
35-
ErrorFreeSessionsChart: 'ErroredSessionsChart',
35+
ErrorFreeSessionsChart: 'UnhealthySessionsChart',
36+
ErroredSessionsChart: 'UnhealthySessionsChart',
3637
};
3738

3839
export const PAGE_CHART_OPTIONS: Record<
@@ -42,7 +43,7 @@ export const PAGE_CHART_OPTIONS: Record<
4243
frontend: [
4344
// ORDER MATTERS HERE
4445
// The order things are listed is the order rendered
45-
'ErroredSessionsChart',
46+
'UnhealthySessionsChart',
4647
'NewAndResolvedIssueChart',
4748
'SessionHealthCountChart',
4849
'SessionHealthRateChart',
@@ -72,7 +73,7 @@ export const DEFAULT_LAYOUTS: Record<
7273
frontend: [
7374
// ORDER MATTERS HERE
7475
// The order represents the default chart layout for Frontend > Session Health
75-
'ErroredSessionsChart',
76+
'UnhealthySessionsChart',
7677
'UserHealthRateChart',
7778
'SessionHealthRateChart',
7879
'SessionHealthCountChart',

static/app/views/insights/sessions/settings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const MODULE_VISIBLE_FEATURES = ['insights-session-health-tab-ui'];
1212

1313
export const CHART_TITLES = {
1414
CrashFreeSessionsChart: t('Crash Free Sessions'),
15-
ErroredSessionsChart: t('Errored Sessions'),
15+
UnhealthySessionsChart: t('Unhealthy Sessions'),
1616
NewAndResolvedIssueChart: t('Issues'),
1717
ReleaseNewIssuesChart: t('New Issues by Release'),
1818
ReleaseSessionCountChart: t('Total Sessions by Release'),

0 commit comments

Comments
 (0)