Skip to content

Commit d0c1f74

Browse files
authored
fix(replay): Look at issue.project.platform instead of pageFilters for Issue>Replays table (#91768)
The problem is that global page filters are affecting the table display inside the Issue Details > Replay view. You can repro the problem by doing something like: - go to issue list page - select multiple projects from the dropdown - open a mobile issue with replays & go to the replay list within that issue (this page we're fixing) - notice that the extra browser column is visible Fixes REPLAY-218
1 parent 2f0c99c commit d0c1f74

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

static/app/views/issueDetails/groupReplays/groupReplays.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {Button} from 'sentry/components/core/button';
77
import * as Layout from 'sentry/components/layouts/thirds';
88
import Placeholder from 'sentry/components/placeholder';
99
import {Provider as ReplayContextProvider} from 'sentry/components/replays/replayContext';
10+
import {replayMobilePlatforms} from 'sentry/data/platformCategories';
1011
import {IconPlay, IconUser} from 'sentry/icons';
1112
import {t, tn} from 'sentry/locale';
1213
import {space} from 'sentry/styles/space';
@@ -78,7 +79,10 @@ export default function GroupReplays({group}: Props) {
7879
location,
7980
organization,
8081
});
81-
const {allMobileProj} = useAllMobileProj({});
82+
83+
const isMobilePlatform = replayMobilePlatforms.includes(
84+
group.project.platform ?? 'other'
85+
);
8286

8387
useEffect(() => {
8488
trackAnalytics('replay.render-issues-group-list', {
@@ -110,7 +114,7 @@ export default function GroupReplays({group}: Props) {
110114
isFetching={isFetching}
111115
replays={[]}
112116
sort={undefined}
113-
visibleColumns={visibleColumns(allMobileProj)}
117+
visibleColumns={visibleColumns(isMobilePlatform)}
114118
showDropdownFilters={false}
115119
/>
116120
</StyledLayoutPage>

0 commit comments

Comments
 (0)