chore(issue-details): Consolidate share experience (#91093)

combines the public and internal share modals into one. now only one
modal will control all the different methods to share an issue.
![Screenshot 2025-05-06 at 4 24
04 PM](https://github.com/user-attachments/assets/98c3327e-2d21-451f-bd6d-3bcf4f4bf571)

Author: roggenkemper

static/app/views/issueDetails/actions/index.spec.tsx

@@ -182,30 +182,6 @@ describe('GroupActions', function () {
     });
   });
 
-  it('opens share modal from more actions dropdown', async () => {
-    const org = {
-      ...organization,
-      features: ['shared-issues'],
-    };
-
-    render(
-      <Fragment>
-        <GlobalModal />
-        <GroupActions group={group} project={project} disabled={false} event={null} />
-      </Fragment>,
-      {
-        organization: org,
-        deprecatedRouterMocks: true,
-      }
-    );
-
-    await userEvent.click(screen.getByLabelText('More Actions'));
-    await userEvent.click(await screen.findByText('Publish'));
-
-    const modal = screen.getByRole('dialog');
-    expect(within(modal).getByText('Publish Issue')).toBeInTheDocument();
-  });
-
   describe('delete', function () {
     it('opens delete confirm modal from more actions dropdown', async () => {
       const router = RouterFixture();

static/app/views/issueDetails/actions/index.tsx

@@ -49,7 +49,6 @@ import {useNavigate} from 'sentry/utils/useNavigate';
 import useOrganization from 'sentry/utils/useOrganization';
 import {hasDatasetSelector} from 'sentry/views/dashboards/utils';
 import {NewIssueExperienceButton} from 'sentry/views/issueDetails/actions/newIssueExperienceButton';
-import PublishIssueModal from 'sentry/views/issueDetails/actions/publishModal';
 import ShareIssueModal from 'sentry/views/issueDetails/actions/shareModal';
 import SubscribeAction from 'sentry/views/issueDetails/actions/subscribeAction';
 import {Divider} from 'sentry/views/issueDetails/divider';
@@ -96,9 +95,9 @@ export function GroupActions({group, project, disabled, event}: GroupActionsProp
       archiveUntilOccurrence: archiveUntilOccurrenceCap,
       delete: deleteCap,
       deleteAndDiscard: deleteDiscardCap,
-      share: shareCap,
       resolve: resolveCap,
       resolveInRelease: resolveInReleaseCap,
+      share: shareCap,
     },
     customCopy: {resolution: resolvedCopyCap},
     discover: discoverCap,
@@ -216,7 +215,7 @@ export function GroupActions({group, project, disabled, event}: GroupActionsProp
     openReprocessEventModal({organization, groupId: group.id});
   };
 
-  const onToggleShare = () => {
+  const onTogglePublicShare = () => {
     const newIsPublic = !group.isPublic;
     if (newIsPublic) {
       trackAnalytics('issue.shared_publicly', {
@@ -336,23 +335,9 @@ export function GroupActions({group, project, disabled, event}: GroupActionsProp
         organization={organization}
         groupId={group.id}
         event={event}
-      />
-    ));
-  };
-
-  const openPublishModal = () => {
-    trackAnalytics('issue_details.publish_issue_modal_opened', {
-      organization,
-      streamline: hasStreamlinedUI,
-      ...getAnalyticsDataForGroup(group),
-    });
-    openModal(modalProps => (
-      <PublishIssueModal
-        {...modalProps}
-        organization={organization}
-        projectSlug={group.project.slug}
-        groupId={group.id}
-        onToggle={onToggleShare}
+        onToggle={onTogglePublicShare}
+        projectSlug={project.slug}
+        hasIssueShare={shareCap.enabled}
       />
     ));
   };
@@ -463,6 +448,7 @@ export function GroupActions({group, project, disabled, event}: GroupActionsProp
           icon={<IconUpload />}
           aria-label={t('Share')}
           title={t('Share Issue')}
+          disabled={disabled}
           analyticsEventKey="issue_details.share_action_clicked"
           analyticsEventName="Issue Details: Share Action Clicked"
         />
@@ -494,6 +480,12 @@ export function GroupActions({group, project, disabled, event}: GroupActionsProp
           ...(hasStreamlinedUI
             ? []
             : [
+                {
+                  key: 'share',
+                  label: t('Share'),
+                  onAction: openShareModal,
+                  disabled,
+                },
                 {
                   key: group.isSubscribed ? 'unsubscribe' : 'subscribe',
                   className: 'hidden-sm hidden-md hidden-lg',
@@ -516,13 +508,6 @@ export function GroupActions({group, project, disabled, event}: GroupActionsProp
             details: !group.inbox || disabled ? t('Issue has been reviewed') : undefined,
             onAction: () => onUpdate({inbox: false}),
           },
-          {
-            key: 'publish',
-            label: t('Publish'),
-            disabled: disabled || !shareCap.enabled,
-            hidden: !organization.features.includes('shared-issues'),
-            onAction: openPublishModal,
-          },
           {
             key: bookmarkKey,
             label: bookmarkTitle,