Skip to content

Commit d1d0ce6

Browse files
committed
fix test
only fetch project if necessary
1 parent 470ba75 commit d1d0ce6

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/sentry/issues/occurrence_consumer.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -144,15 +144,15 @@ def _get_kwargs(payload: Mapping[str, Any]) -> Mapping[str, Any]:
144144
with metrics.timer("occurrence_ingest.duration", instance="_get_kwargs"):
145145
metrics.distribution("occurrence.ingest.size.data", len(payload), unit="byte")
146146
assignee_identifier = None
147-
project = Project.objects.get_from_cache(id=payload["project_id"])
148-
try:
149-
assignee = parse_and_validate_actor(
150-
payload.get("assignee"), project.organization_id
151-
)
152-
if assignee:
153-
assignee_identifier = assignee.identifier
154-
except Exception:
155-
logger.exception("Failed to validate assignee for occurrence")
147+
payload_assignee = payload.get("assignee")
148+
if payload_assignee:
149+
project = Project.objects.get_from_cache(id=payload["project_id"])
150+
try:
151+
assignee = parse_and_validate_actor(payload_assignee, project.organization_id)
152+
if assignee:
153+
assignee_identifier = assignee.identifier
154+
except Exception:
155+
logger.exception("Failed to validate assignee for occurrence")
156156

157157
occurrence_data = {
158158
"id": UUID(payload["id"]).hex,

tests/sentry/issues/test_occurrence_consumer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -387,8 +387,8 @@ def test_missing_event_id_in_event_data(self) -> None:
387387

388388
def test_project_ids_mismatch(self) -> None:
389389
message = deepcopy(get_test_message(self.project.id))
390-
message["project_id"] = 1
391-
message["event"]["project_id"] = 2
390+
message["project_id"] = self.project.id
391+
message["event"]["project_id"] = 999999999999
392392
with pytest.raises(InvalidEventPayloadError):
393393
_get_kwargs(message)
394394

0 commit comments

Comments
 (0)