Skip to content

Commit d3bc986

Browse files
author
Stephen Cefali
committed
use the correct dataset for snuba search
1 parent 06f9689 commit d3bc986

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

src/sentry/search/snuba/executors.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1119,7 +1119,7 @@ class InvalidQueryForExecutor(Exception):
11191119

11201120
class GroupAttributesPostgresSnubaQueryExecutor(PostgresSnubaQueryExecutor):
11211121
def get_basic_group_snuba_condition(
1122-
self, search_filter: SearchFilter, joined_entitity: Entity
1122+
self, search_filter: SearchFilter, joined_entity: Entity
11231123
) -> Condition:
11241124
"""
11251125
Returns the basic lookup for a search filter.
@@ -1131,22 +1131,22 @@ def get_basic_group_snuba_condition(
11311131
)
11321132

11331133
def get_basic_event_snuba_condition(
1134-
self, search_filter: SearchFilter, joined_entitity: Entity
1134+
self, search_filter: SearchFilter, joined_entity: Entity
11351135
) -> Condition:
11361136
"""
11371137
Returns the basic lookup for a search filter.
11381138
"""
11391139

1140-
dataset = Dataset.Events if joined_entitity.alias == "e" else Dataset.IssuePlatform
1140+
dataset = Dataset.Events if joined_entity.alias == "e" else Dataset.IssuePlatform
11411141

11421142
query_builder = UnresolvedQuery(
11431143
dataset=dataset,
1144-
entity=joined_entitity,
1144+
entity=joined_entity,
11451145
params={},
11461146
)
11471147
return query_builder.default_filter_converter(search_filter)
11481148

1149-
def get_assigned(self, search_filter: SearchFilter, joined_entitity: Entity) -> Condition:
1149+
def get_assigned(self, search_filter: SearchFilter, joined_entity: Entity) -> Condition:
11501150
"""
11511151
Returns the assigned lookup for a search filter.
11521152
"""
@@ -1182,7 +1182,7 @@ def get_assigned(self, search_filter: SearchFilter, joined_entitity: Entity) ->
11821182

11831183
return BooleanCondition(op=BooleanOp.OR, conditions=conditions)
11841184

1185-
def get_suggested(self, search_filter: SearchFilter, joined_entitity: Entity) -> Condition:
1185+
def get_suggested(self, search_filter: SearchFilter, joined_entity: Entity) -> Condition:
11861186
"""
11871187
Returns the suggested lookup for a search filter.
11881188
"""
@@ -1253,13 +1253,13 @@ def get_suggested(self, search_filter: SearchFilter, joined_entitity: Entity) ->
12531253
)
12541254

12551255
def get_assigned_or_suggested(
1256-
self, search_filter: SearchFilter, joined_entitity: Entity
1256+
self, search_filter: SearchFilter, joined_entity: Entity
12571257
) -> Condition:
12581258
return BooleanCondition(
12591259
op=BooleanOp.OR,
12601260
conditions=[
1261-
self.get_assigned(search_filter, joined_entitity),
1262-
self.get_suggested(search_filter, joined_entitity),
1261+
self.get_assigned(search_filter, joined_entity),
1262+
self.get_suggested(search_filter, joined_entity),
12631263
],
12641264
)
12651265

@@ -1430,8 +1430,9 @@ def query(
14301430
orderby=[OrderBy(sort_func, direction=Direction.DESC)],
14311431
limit=Limit(limit + 1),
14321432
)
1433+
dataset = Dataset.Events if joined_entity.alias == "e" else Dataset.IssuePlatform
14331434
request = Request(
1434-
dataset="events",
1435+
dataset=dataset,
14351436
app_id="group_attributes",
14361437
query=query,
14371438
tenant_ids=tenant_ids,
@@ -1447,7 +1448,7 @@ def query(
14471448
where=where_conditions,
14481449
)
14491450
request = Request(
1450-
dataset="events",
1451+
dataset=dataset,
14511452
app_id="group_attributes",
14521453
query=hits_query,
14531454
tenant_ids=tenant_ids,

0 commit comments

Comments
 (0)