ref: soft delete omt is_active

Author: JoshFerge

migrations_lockfile.txt

@@ -21,7 +21,7 @@ nodestore: 0001_squashed_0002_nodestore_no_dictfield
 
 replays: 0001_squashed_0005_drop_replay_index
 
-sentry: 0912_make_organizationmemberteam_replica_is_active_true
+sentry: 0913_soft_delete_omt_is_active
 
 social_auth: 0001_squashed_0002_default_auto_field
 

src/sentry/api/endpoints/organization_member/team_details.py

@@ -64,7 +64,6 @@ def serialize(
         self, obj: OrganizationMemberTeam, attrs: Mapping[Any, Any], user: Any, **kwargs: Any
     ) -> OrganizationMemberTeamSerializerResponse:
         return {
-            "isActive": obj.is_active,
             "teamRole": obj.role,  # type:ignore[typeddict-item]
         }
 

src/sentry/migrations/0913_soft_delete_omt_is_active.py

@@ -0,0 +1,34 @@
+# Generated by Django 5.2.1 on 2025-05-22 21:31
+
+
+from sentry.new_migrations.migrations import CheckedMigration
+from sentry.new_migrations.monkey.fields import SafeRemoveField
+from sentry.new_migrations.monkey.state import DeletionAction
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production.
+    # This should only be used for operations where it's safe to run the migration after your
+    # code has deployed. So this should not be used for most operations that alter the schema
+    # of a table.
+    # Here are some things that make sense to mark as post deployment:
+    # - Large data migrations. Typically we want these to be run manually so that they can be
+    #   monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   run this outside deployments so that we don't block them. Note that while adding an index
+    #   is a schema change, it's completely safe to run the operation after the code has deployed.
+    # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
+
+    is_post_deployment = False
+
+    dependencies = [
+        ("sentry", "0912_make_organizationmemberteam_replica_is_active_true"),
+    ]
+
+    operations = [
+        SafeRemoveField(
+            model_name="organizationmemberteam",
+            name="is_active",
+            deletion_action=DeletionAction.MOVE_TO_PENDING,
+        ),
+    ]

src/sentry/models/organizationmemberteam.py

@@ -29,9 +29,6 @@ class OrganizationMemberTeam(ReplicatedRegionModel):
     id = BoundedAutoField(primary_key=True)
     team = FlexibleForeignKey("sentry.Team")
     organizationmember = FlexibleForeignKey("sentry.OrganizationMember")
-    # an inactive membership simply removes the team from the default list
-    # but still allows them to re-join without request
-    is_active = models.BooleanField(db_default=True)
     role = models.CharField(max_length=32, null=True, blank=True)
 
     class Meta:
@@ -76,7 +73,6 @@ def get_audit_log_data(self):
             "team_slug": self.team.slug,
             "member_id": self.organizationmember_id,
             "email": self.organizationmember.get_email(),
-            "is_active": self.is_active,
         }
 
     def get_team_role(self) -> TeamRole:

src/sentry/models/project.py

@@ -458,7 +458,6 @@ def member_set(self):
 
         return self.organization.member_set.filter(
             id__in=OrganizationMember.objects.filter(
-                organizationmemberteam__is_active=True,
                 organizationmemberteam__team__in=self.teams.all(),
             ).values("id"),
             user_is_active=True,

src/sentry/models/team.py

@@ -67,7 +67,7 @@ def get_for_user(
                 return []
 
             org_member_team_filter = OrganizationMemberTeam.objects.filter(
-                organizationmember=om, is_active=True
+                organizationmember=om,
             )
             if is_team_admin:
                 org_member_team_filter = org_member_team_filter.filter(role="admin")
@@ -175,7 +175,6 @@ def member_set(self):
         """:returns a QuerySet of all Users that belong to this Team"""
         return self.organization.member_set.filter(
             organizationmemberteam__team=self,
-            organizationmemberteam__is_active=True,
             user_id__isnull=False,
             user_is_active=True,
         ).distinct()

src/sentry/organizations/services/organization/serial.py

@@ -58,7 +58,7 @@ def serialize_member(member: OrganizationMember) -> RpcOrganizationMember:
     )
 
     omts = OrganizationMemberTeam.objects.filter(
-        organizationmember=member, is_active=True, team__status=TeamStatus.ACTIVE
+        organizationmember=member, team__status=TeamStatus.ACTIVE
     ).select_related("team")
 
     all_project_ids: set[int] = set()
@@ -108,7 +108,7 @@ def _serialize_team_member(
     result = RpcTeamMember(
         id=team_member.id,
         slug=team_member.team.slug,
-        is_active=team_member.is_active,
+        is_active=True,  # this field is being deprecated on the omt model
         role_id=team_member.get_team_role().id,
         team_id=team_member.team_id,
         project_ids=list(project_ids),
@@ -161,6 +161,6 @@ def serialize_rpc_organization_member_team(
         team_id=omt.team_id,
         organizationmember_id=omt.organizationmember_id,
         organization_id=omt.organizationmember.organization_id,
-        is_active=omt.is_active,
+        is_active=True,  # this field is being deprecated on the omt model
         role=omt.role,
     )