ref(workflow_engine): Refactor the StatefulGroupingDetector Handler (#91246)

## Description
This PR pulls the logic for evaluating a stateful detector that doesn't
include grouping.

---------

Co-authored-by: Colleen O'Rourke <colleen@sentry.io>

Author: saponifi3d

src/sentry/grouping/grouptype.py

@@ -5,9 +5,13 @@
 from sentry.models.group import DEFAULT_TYPE_ID
 from sentry.types.group import PriorityLevel
 from sentry.workflow_engine.endpoints.validators.error_detector import ErrorDetectorValidator
-from sentry.workflow_engine.handlers.detector.base import DetectorEvaluationResult, DetectorHandler
+from sentry.workflow_engine.handlers.detector.base import DetectorHandler
 from sentry.workflow_engine.models.data_source import DataPacket
-from sentry.workflow_engine.types import DetectorGroupKey, DetectorSettings
+from sentry.workflow_engine.types import (
+    DetectorEvaluationResult,
+    DetectorGroupKey,
+    DetectorSettings,
+)
 
 T = TypeVar("T")
 

src/sentry/incidents/grouptype.py

@@ -18,6 +18,7 @@
 )
 from sentry.workflow_engine.handlers.detector.base import EvidenceData
 from sentry.workflow_engine.models.data_source import DataPacket
+from sentry.workflow_engine.processors.data_condition_group import ProcessedDataConditionGroup
 from sentry.workflow_engine.types import DetectorGroupKey, DetectorPriorityLevel, DetectorSettings
 
 COMPARISON_DELTA_CHOICES: list[None | int] = [choice.value for choice in ComparisonDeltaChoices]
@@ -32,7 +33,8 @@ class MetricIssueEvidenceData(EvidenceData):
 class MetricAlertDetectorHandler(StatefulGroupingDetectorHandler[QuerySubscriptionUpdate, int]):
     def create_occurrence(
         self,
-        value: int,
+        evaluation_result: ProcessedDataConditionGroup,
+        data_packet: DataPacket[QuerySubscriptionUpdate],
         priority: DetectorPriorityLevel,
     ) -> tuple[DetectorOccurrence, dict[str, Any]]:
         # Returning a placeholder for now, this may require us passing more info

src/sentry/workflow_engine/handlers/detector/__init__.py

@@ -1,18 +1,11 @@
 __all__ = [
     "DataPacketEvaluationType",
     "DataPacketType",
-    "DetectorEvaluationResult",
     "DetectorHandler",
     "DetectorOccurrence",
     "DetectorStateData",
     "StatefulGroupingDetectorHandler",
 ]
 
-from .base import (
-    DataPacketEvaluationType,
-    DataPacketType,
-    DetectorEvaluationResult,
-    DetectorHandler,
-    DetectorOccurrence,
-)
+from .base import DataPacketEvaluationType, DataPacketType, DetectorHandler, DetectorOccurrence
 from .stateful import DetectorStateData, StatefulGroupingDetectorHandler

src/sentry/workflow_engine/handlers/detector/base.py

@@ -8,15 +8,21 @@
 
 from sentry.issues.grouptype import GroupType
 from sentry.issues.issue_occurrence import IssueEvidence, IssueOccurrence
-from sentry.issues.status_change_message import StatusChangeMessage
 from sentry.types.actor import Actor
 from sentry.workflow_engine.models import Condition, DataConditionGroup, DataPacket, Detector
-from sentry.workflow_engine.types import DetectorGroupKey, DetectorPriorityLevel
+from sentry.workflow_engine.processors.data_condition_group import ProcessedDataConditionGroup
+from sentry.workflow_engine.types import (
+    DetectorEvaluationResult,
+    DetectorGroupKey,
+    DetectorPriorityLevel,
+)
 
 logger = logging.getLogger(__name__)
 
 DataPacketType = TypeVar("DataPacketType")
 DataPacketEvaluationType = TypeVar("DataPacketEvaluationType")
+
+# TODO - get more info about how this is used in issue platform
 EventData = dict[str, Any]
 
 
@@ -35,14 +41,14 @@ class EvidenceData(Generic[DataPacketEvaluationType]):
 class DetectorOccurrence:
     issue_title: str
     subtitle: str
-    resource_id: str | None = None
     evidence_data: Mapping[str, Any] = dataclasses.field(default_factory=dict)
     evidence_display: Sequence[IssueEvidence] = dataclasses.field(default_factory=list)
     type: type[GroupType]
     level: str
     culprit: str
-    priority: int | None = None
+    resource_id: str | None = None
     assignee: Actor | None = None
+    priority: DetectorPriorityLevel | None = None
 
     def to_issue_occurrence(
         self,
@@ -73,20 +79,6 @@ def to_issue_occurrence(
         )
 
 
-@dataclasses.dataclass(frozen=True)
-class DetectorEvaluationResult:
-    # TODO - Should group key live at this level?
-    group_key: DetectorGroupKey
-    # TODO: Are these actually necessary? We're going to produce the occurrence in the detector, so we probably don't
-    # need to know the other results externally
-    is_triggered: bool
-    priority: DetectorPriorityLevel
-    # TODO: This is only temporarily optional. We should always have a value here if returning a result
-    result: IssueOccurrence | StatusChangeMessage | None = None
-    # Event data to supplement the `IssueOccurrence`, if passed.
-    event_data: dict[str, Any] | None = None
-
-
 # TODO - DetectorHandler -> AbstractDetectorHandler? (then DetectorHandler is the base implementation)
 class DetectorHandler(abc.ABC, Generic[DataPacketType, DataPacketEvaluationType]):
     def __init__(self, detector: Detector):
@@ -109,7 +101,7 @@ def __init__(self, detector: Detector):
     @abc.abstractmethod
     def evaluate(
         self, data_packet: DataPacket[DataPacketType]
-    ) -> dict[DetectorGroupKey, DetectorEvaluationResult]:
+    ) -> dict[DetectorGroupKey, DetectorEvaluationResult] | None:
         """
         This method is used to evaluate the data packet's value against the conditions on the detector.
         """
@@ -118,10 +110,9 @@ def evaluate(
     @abc.abstractmethod
     def create_occurrence(
         self,
-        value: DataPacketEvaluationType,
+        evaluation_result: ProcessedDataConditionGroup,
+        data_packet: DataPacket[DataPacketType],
         priority: DetectorPriorityLevel,
-        # data_packet: DataPacketType, # TODO - having access to all the data being evaluated seems good
-        # data_conditions: list[DataCondition], # TODO - list of the failing conditions might be nice
     ) -> tuple[DetectorOccurrence, EventData]:
         """
         This method provides the value that was evaluated against, the data packet that was