Skip to content

Commit da0a1a3

Browse files
authored
ref: make organizationmemberteam is_active db default true (#92064)
This field is never set to False. In production i've checked, and we have 0 rows where `is_active` is False [here](https://redash.getsentry.net/queries/8899/source). i'd like to remove this field, and as a first step we're going to make it `db_default=True` in the database. following https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns
1 parent 75e743d commit da0a1a3

File tree

3 files changed

+35
-2
lines changed

3 files changed

+35
-2
lines changed

migrations_lockfile.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ nodestore: 0001_squashed_0002_nodestore_no_dictfield
2121

2222
replays: 0001_squashed_0005_drop_replay_index
2323

24-
sentry: 0909_django_array_field_not_release
24+
sentry: 0910_make_organizationmemberteam_is_active_default
2525

2626
social_auth: 0001_squashed_0002_default_auto_field
2727

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# Generated by Django 5.2.1 on 2025-05-21 20:55
2+
3+
from django.db import migrations, models
4+
5+
from sentry.new_migrations.migrations import CheckedMigration
6+
7+
8+
class Migration(CheckedMigration):
9+
# This flag is used to mark that a migration shouldn't be automatically run in production.
10+
# This should only be used for operations where it's safe to run the migration after your
11+
# code has deployed. So this should not be used for most operations that alter the schema
12+
# of a table.
13+
# Here are some things that make sense to mark as post deployment:
14+
# - Large data migrations. Typically we want these to be run manually so that they can be
15+
# monitored and not block the deploy for a long period of time while they run.
16+
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
17+
# run this outside deployments so that we don't block them. Note that while adding an index
18+
# is a schema change, it's completely safe to run the operation after the code has deployed.
19+
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
20+
21+
is_post_deployment = False
22+
23+
dependencies = [
24+
("sentry", "0909_django_array_field_not_release"),
25+
]
26+
27+
operations = [
28+
migrations.AlterField(
29+
model_name="organizationmemberteam",
30+
name="is_active",
31+
field=models.BooleanField(db_default=True),
32+
),
33+
]

src/sentry/models/organizationmemberteam.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class OrganizationMemberTeam(ReplicatedRegionModel):
3131
organizationmember = FlexibleForeignKey("sentry.OrganizationMember")
3232
# an inactive membership simply removes the team from the default list
3333
# but still allows them to re-join without request
34-
is_active = models.BooleanField(default=True)
34+
is_active = models.BooleanField(db_default=True)
3535
role = models.CharField(max_length=32, null=True, blank=True)
3636

3737
class Meta:

0 commit comments

Comments
 (0)