Skip to content

Commit db3a1ad

Browse files
asottile-sentryandrewshie-sentry
authored andcommitted
ref: fix type of Group.priority (#91874)
it is integer in production, this table is far too large to rewrite so adjust the model definition to match <!-- Describe your PR here. -->
1 parent 1fd59f5 commit db3a1ad

File tree

3 files changed

+39
-2
lines changed

3 files changed

+39
-2
lines changed

migrations_lockfile.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ remote_subscriptions: 0003_drop_remote_subscription
2121

2222
replays: 0005_drop_replay_index
2323

24-
sentry: 0897_rm_extraneous_groupedmessage_index
24+
sentry: 0898_groupedmessage_wrong_int_type
2525

2626
social_auth: 0002_default_auto_field
2727

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# Generated by Django 5.2.1 on 2025-05-19 14:07
2+
3+
from django.db import migrations, models
4+
5+
from sentry.new_migrations.migrations import CheckedMigration
6+
7+
8+
class Migration(CheckedMigration):
9+
# This flag is used to mark that a migration shouldn't be automatically run in production.
10+
# This should only be used for operations where it's safe to run the migration after your
11+
# code has deployed. So this should not be used for most operations that alter the schema
12+
# of a table.
13+
# Here are some things that make sense to mark as post deployment:
14+
# - Large data migrations. Typically we want these to be run manually so that they can be
15+
# monitored and not block the deploy for a long period of time while they run.
16+
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
17+
# run this outside deployments so that we don't block them. Note that while adding an index
18+
# is a schema change, it's completely safe to run the operation after the code has deployed.
19+
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
20+
21+
is_post_deployment = False
22+
23+
dependencies = [
24+
("sentry", "0897_rm_extraneous_groupedmessage_index"),
25+
]
26+
27+
operations = [
28+
migrations.SeparateDatabaseAndState(
29+
state_operations=[
30+
migrations.AlterField(
31+
model_name="group",
32+
name="priority",
33+
field=models.PositiveIntegerField(null=True),
34+
),
35+
]
36+
)
37+
]

src/sentry/models/group.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ class Group(Model):
600600
type = BoundedPositiveIntegerField(
601601
default=DEFAULT_TYPE_ID, db_default=DEFAULT_TYPE_ID, db_index=True
602602
)
603-
priority = models.PositiveSmallIntegerField(null=True)
603+
priority = models.PositiveIntegerField(null=True)
604604
priority_locked_at = models.DateTimeField(null=True)
605605
seer_fixability_score = models.FloatField(null=True)
606606
seer_autofix_last_triggered = models.DateTimeField(null=True)

0 commit comments

Comments
 (0)